Valgrind errors on custom type

[Noam Sagi]

Hi,

When I ran valgrind I get this error on custom type:

==3814== Conditional jump or move depends on uninitialised value(s)

==3814==    at 0x4310AC: lzf_compress (lzf_c.c:148)

==3814==    by 0x444C2A: rdbSaveLzfStringObject (rdb.c:319)

==3814==    by 0x444FDD: rdbSaveRawString (rdb.c:391)

==3814==    by 0x445FA6: rdbSaveObject (rdb.c:666)

==3814==    by 0x4462ED: rdbSavedObjectLen (rdb.c:789)

==3814==    by 0x4636A6: debugCommand (debug.c:389)

==3814==    by 0x42A27D: call (server.c:2128)

==3814==    by 0x42A936: processCommand (server.c:2408)

==3814==    by 0x439624: processInputBuffer (networking.c:1272)

==3814==    by 0x424C17: aeProcessEvents (ae.c:412)

==3814==    by 0x424ECA: aeMain (ae.c:455)

==3814==    by 0x421EAC: main (server.c:3720)

I don't think its something in my code, but I'm not sure.

I also get these errors on my own code, but when I comment all the content of RDB Load/Save code of

the custom type, I still get this error.

Any idea?

Should I update redis? rmutil?

It happens only when I use my module from python client. Not when I run TS.TEST from redis-cli

BTW, it doesn't seem to affect anything. Just disturbing my peace :)

The code is at https://github.com/saginoam/RedisModuleTimeSeries/tree/master/timeseries

Thanks,

Noam

[Salvatore Sanfilippo]

Hello. False positive, see the Redis valgrind suppression list under
"src" in the source distribution. Cheers

> --
> You received this message because you are subscribed to the Google Groups
> "redis-module-devs" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to redis-module-d...@googlegroups.com.
> To post to this group, send email to redis-mo...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/redis-module-devs/2004f441-7379-46e5-ba4f-c1dc6f617d6f%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



--
Salvatore 'antirez' Sanfilippo
open source developer - Redis Labs https://redislabs.com

"If a system is to have conceptual integrity, someone must control the
concepts."
— Fred Brooks, "The Mythical Man-Month", 1975.

[Noam Sagi]

Hi,

It worked. It suppressed the errors in my code as well.

Thanks.