test_move, hack.c: Bug? (opening doors)

[Philipp Lucas]

In the process of applying the autoopen patch to 3.4.0, I had to look at
test_move in hack.c and noticed something strange. Please point your eyes
to lines 580--593, in particular the nesting of #else and else. This means
that, whenever STEED is even compiled into the game, you can't bump into
doors anymore.

This doesn't look right. Comments?

--
Philipp Lucas
phl...@online-club.de

[John Eras]

"Philipp Lucas" <phl...@online-club.de> wrote in message
news:a7mf6j$mj1b2$1...@ID-3042.news.dfncis.de...

> In the process of applying the autoopen patch to 3.4.0, I had to look at
> test_move in hack.c and noticed something strange. Please point your eyes
> to lines 580--593, in particular the nesting of #else and else. This means
> that, whenever STEED is even compiled into the game, you can't bump into
> doors anymore.
>
> This doesn't look right. Comments?

Looks like you're right to my eye also. Here's what I think it should look
like:

*** old/hack.c Wed Mar 20 15:43:06 2002
--- ./hack.c Sun Mar 24 23:53:28 2002
***************
*** 584,593 ****
u.usteed->mnamelth ? ARTICLE_NONE : ARTICLE_THE,
(char *)0, SUPPRESS_SADDLE, FALSE));
else {
! #else
pline("Ouch! You bump into a door.");
exercise(A_DEX, FALSE);
- #endif
#ifdef STEED
}
#endif
--- 584,592 ----
u.usteed->mnamelth ? ARTICLE_NONE : ARTICLE_THE,
(char *)0, SUPPRESS_SADDLE, FALSE));
else {
! #endif
pline("Ouch! You bump into a door.");
exercise(A_DEX, FALSE);
#ifdef STEED
}
#endif

-Killdozer