[ToME 2.1.1] More patches

3 views
Skip to first unread message

Scott Bigham

unread,
Feb 16, 2003, 2:04:31 AM2/16/03
to
Put up a few more patches in my ToME repository at
<http://www.killerbunnies.org/angband/#tome>:

tome-boomfix.diff:
Fixes two boomerang-related bugs:

- A boomerang's slay and brand flags weren't being applied to its
damage.
- Boomerangs weren't getting the average-damage listing like
weapons and ammo do when examined with the 'I' command.

tome-symbname.diff:
Changes some game messages like "Your symbiote is healed" to refer
to your symbiote by race, as in "Your Grape jelly is healed". Also,
for those sentimental Symbiants who like to name your symbiotes,
it adds a few tweaks to use ToME's fake-artifact-name inscription
trick: Just inscribe your symbiote with '#named Fido" using the '{'
command, and it will be listed in your equipment as "a Grape jelly
named Fido (416 hp)", and game messages will say "Fido is healed."
;)

tome-charge.diff:
Every Alchemist that's ever had to stuff 500 Teleport essences into
their Staff of Teleportation one at a time has probably wished for a
"repeat-until-done" version of the Recharge command, as Leech does
for the Extract command. This patch adds such a command, Charge
('c'). [NB: The Charge command isn't actually displayed in the
on-screen list of alchemy commands, because there isn't room for it;
it is there, though. I'm trying to figure out a way to fix this.]
This patch also fixes a nasty little bug that pops up if you try to
recharge a stack of staffs: the staff getting charged is unstacked
from the rest and charged as usual -- and then transmogrified into a
copy of your gloves... 8-O

Some of the other content in the repository has also been updated: the
skill spoiler has an expanded section on Mindcraft, and the tomespoil.pl
script now displays monster information of interest to Possessors. And
as always, We Thank You for Your Support(TM).

-sbigham

fearoffours

unread,
Feb 16, 2003, 5:00:35 AM2/16/03
to
On 2003-02-16 08:04:31, Scott Bigham <d...@killerbunnies.org> wrote:


> tome-boomfix.diff:
> Fixes two boomerang-related bugs:

neat.

> tome-symbname.diff:
> Changes some game messages like "Your symbiote is healed" to refer
> to your symbiote by race, as in "Your Grape jelly is healed". Also,

> Just inscribe your symbiote with '#named Fido" using the '{'
> command, and it will be listed in your equipment as "a Grape jelly
> named Fido (416 hp)", and game messages will say "Fido is healed."
> ;)

Hahahahahah absolutely effing brilliant. What a cool little idea.


> tome-charge.diff:


> This patch adds such a command, Charge
> ('c'). [NB: The Charge command isn't actually displayed in the
> on-screen list of alchemy commands, because there isn't room for it;
> it is there, though. I'm trying to figure out a way to fix this.]

Neato!


--
fearoffours
Martin Hatfield

Jeff Epler

unread,
Feb 16, 2003, 9:48:12 AM2/16/03
to
On Sun, Feb 16, 2003 at 07:04:31AM +0000, Scott Bigham wrote:
> This patch adds such a command, Charge
> ('c'). [NB: The Charge command isn't actually displayed in the
> on-screen list of alchemy commands, because there isn't room for it;
> it is there, though. I'm trying to figure out a way to fix this.]

It looks like you could fit it in as
[P]ower, [R]e[C]harge, ...
though it wouldn't be clear that R adds a single charge and C adds as many
charges as you can. (Would prompting for a number of charges to add be
better, like the 'fill bottles' prompt now does? Though I always find
myself entering '99' at that prompt anyway..)

Jeff


-----= Posted via Newsfeeds.Com, Uncensored Usenet News =-----
http://www.newsfeeds.com - The #1 Newsgroup Service in the World!
-----== Over 80,000 Newsgroups - 16 Different Servers! =-----

Scott Bigham

unread,
Feb 16, 2003, 11:57:50 AM2/16/03
to
From the Holy Book of <mailman.104540...@unpythonic.net>
as spake by Jeff Epler (jep...@unpythonic.net):

> On Sun, Feb 16, 2003 at 07:04:31AM +0000, Scott Bigham wrote:
> > This patch adds such a command, Charge
> > ('c'). [NB: The Charge command isn't actually displayed in the
> > on-screen list of alchemy commands, because there isn't room for it;
> > it is there, though. I'm trying to figure out a way to fix this.]

> It looks like you could fit it in as
> [P]ower, [R]e[C]harge, ...
> though it wouldn't be clear that R adds a single charge and C adds as many
> charges as you can.

Yeah, I thought about trying that. It would be very tight, but it looks
like it would just barely fit. There is the ambiguity problem, though,
as you observe. I briefly considered switching to a full-blown menu
like some of the other powers use, but that would have been a much more
substantial code change, and would've really screwed with people's
muscle memory.

> (Would prompting for a number of charges to add be better, like the
> 'fill bottles' prompt now does? Though I always find myself entering
> '99' at that prompt anyway..)

I considered that too; I wasn't sure whether it might trip up anyone's
muscle memory having to type in an extra number after choosing a
wand/staff. Opinions from other would-be users of this? (And you'd
need to be able to enter a repeat of more than 99; as the write-up
suggested, I've found myself stuffing several hundred charges into a
wand or staff at one sitting.)

And as always, of course, we appreciate the feedback. ;)

-sbigham

Tormod Haugen

unread,
Feb 16, 2003, 1:18:07 PM2/16/03
to
On Sun, 16 Feb 2003 16:57:50 +0000, Scott Bigham wrote:

> From the Holy Book of <mailman.104540...@unpythonic.net>
> as spake by Jeff Epler (jep...@unpythonic.net):
>> On Sun, Feb 16, 2003 at 07:04:31AM +0000, Scott Bigham wrote:
>> > This patch adds such a command, Charge ('c'). [NB: The Charge
>> > command isn't actually displayed in the on-screen list of alchemy
>> > commands, because there isn't room for it; it is there, though.
>> > I'm trying to figure out a way to fix this.]
>
>> It looks like you could fit it in as
>> [P]ower, [R]e[C]harge, ...
>> though it wouldn't be clear that R adds a single charge and C adds as
>> many charges as you can.
>
> Yeah, I thought about trying that. It would be very tight, but it looks
> like it would just barely fit. There is the ambiguity problem, though,
> as you observe.

[snip]

What about confusing users even more, and let the [R]eCharge do a full
recharge, and Re[C]harge put one in? I feel that would sound .better.

(Recharge the X - add lots / Add a Charge to X - add one)?

>And as always, of course, we appreciate the feedback. ;)

Good for you... Er *us*, /Good for US/ I mean ;)

tormodh
--
.sig?

Jeff Epler

unread,
Feb 16, 2003, 1:35:10 PM2/16/03
to
How about:
[P]ower item, ([F]ully) [C]harge stick, [E]xtract ([A]ll) magic, or [R]ecipes?
that fits in 80 columns, but changes the characters
R -> C (recharge -> charge)
L -> A (leech -> all)
B -> R (book -> recipes)
and uses "magic" for "essences".

Or maybe:
[P]ower item, ([F]ully) [R]echarge stick, [E]xtract ([A]ll) magic, or [C]ookbook?

It uses all 80 columns (no room for the cursor -- but the word "stick" is
optional). "leech" is still remapped to a different letter as "(al[L])" is
hard to read IMO)

[P]ower item, ([F]ully) [R]echarge, [E]xtract ([A]ll) magic, or recipe [B]ook?
[P]ower item, ([F]ully) [R]echarge, [E]xtract ([A]ll) essences, or recipe [B]ook?
[P]ower item, ([F]ully) [R]echarge, [E]xtract ([A]ll) essences, or [C]ookbook?
[P]ower item, ([F]ully) [R]echarge, [E]xtract (al[L]) essences, or [C]ookbook?
[P]ower item, ([F]ully) [R]echarge, [E]xtract (al[L]) essences, or recipe [B]ook?

some more choices.... the last one leaves all chars the same and is 80 chars
wide.

Couldn't you also use color to show which character stands for the command?
Power item, (Fully) Recharge, Extract (alL) essences, or recipe Book?
^ ^ ^ ^ ^ ^
(I'm not sure if you can colorize prompts like this, but it'd be nice)

What about powering multiple items at once? For instance, my early
characters seem to spend a lot of time creating the same item, one that
sells for a big whack of money. For instance, acidic whips or torches of
fearlessness, then selling all the store will take. It's a bit of an
annoyance, but nothing big...

Scott Bigham

unread,
Feb 16, 2003, 9:29:41 PM2/16/03
to
From the Holy Book of <mailman.104542...@unpythonic.net>

as spake by Jeff Epler (jep...@unpythonic.net):
> [...]

> [P]ower item, ([F]ully) [R]echarge, [E]xtract ([A]ll) magic, or
> recipe [B]ook?

Of your suggestions, I like this one the best (though I might write it
as "[R]echarge ([F]ully)"). The next opinion to solicit, I suppose,
would be DarkGod's, since if he doesn't like what I choose here, he may
not add this to the release code. [Frankly, the full-blown-menu
alternative is looking more and more attractive, but I'm not going down
that road without DG's okay.]

> Couldn't you also use color to show which character stands for the command?
> Power item, (Fully) Recharge, Extract (alL) essences, or recipe Book?
> ^ ^ ^ ^ ^ ^
> (I'm not sure if you can colorize prompts like this, but it'd be nice)

Not AFAICT; not easily, at least. And color can be turned off at the
options screen, so I assume it's intended to be possible to play ToME on
a monochrome terminal.

> What about powering multiple items at once?

Ouch, that starts getting *really* tricky. At that point in the code,
the program has its own idea about which item in the inventory is being
manipulated, and you have to be very careful about how much inventory
juggling you do or the program will get confused and Very Bad Things(TM)
will happen. For the Charge command, I was able to mimic the inventory
juggling that the Leech command does, since it faces much the same
issues; trying to juggle a stack of a dozen Daggers getting unstacked
into a dozen separate inventory slots without the program going rogue
and making a Shocking Food Ration is more bite-off than I think I can
chew.

-sbigham

Foo

unread,
Feb 17, 2003, 10:26:58 PM2/17/03
to
> trying to juggle a stack of a dozen Daggers getting unstacked
> into a dozen separate inventory slots without the program going rogue
> and making a Shocking Food Ration is more bite-off than I think I can
> chew.
yum! I want one!

Reply all
Reply to author
Forward
0 new messages