[slashem] Warning message on startup

[Janis Papanagnou]

I've never seen such a warning as very first first message in a Slashem
game...

Warning: club should be at least skilled. Fixing...
Velkommen jap, welcome to SlashEM! You are a lawful dwarven Valkyrie.
You are lucky! Full moon tonight.

The Valkyrie doesn't even have a club...

Weapons
a - a +1 dwarvish spear (weapon in hand) {35}
b - 5 +0 daggers {50}
Armor
c - an uncursed +3 small shield (being worn) {30}
Comestibles
d - an uncursed food ration {20}
Tools
e - 2 +0 torches (alternate weapon; not wielded) {40}

Strange message.

Janis

[Pat Rankin]

On Thursday, September 23, 2021 at 4:29:55 AM UTC-7, Janis wrote:
> I've never seen such a warning as very first first message in a Slashem
> game...
>
> Warning: club should be at least skilled. Fixing...
> Velkommen jap, welcome to SlashEM! You are a lawful dwarven Valkyrie.

[ ...inventory, which includes 2 torches, snipped... ]

It wants to make sure that your club skill's limit is at least skilled
because you are starting with clubs: those torches. When wielded,
torches are treated as weapons which use club skill. Valkyries
are normally restricted in club skill. After that message, yours isn't.

That message will occur for any role that gets torches (for games
where they actually start with some, that is) and is restricted or
limited to basic in club skill.

Possibly Valkyrie is the only role that can meet both criteria to
trigger the bug. In one game out of six they have a 50:50 chance
to start with an oil lamp or torch(es). So one Valkyrie game in
twelve, on average, would show that message (which despite
being labeled as 'warning:' as part of the message text isn't
delivered via impossible() so doesn't add the "program in disorder"
companion message that warning messages have).