Long Time Reactor Flaws

[Sami Hoda]

Hey Folks,

Its been a while since I updated my Reactor locally from the SVN
trunk.

I noticed that since we started using Reactor back in 06, a couple
flaws we mentioned back then still have not yet been fixed. So they
exists as hacks locally, making it harder for us to upgrade.

I thought I'd mention them here as a reminder.

For MSSQL - support for schemas. So, if a table is named
dbo.tableName, Reactor works fine. But if we have schemaName.tableName
(no more dbo!), Reactor freaks out. It always assumes you are using
very basic MSSQL tables.

For MSSQL - ignore replication column. When doing replication on MSSQL
between two servers in MSSQL, MSSQL creates a column called "rowGUID"
on each table. Reactor tries to mess with this column, when it should
be ignoring it all together.

And I think there may be one other thing I'm forgetting, but this is
enough to get the conversation started.

[Doug Hughes]

I'm probably going to make waves by saying this, but I'm wondering if anyone is really even guiding the project any more.  Mark?  I know it's probably a bit sad, but I've personally moved on from Reactor.  I still use it in a number of projects, but these days the Alagad team is doing most new development using Hibernate. 

If anyone else out there is still alive, what should be done about schema support?  Should it be added at this late stage in the game?  Should Sami contribute his hacks?  If yes, to whom?

Doug Hughes, President
Alagad Inc.
dhu...@alagad.com
888 Alagad4 (x300)
Direct: 651 Alagad4 (651-252-4234)
Fax: 888-248-7836

--

You received this message because you are subscribed to the Google Groups "Reactor" group.
To post to this group, send email to reacto...@googlegroups.com.
To unsubscribe from this group, send email to reactor-user...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/reactor-users?hl=en.

[Sami Hoda]

Thanks Doug. If we had some clear direction, even if it means EOL'ing
Reactor, then I'm fine with that.

We can do without the latest enhancements, and we'll keep our hacks.

So thanks for being frank.

Sami

On Jan 4, 12:53 pm, Doug Hughes <dhug...@alagad.com> wrote:
> I'm probably going to make waves by saying this, but I'm wondering if anyone
> is really even guiding the project any more.  Mark?  I know it's probably a
> bit sad, but I've personally moved on from Reactor.  I still use it in a
> number of projects, but these days the Alagad team is doing most new
> development using Hibernate.
>
> If anyone else out there is still alive, what should be done about schema
> support?  Should it be added at this late stage in the game?  Should Sami
> contribute his hacks?  If yes, to whom?
>
> Doug Hughes, President
> Alagad Inc.

> dhug...@alagad.com

> 888 Alagad4 (x300)
> Direct: 651 Alagad4 (651-252-4234)
> Fax: 888-248-7836
>

> On Mon, Jan 4, 2010 at 3:07 PM, Sami Hoda <s...@bytestopshere.com> wrote:
> > Hey Folks,
>
> > Its been a while since I updated my Reactor locally from the SVN
> > trunk.
>
> > I noticed that since we started using Reactor back in 06, a couple
> > flaws we mentioned back then still have not yet been fixed. So they
> > exists as hacks locally, making it harder for us to upgrade.
>
> > I thought I'd mention them here as a reminder.
>
> > For MSSQL - support for schemas. So, if a table is named
> > dbo.tableName, Reactor works fine. But if we have schemaName.tableName
> > (no more dbo!), Reactor freaks out. It always assumes you are using
> > very basic MSSQL tables.
>
> > For MSSQL - ignore replication column. When doing replication on MSSQL
> > between two servers in MSSQL, MSSQL creates a column called "rowGUID"
> > on each table. Reactor tries to mess with this column, when it should
> > be ignoring it all together.
>
> > And I think there may be one other thing I'm forgetting, but this is
> > enough to get the conversation started.
>
> > --
>
> > You received this message because you are subscribed to the Google Groups
> > "Reactor" group.
> > To post to this group, send email to reacto...@googlegroups.com.
> > To unsubscribe from this group, send email to

> > reactor-user...@googlegroups.com<reactor-users%2Bunsu...@googlegroups.com>

[Mark Drew]

Hi there, 

I am indeed guiding the project, I have just been lost in the mire of another project which has added a few enhancements that I need some time to document (like injecting beans into reacor objects, getByFilter objects as well as a few other things that I can't remember off the top of my head)

I can see people moving to Hibernate with good reason and hence I have been working to just make hibernate another back end ORM for reactor itself. As well as a bunch of speed improvements, which yes, I have been lack in commiting. 

If there are hacks for schema support, email them to me and I shall commit them!

Regards

Mark Drew

Mark Drew

Railo Technologies UK

Professional Open Source

skype: mark_railo

ma...@getrailo.com

+44 7971 85  22 96

www.getrailo.com

[denstar]

Yeah, maybe it's just me, but I think I've seen more commits since MD
started on stuff than I had in like at least a year or so prior... =)

Thanks Mark!

:DeN

--
Raising children is an uncertain thing; success is reached only after
a life of battle and worry.
Democritus

[Doug Hughes]

I honestly haven't been watching.... so I'm no authority.

Doug Hughes, President
Alagad Inc.
dhu...@alagad.com
888 Alagad4 (x300)
Direct: 651 Alagad4 (651-252-4234)
Fax: 888-248-7836

[denstar]

On Mon, Jan 4, 2010 at 6:26 PM, Doug Hughes wrote:
> I honestly haven't been watching.... so I'm no authority.

Ja, I was thinking of the filters and whatnot Mark has been slipping in there.

It's been low-key. No worries. =)

:den

--
Darwin's idea of natural selection makes people uncomfortable because
it reverses the direction of tradition.
Daniel Dennett

[Sami Hoda]

I will collect our hacks and send them over. What email should I use
Mark?

[Mark Drew]

use mark...@gmail.com

As long as it gets to me...

MD

> --
> You received this message because you are subscribed to the Google
> Groups "Reactor" group.
> To post to this group, send email to reacto...@googlegroups.com.
> To unsubscribe from this group, send email to reactor-user...@googlegroups.com
> .
> For more options, visit this group at http://groups.google.com/group/reactor-users?hl=en
> .
>
>

Mark Drew

[Tom Chiverton]

On Monday 04 Jan 2010, Sami Hoda wrote:
> For MSSQL - support for schemas. So, if a table is named

Was there a bug with your 'local hack' attached as patch ?
If you've already sent these to Mark, ace.

> For MSSQL - ignore replication column. When doing replication on MSSQL

Ditto.

> And I think there may be one other thing I'm forgetting, but this is
> enough to get the conversation started.

Recently the pattern is that Mark is deploying new features (like filters),
while I'm tweaking and bug fixing.

Reactor is not dead, and we do want to address any 'long standing' unfixed
issues any one has with it.

--

Tom Chiverton
Developer

Tom.Ch...@halliwells.com
3 Hardman Square, Manchester, M3 3EB

****************************************************

This email is sent for and on behalf of Halliwells LLP.

Halliwells LLP is a limited liability partnership registered in England and Wales under registered number OC307980 whose registered office address is at Halliwells LLP, 3 Hardman Square, Spinningfields, Manchester, M3 3EB. A list of members is available for inspection at the registered office together with a list of those non members who are referred to as partners. We use the word “partner” to refer to a member of the LLP, or an employee or consultant with equivalent standing and qualifications. Regulated by the Solicitors Regulation Authority.

CONFIDENTIALITY

This email is intended only for the use of the addressee named above and may be confidential or legally privileged. If you are not the addressee you must not read it and must not use any information contained in nor copy it nor inform any person other than Halliwells LLP or the addressee of its existence or contents. If you have received this email in error please delete it and notify Halliwells LLP IT Department on 0870 365 2500.

For more information about Halliwells LLP visit www.Halliwells.com.

[Tom Chiverton]

On Jan 4, 8:07 pm, Sami Hoda <s...@bytestopshere.com> wrote:
> For MSSQL - support for schemas. So, if a table is named

This is now committed.

> For MSSQL - ignore replication column. When doing replication on MSSQL
> between two servers in MSSQL, MSSQL creates a column called "rowGUID"
> on each table. Reactor tries to mess with this column, when it should
> be ignoring it all together.

Looking at the code we have at the moment, Reactor should be marking
such columns as read only - are you saying Reactor trys to update the
column anyway ? If so, how do you trigger this ?

As a wider question to those who use MS-SQL, would always making these
column types vanish pose a problem ?

[Tom Chiverton]

On Jan 4, 8:07 pm, Sami Hoda <s...@bytestopshere.com> wrote:

> For MSSQL - support for schemas. So, if a table is named
> dbo.tableName, Reactor works fine. But if we have schemaName.tableName
> (no more dbo!), Reactor freaks out. It always assumes you are using
> very basic MSSQL tables.

This should now be fixed.

> For MSSQL - ignore replication column. When doing replication on MSSQL
> between two servers in MSSQL, MSSQL creates a column called "rowGUID"
> on each table. Reactor tries to mess with this column, when it should
> be ignoring it all together.

I don't have a MSSQL server to test with, but the code should be
marking this column read only (so at least you can see the values in
it).
Are you saying Reactor trys to update this column value in some cases,
if so, which cases ?
That's probably a bug - we shouldn't be altering read only columns.

I see the patch removes all columns of this 'rowGUID' type which while
it works may be overkill.
Could people who actually use MSSQL comment on this a bit ? Would
vanishing all 'rowGUID' columns cause problems ?

[Sami Hoda]

Yes, Reactor still tries to mess with the rowGUID column. For new
records for example, it tries to insert a GUID, when it should ignore
the column altogether. The column should not be read (why waste
time?), nor written to. Completely ignored all together.

If you still have questions, why not a Reactor config that either
hides (default) or can expose these columns?

[Sami Hoda]

Tom,

IMHO, rowGUID is for replication only, and you can consider it like
any system table, you don't mess with it.

Sami

[Tom Chiverton]

On Saturday 16 Jan 2010, Sami Hoda wrote:
> If you still have questions, why not a Reactor config that either
> hides (default) or can expose these columns?

Oddly enough, we added just that feature a few months back :-)
http://trac.reactorframework.com/wiki/howDoIIgnoreColumns

Does that cover your use case OK ?

--

Tom Chiverton
Developer

Tom.Ch...@halliwells.com
3 Hardman Square, Manchester, M3 3EB

****************************************************

This email is sent for and on behalf of Halliwells LLP.

Halliwells LLP is a limited liability partnership registered in England and Wales under registered number OC307980 whose registered office address is at Halliwells LLP, 3 Hardman Square, Spinningfields, Manchester, M3 3EB. A list of members is available for inspection at the registered office together with a list of those non members who are referred to as partners. We use the word ?partner? to refer to a member of the LLP, or an employee or consultant with equivalent standing and qualifications. Regulated by the Solicitors Regulation Authority.

CONFIDENTIALITY

This email is intended only for the use of the addressee named above and may be confidential or legally privileged. If you are not the addressee you must not read it and must not use any information contained in nor copy it nor inform any person other than Halliwells LLP or the addressee of its existence or contents. If you have received this email in error please delete it and notify Halliwells LLP IT Department on 0870 365 2500.

For more information about Halliwells LLP visit

www.Halliwells.com.

[Tom Chiverton]

On Saturday 16 Jan 2010, Sami Hoda wrote:

> Yes, Reactor still tries to mess with the rowGUID column. For new
> records for example, it tries to insert a GUID,

That's still not correct for a read only column, rowGUID or not....

Could you try a current build of Reactor ?

--

Tom Chiverton, why reply once when twice will do ?

[Sami Hoda]

It doesn't because there is no global option for this feature - meaning, I would have to ignore for every table...
Sami

[Sami Hoda]

I will try and report back soon.

Sami

[Sami Hoda]

Juts one problem- dev env does not have replication. I will need to manually add a column called rowguid to see what it does.
Sami

[Tom Chiverton]

On Monday 18 Jan 2010, Sami Hoda wrote:
> It doesn't because there is no global option for this feature - meaning, I
> would have to ignore for every table...

Aye, you would. Even if you have a lot of tables, it's just a simple
search/replace in your Reactor config.

I could probably put a 3rd level option in that would go at the same level as
username/password though.
I've entered this into Trac as issue #205.

[Tom Chiverton]

On Monday 18 Jan 2010, Sami Hoda wrote:
> Juts one problem- dev env does not have replication. I will need to
> manually add a column called rowguid to see what it does.

Simply having the same name is probably not enough, it needs to have the same
type.

--

Tom Chiverton
Developer

Tom.Ch...@halliwells.com
3 Hardman Square, Manchester, M3 3EB

[Sami Hoda]

Yup, those are the challenges. I'll see what I can figure out. DId you get any other feedback?
Sami

[Tom Chiverton]

On Tuesday 19 Jan 2010, Sami Hoda wrote:
> Yup, those are the challenges. I'll see what I can figure out. DId you get
> any other feedback?

Not as yet.