Update of field ignore support

[Tom Chiverton]

We've bumped into http://trac.reactorframework.org/ticket/191 again,
and so I tool a look at Mark's original work on support for ignoring
fields.
I had to rewrite the portion that looped over the table XML
description removing ignored fields so that it worked with more than
one ignored field.

We'll be doing more testing over the next few days, but I think the
patch is worthy of being committed now.

Thoughts ?

--
Tom

[Mark Drew]

WE can check it into the trunk and then its a bleeding edge.

Great work Tom!

MD

Mark Drew
CEO
Railo Technologies UK
mark...@getrailo.com
http://www.getrailo.com

[Tom Chiverton]

2009/4/16 Mark Drew <mark...@gmail.com>:

> WE can check it into the trunk and then its a bleeding edge.
> Great work Tom!

On a related note, what do people feel about adding a new property to
object, like

<object ignoreUndeclaredFields="true" .....

This would make Reactor remove any fields that did not have a
corresponding <field> tag.

it would default to 'false' makeing the behaviour as now (any columns
that don't have a <field> are still used).

--
Tom

[Tom Chiverton]

2009/4/16 Tom Chiverton <tom.ch...@gmail.com>:
> <object ignoreUndeclaredFields="true" .....
...

> it would default to 'false' makeing the behaviour as now (any columns
> that don't have a <field> are still used).

I've uploaded a second patch to #191 that adds this feature.

--
Tom

[Mark Drew]

Awesome work!

Now I guess we need to start documenting these features. kinda like
the tag level documentation that MG does

Wiki?

MD

[Tom Chiverton]

2009/4/17 Mark Drew <mark...@gmail.com>:
> Wiki?

On it.

--
Tom

[Tom Chiverton]

2009/4/17 Mark Drew <mark...@gmail.com>:

> Now I guess we need to start documenting these features. kinda like
> the tag level documentation that MG does

http://trac.reactorframework.org/wiki/howDoIIgnoreColumns :-)

Did you complete testing the patches yourself yet ? I had another
developer here test it and it seems to work OK (and critically
produces the same code if you don't ignore any fields or change the
default on object).

--
Tom

[Mark Drew]

I havent had a chance mate, I have added it to my todo list for this
weekend

MD