string conversion issues

[Tim Hutton]

So I've just pushed a fix for issue #38 in Ready. Turns out that it was caused by us doing this:

wxString filename;

// ...

const char* filename_cstr = filename.mb_str(); This is wrong and should never be done, according to: https://wiki.wxwidgets.org/WxString#Converting_a_wxString_to_a_Normal_String And indeed changing it has made the bug disappear.

We have quite a lot of bits in the code where we do this, e.g.:

const char* filename_cstr = filename.mb_str();
if (strlen(filename_cstr) == 0)
{
    wxMessageBox(_("Unsupported characters in path"), _("Error"), wxOK | wxCENTER | wxICON_ERROR);
    return;
}

I'll change these as I see them but I know that we've struggled with string conversion in the past and I'm wary of breaking things.

Tim

--

Tim Hutton - http://www.sq3.org.uk - https://twitter.com/_tim_hutton_ - https://github.com/timhutton