[XS] Change in code/re2[main]: fix typo in re2/nfa.cc

26 views
Skip to first unread message

redpanda (Gerrit)

unread,
Jun 5, 2024, 4:41:20 AMJun 5
to re2...@googlegroups.com

redpanda has uploaded the change for review

Commit message

fix typo in re2/nfa.cc
Change-Id: I0f2bbb0d26f7becdf8677408b2162cd243d8e56e

Change information

Files:
  • M re2/nfa.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I0f2bbb0d26f7becdf8677408b2162cd243d8e56e
Gerrit-Change-Number: 63190
Gerrit-PatchSet: 1
Gerrit-Owner: redpanda <panda...@gmail.com>
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
Jun 5, 2024, 6:10:13 AMJun 5
to redpanda, Paul Wankadia, re2...@googlegroups.com
Attention needed from redpanda

Paul Wankadia added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Paul Wankadia . resolved

You are [`@redpanda83`](https://github.com/redpanda83) on GitHub, I gather, but are you also [`@totoro642`](https://github.com/totoro642) on GitHub? I ask because [this](https://github.com/google/maxtext/pull/686) PR is arguably innocuous, but [this](https://github.com/google/re2/pull/497) PR and [this](https://github.com/google/re2/pull/498) PR are extremely dubious. The timing might just be a coincidence, but the thing is that it might ***not*** just be a coincidence. I guess I will never know. :)

Open in Gerrit

Related details

Attention is currently required from:
  • redpanda
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I0f2bbb0d26f7becdf8677408b2162cd243d8e56e
Gerrit-Change-Number: 63190
Gerrit-PatchSet: 1
Gerrit-Owner: redpanda <panda...@gmail.com>
Gerrit-CC: Paul Wankadia <jun...@google.com>
Gerrit-Attention: redpanda <panda...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Jun 2024 10:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
Jun 5, 2024, 6:10:18 AMJun 5
to redpanda, Paul Wankadia, re2...@googlegroups.com

Paul Wankadia abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
unsatisfied_requirement
open
diffy

redpanda (Gerrit)

unread,
Jun 5, 2024, 6:24:09 AMJun 5
to Paul Wankadia, re2...@googlegroups.com

redpanda added 1 comment

Patchset-level comments
Paul Wankadia . resolved

You are [`@redpanda83`](https://github.com/redpanda83) on GitHub, I gather, but are you also [`@totoro642`](https://github.com/totoro642) on GitHub? I ask because [this](https://github.com/google/maxtext/pull/686) PR is arguably innocuous, but [this](https://github.com/google/re2/pull/497) PR and [this](https://github.com/google/re2/pull/498) PR are extremely dubious. The timing might just be a coincidence, but the thing is that it might ***not*** just be a coincidence. I guess I will never know. :)

redpanda

Sorry I have no idea what you're talking about. I was just trying to contribute a bit and learning re2 internals. It's the first time I even use gerrit.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I0f2bbb0d26f7becdf8677408b2162cd243d8e56e
Gerrit-Change-Number: 63190
Gerrit-PatchSet: 1
Gerrit-Owner: redpanda <panda...@gmail.com>
Gerrit-CC: Paul Wankadia <jun...@google.com>
Gerrit-Comment-Date: Wed, 05 Jun 2024 10:24:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Wankadia <jun...@google.com>
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
Jun 5, 2024, 5:00:58 PMJun 5
to redpanda, Paul Wankadia, re2...@googlegroups.com

Paul Wankadia added 1 comment

Patchset-level comments
Paul Wankadia . resolved

You are [`@redpanda83`](https://github.com/redpanda83) on GitHub, I gather, but are you also [`@totoro642`](https://github.com/totoro642) on GitHub? I ask because [this](https://github.com/google/maxtext/pull/686) PR is arguably innocuous, but [this](https://github.com/google/re2/pull/497) PR and [this](https://github.com/google/re2/pull/498) PR are extremely dubious. The timing might just be a coincidence, but the thing is that it might ***not*** just be a coincidence. I guess I will never know. :)

redpanda

Sorry I have no idea what you're talking about. I was just trying to contribute a bit and learning re2 internals. It's the first time I even use gerrit.

Paul Wankadia

Oh, okay then. So I suppose it might also just be a coincidence that `@totoro642` set their GitHub profile to private sometime after I pointed out their suspicious activity. ;)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I0f2bbb0d26f7becdf8677408b2162cd243d8e56e
Gerrit-Change-Number: 63190
Gerrit-PatchSet: 1
Gerrit-Owner: redpanda <panda...@gmail.com>
Gerrit-CC: Paul Wankadia <jun...@google.com>
Gerrit-Comment-Date: Wed, 05 Jun 2024 21:00:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: redpanda <panda...@gmail.com>
Comment-In-Reply-To: Paul Wankadia <jun...@google.com>
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages