[S] Change in code/re2[main]: re2: use std::optional instead of absl::optional

1 view

Skip to first unread message

Russ Cox (Gerrit)

unread,

Jul 30, 2025, 11:28:18 AM7/30/25

to Alan Donovan, re2...@googlegroups.com

Attention needed from Alan Donovan

Russ Cox has uploaded the change for review

Russ Cox would like Alan Donovan to review this change.

Commit message

re2: use std::optional instead of absl::optional

std::optional is now preferred over absl::optional, even at Google.
It was introduced in C++17.

Change-Id: If02413a46299beef521effaad265ca04f43088fa

Change information

Files:

M re2/re2.h
M re2/testing/re2_arg_test.cc

Change size: S

Delta: 2 files changed, 12 insertions(+), 12 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Alan Donovan

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Alan Donovan (Gerrit)

unread,

Jul 30, 2025, 11:36:03 AM7/30/25

to Russ Cox, re2...@googlegroups.com

Attention needed from Russ Cox

Alan Donovan voted Code-Review+2

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Russ Cox

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Russ Cox (Gerrit)

unread,

Jul 30, 2025, 12:29:03 PM7/30/25

to Alan Donovan, re2...@googlegroups.com

Russ Cox submitted the change

Change information

Commit message:

re2: use std::optional instead of absl::optional

std::optional is now preferred over absl::optional, even at Google.
It was introduced in C++17.

Change-Id: If02413a46299beef521effaad265ca04f43088fa

Reviewed-on: https://code-review.googlesource.com/c/re2/+/63771

Reviewed-by: Alan Donovan <adon...@google.com>

Files:

M re2/re2.h
M re2/testing/re2_arg_test.cc

Change size: S

Delta: 2 files changed, 12 insertions(+), 12 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Alan Donovan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages