[L] Change in code/re2[main]: Switch to Abseil logging.

3 views
Skip to first unread message

Paul Wankadia (Gerrit)

unread,
May 17, 2024, 3:13:31 PMMay 17
to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded the change for review

Commit message

Switch to Abseil logging.

Fixes #494.
Change-Id: Ie8bd23d44a6f2609b72f115c3b2344a2a91637be

Change information

Files:
  • M BUILD.bazel
  • M CMakeLists.txt
  • M Makefile
  • M re2/bitmap256.cc
  • M re2/bitmap256.h
  • M re2/bitstate.cc
  • M re2/compile.cc
  • M re2/dfa.cc
  • M re2/filtered_re2.cc
  • M re2/mimics_pcre.cc
  • M re2/nfa.cc
  • M re2/onepass.cc
  • M re2/parse.cc
  • M re2/prefilter.cc
  • M re2/prefilter.h
  • M re2/prefilter_tree.cc
  • M re2/prefilter_tree.h
  • M re2/prog.cc
  • M re2/prog.h
  • M re2/re2.cc
  • M re2/regexp.cc
  • M re2/regexp.h
  • M re2/set.cc
  • M re2/simplify.cc
  • M re2/testing/backtrack.cc
  • M re2/testing/compile_test.cc
  • M re2/testing/dfa_test.cc
  • M re2/testing/dump.cc
  • M re2/testing/exhaustive_tester.cc
  • M re2/testing/filtered_re2_test.cc
  • M re2/testing/mimics_pcre_test.cc
  • M re2/testing/null_walker.cc
  • M re2/testing/parse_test.cc
  • M re2/testing/possible_match_test.cc
  • M re2/testing/re2_arg_test.cc
  • M re2/testing/re2_test.cc
  • M re2/testing/regexp_benchmark.cc
  • M re2/testing/regexp_generator.cc
  • M re2/testing/regexp_test.cc
  • M re2/testing/required_prefix_test.cc
  • M re2/testing/set_test.cc
  • M re2/testing/simplify_test.cc
  • M re2/testing/string_generator.cc
  • M re2/testing/tester.cc
  • M re2/tostring.cc
  • M re2/walker-inl.h
  • D util/logging.h
  • M util/pcre.cc
Change size: L
Delta: 48 files changed, 96 insertions(+), 156 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Ie8bd23d44a6f2609b72f115c3b2344a2a91637be
Gerrit-Change-Number: 63091
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
May 17, 2024, 3:22:14 PMMay 17
to Paul Wankadia, re2...@googlegroups.com
Attention needed from Alex Chernyakhovsky

Paul Wankadia uploaded new patchset

Paul Wankadia uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Chernyakhovsky
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Ie8bd23d44a6f2609b72f115c3b2344a2a91637be
Gerrit-Change-Number: 63091
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Wankadia <jun...@google.com>
Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
Gerrit-CC: Perry Lorier <per...@google.com>
Gerrit-Attention: Alex Chernyakhovsky <ache...@google.com>
unsatisfied_requirement
open
diffy

Alex Chernyakhovsky (Gerrit)

unread,
May 17, 2024, 4:50:42 PMMay 17
to Paul Wankadia, Perry Lorier, re2...@googlegroups.com
Attention needed from Paul Wankadia

Alex Chernyakhovsky voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Wankadia
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie8bd23d44a6f2609b72f115c3b2344a2a91637be
    Gerrit-Change-Number: 63091
    Gerrit-PatchSet: 2
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Attention: Paul Wankadia <jun...@google.com>
    Gerrit-Comment-Date: Fri, 17 May 2024 20:50:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    May 17, 2024, 4:56:06 PMMay 17
    to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie8bd23d44a6f2609b72f115c3b2344a2a91637be
    Gerrit-Change-Number: 63091
    Gerrit-PatchSet: 2
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Comment-Date: Fri, 17 May 2024 20:56:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    May 17, 2024, 4:56:09 PMMay 17
    to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia submitted the change

    Change information

    Commit message:
    Switch to Abseil logging.

    Fixes #494.
    Change-Id: Ie8bd23d44a6f2609b72f115c3b2344a2a91637be
    Reviewed-by: Alex Chernyakhovsky <ache...@google.com>
    Reviewed-by: Paul Wankadia <jun...@google.com>
    Delta: 48 files changed, 122 insertions(+), 156 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Alex Chernyakhovsky, +2 by Paul Wankadia
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie8bd23d44a6f2609b72f115c3b2344a2a91637be
    Gerrit-Change-Number: 63091
    Gerrit-PatchSet: 3
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages