[S] Change in code/re2[main]: .bcr: fix windows command-line flags
2 views
Skip to first unread message
Russ Cox (Gerrit)
Aug 13, 2025, 11:57:35 AMAug 13
to Jeremy Kun, re2...@googlegroups.com
Attention needed from Jeremy Kun
Russ Cox has uploaded the change for review![]( "Open in Gerrit")
Russ Cox would like Jeremy Kun to review this change.
Commit message
.bcr: fix windows command-line flags
Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5
Change information
Files:
- M .bcr/presubmit.yml
Change size: S
Delta: 1 file changed, 25 insertions(+), 3 deletions(-)
Related details
Attention is currently required from:
- Jeremy Kun
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Kun (Gerrit)
Aug 13, 2025, 12:03:21 PMAug 13
to Russ Cox, re2...@googlegroups.com
Attention needed from Russ Cox
Jeremy Kun voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jeremy Kun
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jeremy Kun . resolved
It's interesting because somehow this test_matrix was working on the BCR before this. https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/re2/2025-06-26/presubmit.yml
Perhaps the windows build changed in the last few months?
Related details
Attention is currently required from:
- Russ Cox
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
Sep 29, 2025, 10:14:49 AM (4 days ago) Sep 29
to Alan Donovan, Jeremy Kun, re2...@googlegroups.com
Attention needed from Alan Donovan and Jeremy Kun
Russ Cox added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jeremy Kun . resolved
It's interesting because somehow this test_matrix was working on the BCR before this. https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/re2/2025-06-26/presubmit.yml
Perhaps the windows build changed in the last few months?
Attention is currently required from:
- Alan Donovan
- Jeremy Kun
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
Sep 29, 2025, 10:46:38 AM (4 days ago) Sep 29
to Russ Cox, Jeremy Kun, re2...@googlegroups.com
Attention needed from Jeremy Kun and Russ Cox
Alan Donovan voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Jeremy Kun
- Russ Cox
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
Sep 29, 2025, 11:57:50 AM (4 days ago) Sep 29
to Alan Donovan, Jeremy Kun, re2...@googlegroups.com
Russ Cox submitted the change![]( "Open in Gerrit")
Change information
Commit message:
.bcr: fix windows command-line flags
Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5
Reviewed-on: https://code-review.googlesource.com/c/re2/+/63990
Reviewed-by: Jeremy Kun <jk...@google.com>
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
- M .bcr/presubmit.yml
Change size: S
Delta: 1 file changed, 25 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Alan Donovan, +1 by Jeremy Kun
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages