[S] Change in code/re2[main]: .bcr: fix windows command-line flags

2 views
Skip to first unread message

Russ Cox (Gerrit)

unread,
Aug 13, 2025, 11:57:35 AMAug 13
to Jeremy Kun, re2...@googlegroups.com
Attention needed from Jeremy Kun

Russ Cox has uploaded the change for review

Russ Cox would like Jeremy Kun to review this change.

Commit message

.bcr: fix windows command-line flags
Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5

Change information

Files:
  • M .bcr/presubmit.yml
Change size: S
Delta: 1 file changed, 25 insertions(+), 3 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Jeremy Kun
Submit Requirements:
  • requirement is blockingCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5
Gerrit-Change-Number: 63990
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Jeremy Kun <jk...@google.com>
Gerrit-Attention: Jeremy Kun <jk...@google.com>
blocking_requirement
unsatisfied_requirement
open
diffy

Jeremy Kun (Gerrit)

unread,
Aug 13, 2025, 12:03:21 PMAug 13
to Russ Cox, re2...@googlegroups.com
Attention needed from Russ Cox

Jeremy Kun voted and added 1 comment

Votes added by Jeremy Kun

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jeremy Kun . resolved

It's interesting because somehow this test_matrix was working on the BCR before this. https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/re2/2025-06-26/presubmit.yml

Perhaps the windows build changed in the last few months?

Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5
Gerrit-Change-Number: 63990
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Jeremy Kun <jk...@google.com>
Gerrit-Attention: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Wed, 13 Aug 2025 16:03:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Sep 29, 2025, 10:14:49 AMSep 29
to Alan Donovan, Jeremy Kun, re2...@googlegroups.com
Attention needed from Alan Donovan and Jeremy Kun

Russ Cox added 1 comment

Patchset-level comments
Jeremy Kun . resolved

It's interesting because somehow this test_matrix was working on the BCR before this. https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/re2/2025-06-26/presubmit.yml

Perhaps the windows build changed in the last few months?

Russ Cox

What changed is RE2 updated to requiring C++17.

Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Jeremy Kun
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5
Gerrit-Change-Number: 63990
Gerrit-PatchSet: 2
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Jeremy Kun <jk...@google.com>
Gerrit-Attention: Jeremy Kun <jk...@google.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 14:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jeremy Kun <jk...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
Sep 29, 2025, 10:46:38 AMSep 29
to Russ Cox, Jeremy Kun, re2...@googlegroups.com
Attention needed from Jeremy Kun and Russ Cox

Alan Donovan voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jeremy Kun
  • Russ Cox
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5
Gerrit-Change-Number: 63990
Gerrit-PatchSet: 2
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Jeremy Kun <jk...@google.com>
Gerrit-Attention: Jeremy Kun <jk...@google.com>
Gerrit-Attention: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 14:46:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Sep 29, 2025, 11:57:50 AMSep 29
to Alan Donovan, Jeremy Kun, re2...@googlegroups.com

Russ Cox submitted the change

Change information

Commit message:
.bcr: fix windows command-line flags
Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5
Reviewed-by: Jeremy Kun <jk...@google.com>
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
  • M .bcr/presubmit.yml
Change size: S
Delta: 1 file changed, 25 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Alan Donovan, +1 by Jeremy Kun
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5
Gerrit-Change-Number: 63990
Gerrit-PatchSet: 3
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Jeremy Kun <jk...@google.com>
Gerrit-Reviewer: Russ Cox <r...@swtch.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages