[S] Change in code/re2[main]: .bcr: fix windows command-line flags

2 views

Skip to first unread message

Russ Cox (Gerrit)

unread,

Aug 13, 2025, 11:57:35 AMAug 13

to Jeremy Kun, re2...@googlegroups.com

Attention needed from Jeremy Kun

Russ Cox has uploaded the change for review

Russ Cox would like Jeremy Kun to review this change.

Commit message

.bcr: fix windows command-line flags

Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5

Change information

Files:

M .bcr/presubmit.yml

Change size: S

Delta: 1 file changed, 25 insertions(+), 3 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Jeremy Kun

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

blocking_requirement

unsatisfied_requirement

open

diffy

Jeremy Kun (Gerrit)

unread,

Aug 13, 2025, 12:03:21 PMAug 13

to Russ Cox, re2...@googlegroups.com

Attention needed from Russ Cox

Jeremy Kun voted and added 1 comment

Votes added by Jeremy Kun

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jeremy Kun . resolved

It's interesting because somehow this test_matrix was working on the BCR before this. https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/re2/2025-06-26/presubmit.yml

Perhaps the windows build changed in the last few months?

Open in Gerrit

Related details

Attention is currently required from:

Russ Cox

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages