[S] Change in code/re2[main]: Make benchmark building optional in cmake

12 views
Skip to first unread message

Azamat Hackimov (Gerrit)

unread,
Jan 14, 2025, 4:14:20 AMJan 14
to re2...@googlegroups.com

Azamat Hackimov has uploaded the change for review

Commit message

Make benchmark building optional in cmake

Some Linux distributions only requires testing but not benchmarking.
Make benchmark optional to exclude excessive dependency on building tests.
Change-Id: I1ce8bd1b4f6132efb295f71d43a77ba36ea58dc5
Signed-off-by: Azamat H. Hackimov <azamat....@gmail.com>

Change information

Files:
  • M CMakeLists.txt
Change size: S
Delta: 1 file changed, 17 insertions(+), 10 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I1ce8bd1b4f6132efb295f71d43a77ba36ea58dc5
Gerrit-Change-Number: 63530
Gerrit-PatchSet: 1
Gerrit-Owner: Azamat Hackimov <azamat....@gmail.com>
unsatisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 11, 2025, 11:48:05 AMAug 11
to Azamat Hackimov, bm bm, re2...@googlegroups.com

Russ Cox abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement is blockingCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I1ce8bd1b4f6132efb295f71d43a77ba36ea58dc5
Gerrit-Change-Number: 63530
Gerrit-PatchSet: 1
Gerrit-Owner: Azamat Hackimov <azamat....@gmail.com>
Gerrit-CC: Russ Cox <r...@swtch.com>
Gerrit-CC: bm bm <bmb2...@gmail.com>
blocking_requirement
unsatisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 11, 2025, 11:48:05 AMAug 11
to Azamat Hackimov, bm bm, re2...@googlegroups.com
Attention needed from Azamat Hackimov

Russ Cox added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Russ Cox . resolved

This has been taken care of. Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Azamat Hackimov
Submit Requirements:
  • requirement is blockingCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I1ce8bd1b4f6132efb295f71d43a77ba36ea58dc5
Gerrit-Change-Number: 63530
Gerrit-PatchSet: 1
Gerrit-Owner: Azamat Hackimov <azamat....@gmail.com>
Gerrit-CC: Russ Cox <r...@swtch.com>
Gerrit-CC: bm bm <bmb2...@gmail.com>
Gerrit-Attention: Azamat Hackimov <azamat....@gmail.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 15:47:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
blocking_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages