[S] Change in code/re2[main]: re2: use C++17 [[fallthrough]] instead of ABSL_FALLTHROUGH_INTENDED

1 view

Skip to first unread message

Russ Cox (Gerrit)

unread,

Jul 30, 2025, 11:28:18 AMJul 30

to Alan Donovan, re2...@googlegroups.com

Attention needed from Alan Donovan

Russ Cox has uploaded the change for review

Russ Cox would like Alan Donovan to review this change.

Commit message

re2: use C++17 [[fallthrough]] instead of ABSL_FALLTHROUGH_INTENDED

According to [1], Google code now depends on C++17,
so we can use these directly.

[1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md

Change-Id: Ic475b79bc2153861d6ec2aebc0c55dbcf0c35908

Change information

Files:

M re2/bitmap256.cc
M re2/dfa.cc
M re2/parse.cc
M re2/prog.cc
M re2/walker-inl.h

Change size: S

Delta: 5 files changed, 9 insertions(+), 13 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Alan Donovan

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Alan Donovan (Gerrit)

unread,

Jul 30, 2025, 11:35:36 AMJul 30

to Russ Cox, re2...@googlegroups.com

Attention needed from Russ Cox

Alan Donovan voted Code-Review+2

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Russ Cox

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Russ Cox (Gerrit)

unread,

Jul 30, 2025, 12:29:01 PMJul 30

to Alan Donovan, re2...@googlegroups.com

Russ Cox submitted the change

Change information

Commit message:

re2: use C++17 [[fallthrough]] instead of ABSL_FALLTHROUGH_INTENDED

According to [1], Google code now depends on C++17,
so we can use these directly.

[1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md

Change-Id: Ic475b79bc2153861d6ec2aebc0c55dbcf0c35908

Reviewed-on: https://code-review.googlesource.com/c/re2/+/63770

Reviewed-by: Alan Donovan <adon...@google.com>

Files:

M re2/bitmap256.cc
M re2/dfa.cc
M re2/parse.cc
M re2/prog.cc
M re2/walker-inl.h

Change size: S

Delta: 5 files changed, 9 insertions(+), 13 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Alan Donovan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages