Building with VS 2010 and va_copy

[Nick Westgate]

Hi guys.

Thanks a lot for the Windows port of RE2. It's awesome!

The Windows port builds great except that va_copy is only implemented in Visual Studio 2013 onwards, and I have to use 2010. (Yeah, I know.)

In notice this in util.h:

#ifdef _WIN32

This might be a good place to add the following small change which would allow building on earlier versions.

// va_copy was not implemented before VS 2013

#if !defined(va_copy)

#define va_copy(dest, src) ((dest) = (src))

#endif

Cheers,

Nick.

[Nick Westgate]

Ah, I see you use atomics and explicitly require VS 2013. Sigh.

Never mind then.

Cheers,

Nick.

[Paul Wankadia]

On Fri, Feb 26, 2016 at 4:01 PM, Nick Westgate <nick.w...@gmail.com> wrote:

Ah, I see you use atomics and explicitly require VS 2013. Sigh.

Sorry, yes, that was a fairly recent change – the "legacy" atomics were beyond redemption. Visual Studio 2012 might possibly have been able to sneak in with the va_copy hack that you mentioned, but not Visual Studio 2010, I believe.

[Nick Westgate]

It would be nice if the CMake build would complain about the compiler version then:

http://stackoverflow.com/questions/14933172/how-can-i-add-a-minimum-compiler-version-requisite

Cheers,

Nick.

[Paul Wankadia]

On Mon, Feb 29, 2016 at 8:01 AM, Nick Westgate <nick.w...@gmail.com> wrote:

It would be nice if the CMake build would complain about the compiler version then:

http://stackoverflow.com/questions/14933172/how-can-i-add-a-minimum-compiler-version-requisite

Done in https://github.com/google/re2/commit/d36f207ec3663340c3111627d13d3359b73b9208. Thanks for the suggestion!