[XS] Change in code/re2[main]: Work around a bug in CMake that breaks `^` anchors.

0 views
Skip to first unread message

Paul Wankadia (Gerrit)

unread,
May 20, 2024, 9:51:22 AMMay 20
to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded the change for review

Commit message

Work around a bug in CMake that breaks `^` anchors.

https://gitlab.kitware.com/cmake/cmake/-/issues/16899 was reported
seven years ago. The bug existed at least ten years ago. It hasn't
been fixed.
Change-Id: Ifbe3e77ce6371091b24303d5c4953d401ed29826

Change information

Files:
  • M CMakeLists.txt
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Ifbe3e77ce6371091b24303d5c4953d401ed29826
Gerrit-Change-Number: 63071
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
unsatisfied_requirement
open
diffy

Alex Chernyakhovsky (Gerrit)

unread,
May 20, 2024, 9:55:00 AMMay 20
to Paul Wankadia, Perry Lorier, re2...@googlegroups.com
Attention needed from Paul Wankadia

Alex Chernyakhovsky voted and added 1 comment

Votes added by Alex Chernyakhovsky

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alex Chernyakhovsky . resolved

I lovehate this fix.

Open in Gerrit

Related details

Attention is currently required from:
  • Paul Wankadia
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifbe3e77ce6371091b24303d5c4953d401ed29826
    Gerrit-Change-Number: 63071
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Attention: Paul Wankadia <jun...@google.com>
    Gerrit-Comment-Date: Mon, 20 May 2024 13:54:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    May 20, 2024, 9:56:48 AMMay 20
    to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifbe3e77ce6371091b24303d5c4953d401ed29826
    Gerrit-Change-Number: 63071
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Comment-Date: Mon, 20 May 2024 13:56:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    May 20, 2024, 9:56:50 AMMay 20
    to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia submitted the change

    Change information

    Commit message:
    Work around a bug in CMake that breaks `^` anchors.

    https://gitlab.kitware.com/cmake/cmake/-/issues/16899 was reported
    seven years ago. The bug existed at least ten years ago. It hasn't
    been fixed.
    Change-Id: Ifbe3e77ce6371091b24303d5c4953d401ed29826
    Reviewed-by: Alex Chernyakhovsky <ache...@google.com>
    Reviewed-by: Paul Wankadia <jun...@google.com>
    Files:
    • M CMakeLists.txt
    Change size: XS
    Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Paul Wankadia, +1 by Alex Chernyakhovsky
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifbe3e77ce6371091b24303d5c4953d401ed29826
    Gerrit-Change-Number: 63071
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages