[S] Change in code/re2[main]: .bazelrc: ask for C++17 now

3 views
Skip to first unread message

Russ Cox (Gerrit)

unread,
Jul 30, 2025, 2:54:27 PMJul 30
to Alan Donovan, re2...@googlegroups.com
Attention needed from Alan Donovan

Russ Cox has uploaded the change for review

Russ Cox would like Alan Donovan to review this change.

Commit message

.bazelrc: ask for C++17 now

Also update README.md to explain to users (and future me).

Also update ci-bazel.yml to drop Python 3.8 and add 3.13.
(Missed this file when updating python.yml.)
Change-Id: Idbad8d392b88c5c38a59d5e0e2a1b5ff438990e6

Change information

Files:
  • M .bazelrc
  • M .github/workflows/ci-bazel.yml
  • M README.md
Change size: S
Delta: 3 files changed, 8 insertions(+), 7 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Idbad8d392b88c5c38a59d5e0e2a1b5ff438990e6
Gerrit-Change-Number: 63792
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
unsatisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
Jul 30, 2025, 3:30:01 PMJul 30
to Russ Cox, re2...@googlegroups.com
Attention needed from Russ Cox

Alan Donovan voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Idbad8d392b88c5c38a59d5e0e2a1b5ff438990e6
Gerrit-Change-Number: 63792
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Attention: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Wed, 30 Jul 2025 19:29:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Jul 30, 2025, 8:46:49 PMJul 30
to Alan Donovan, re2...@googlegroups.com

Russ Cox submitted the change

Change information

Commit message:
.bazelrc: ask for C++17 now

Also update README.md to explain to users (and future me).

Also update ci-bazel.yml to drop Python 3.8 and add 3.13.
(Missed this file when updating python.yml.)
Change-Id: Idbad8d392b88c5c38a59d5e0e2a1b5ff438990e6
Files:
  • M .bazelrc
  • M .github/workflows/ci-bazel.yml
  • M README.md
Change size: S
Delta: 3 files changed, 8 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Alan Donovan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Idbad8d392b88c5c38a59d5e0e2a1b5ff438990e6
Gerrit-Change-Number: 63792
Gerrit-PatchSet: 2
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Russ Cox <r...@swtch.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages