[XS] Change in code/re2[main]: .github/workflows: only release on 2xxx-xx-xx tags

1 view
Skip to first unread message

Russ Cox (Gerrit)

unread,
Aug 4, 2025, 5:53:39 PMAug 4
to Alan Donovan, re2...@googlegroups.com
Attention needed from Alan Donovan

Russ Cox has uploaded the change for review

Russ Cox would like Alan Donovan to review this change.

Commit message

.github/workflows: only release on 2xxx-xx-xx tags

I will add an 'abseil.old' tag preserving the Abseil branch history.
This avoids having that tag trigger a release action.
Change-Id: I3d44ff9d91bf205bd5425adcb4b1da044a531661

Change information

Files:
  • M .github/workflows/release.yml
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
Submit Requirements:
  • requirement is blockingCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3d44ff9d91bf205bd5425adcb4b1da044a531661
Gerrit-Change-Number: 63831
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
blocking_requirement
unsatisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
Aug 4, 2025, 6:06:29 PMAug 4
to Russ Cox, re2...@googlegroups.com
Attention needed from Russ Cox

Alan Donovan voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3d44ff9d91bf205bd5425adcb4b1da044a531661
Gerrit-Change-Number: 63831
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Attention: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Mon, 04 Aug 2025 22:06:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 4, 2025, 7:09:26 PMAug 4
to re2...@googlegroups.com
Attention needed from Russ Cox

Russ Cox uploaded new patchset

Russ Cox uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3d44ff9d91bf205bd5425adcb4b1da044a531661
Gerrit-Change-Number: 63831
Gerrit-PatchSet: 2
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 4, 2025, 7:11:19 PMAug 4
to Alan Donovan, re2...@googlegroups.com

Russ Cox added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Russ Cox . resolved

I added a comment to this file and did not lose the +2. Woo hoo!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3d44ff9d91bf205bd5425adcb4b1da044a531661
Gerrit-Change-Number: 63831
Gerrit-PatchSet: 2
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Mon, 04 Aug 2025 23:11:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 4, 2025, 7:11:24 PMAug 4
to Alan Donovan, re2...@googlegroups.com

Russ Cox submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: .github/workflows/release.yml
Insertions: 1, Deletions: 1.

@@ -1,7 +1,7 @@
name: Release
on:
push:
- tags: ['2[0-9][0-9][0-9]-[0-9][0-9]-[0-9][0-9]']
+ tags: ['2[0-9][0-9][0-9]-[0-9][0-9]-[0-9][0-9]'] # yyyy-mm-dd
permissions:
contents: read
jobs:
```

Change information

Commit message:
.github/workflows: only release on 2xxx-xx-xx tags

I will add an 'abseil.old' tag preserving the Abseil branch history.
This avoids having that tag trigger a release action.
Change-Id: I3d44ff9d91bf205bd5425adcb4b1da044a531661
Files:
  • M .github/workflows/release.yml
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Alan Donovan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3d44ff9d91bf205bd5425adcb4b1da044a531661
Gerrit-Change-Number: 63831
Gerrit-PatchSet: 3
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Russ Cox <r...@swtch.com>
open
diffy
satisfied_requirement

Alan Donovan (Gerrit)

unread,
Aug 4, 2025, 7:12:41 PMAug 4
to Russ Cox, re2...@googlegroups.com

Alan Donovan added 1 comment

Patchset-level comments
Russ Cox . resolved

I added a comment to this file and did not lose the +2. Woo hoo!

Alan Donovan

:-)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3d44ff9d91bf205bd5425adcb4b1da044a531661
Gerrit-Change-Number: 63831
Gerrit-PatchSet: 3
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Mon, 04 Aug 2025 23:12:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Russ Cox <r...@swtch.com>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages