[S] Change in code/re2[abseil]: Abseil Python no longer depends on `six`.

Paul Wankadia (Gerrit)

unread,

Aug 4, 2022, 7:22:31 AM8/4/22

to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded this change for review.

Abseil Python no longer depends on `six`.

Change-Id: I0a99d9dbbc48d5372a61e6ebda39894b8b9a441a
---
M WORKSPACE
1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/WORKSPACE b/WORKSPACE
index 0c51113..5caed92 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -43,12 +43,3 @@
     strip_prefix = "abseil-py-main",
     urls = ["https://github.com/abseil/abseil-py/archive/main.zip"],
 )
-
-# RE2 doesn't depend on this anymore, but Abseil Python still does.
-# We should be able to delete this when their six.BUILD is deleted.
-http_archive(
-    name = "six_archive",
-    build_file = "@io_abseil_py//third_party:six.BUILD",
-    strip_prefix = "six-master",
-    urls = ["https://github.com/benjaminp/six/archive/master.zip"],
-)

To view, visit change 60330. To unsubscribe, or for help writing mail filters, visit settings.

Perry Lorier (Gerrit)

unread,

Aug 4, 2022, 9:07:16 AM8/4/22

to Paul Wankadia, Randall Bosetti, re2...@googlegroups.com

Attention is currently required from: Paul Wankadia.

Patch set 1:Code-Review +1

View Change

To view, visit change 60330. To unsubscribe, or for help writing mail filters, visit settings.

Paul Wankadia (Gerrit)

unread,

Aug 4, 2022, 9:10:45 AM8/4/22

to Paul Wankadia, Perry Lorier, Randall Bosetti, re2...@googlegroups.com

Patch set 1:Code-Review +2

View Change

To view, visit change 60330. To unsubscribe, or for help writing mail filters, visit settings.

Paul Wankadia (Gerrit)

unread,

Aug 4, 2022, 9:10:50 AM8/4/22

to Paul Wankadia, Perry Lorier, Randall Bosetti, re2...@googlegroups.com

Paul Wankadia submitted this change.

View Change

Approvals:
  Paul Wankadia: Looks good to me, approved
  Perry Lorier: Looks good to me, but someone else must approve

Abseil Python no longer depends on `six`.

Change-Id: I0a99d9dbbc48d5372a61e6ebda39894b8b9a441a

Reviewed-on: https://code-review.googlesource.com/c/re2/+/60330
Reviewed-by: Paul Wankadia <jun...@google.com>
Reviewed-by: Perry Lorier <per...@google.com>
---
M WORKSPACE
1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/WORKSPACE b/WORKSPACE
index 0c51113..5caed92 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -43,12 +43,3 @@
     strip_prefix = "abseil-py-main",
     urls = ["https://github.com/abseil/abseil-py/archive/main.zip"],
 )
-
-# RE2 doesn't depend on this anymore, but Abseil Python still does.
-# We should be able to delete this when their six.BUILD is deleted.
-http_archive(
-    name = "six_archive",
-    build_file = "@io_abseil_py//third_party:six.BUILD",
-    strip_prefix = "six-master",
-    urls = ["https://github.com/benjaminp/six/archive/master.zip"],
-)

To view, visit change 60330. To unsubscribe, or for help writing mail filters, visit settings.

Jesse Dore (JesseJamesDore) (Gerrit)

unread,

May 19, 2023, 6:44:16 AM5/19/23

to Paul Wankadia, Perry Lorier, Randall Bosetti, re2...@googlegroups.com

View Change

1 comment:

Patchset:
- Patch Set #2:
  thanks for your help I greatly appreciate it

To view, visit change 60330. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward