[XS] Change in code/re2[main]: .github/workflows/release: grant release-bazel permissions

0 views
Skip to first unread message

Russ Cox (Gerrit)

unread,
Aug 12, 2025, 4:05:50 PMAug 12
to Jeremy Kun, re2...@googlegroups.com
Attention needed from Jeremy Kun

Russ Cox has uploaded the change for review

Russ Cox would like Jeremy Kun to review this change.

Commit message

.github/workflows/release: grant release-bazel permissions

Trying to fix:

The workflow is not valid.
.github/workflows/release.yml (Line: 46, Col: 26): Invalid secret, BCR_PUBLISH_TOKEN is not defined in the referenced workflow.
.github/workflows/release.yml (Line: 40, Col: 3): Error calling workflow 'google/re2/.github/workflows/release-bazel.yml@932b308415a622428df2187522db1d273e507164'. The nested job 'release' is requesting 'attestations: write, contents: write, id-token: write', but is only allowed 'attestations: none, contents: read, id-token: none'.

I made the secret repo-wide instead of being scoped to the bcr-push environment.
Not 100% sure that will fix that error.

The changes in this CL should fix the second error.
Change-Id: I7d1a537dd3d464fe0d99e612ae843a14243d24af

Change information

Files:
  • M .github/workflows/release.yml
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Jeremy Kun
Submit Requirements:
  • requirement is blockingCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I7d1a537dd3d464fe0d99e612ae843a14243d24af
Gerrit-Change-Number: 63950
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Jeremy Kun <jk...@google.com>
Gerrit-Attention: Jeremy Kun <jk...@google.com>
blocking_requirement
unsatisfied_requirement
open
diffy

Jeremy Kun (Gerrit)

unread,
Aug 12, 2025, 4:48:19 PMAug 12
to Russ Cox, re2...@googlegroups.com
Attention needed from Russ Cox

Jeremy Kun voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I7d1a537dd3d464fe0d99e612ae843a14243d24af
Gerrit-Change-Number: 63950
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Jeremy Kun <jk...@google.com>
Gerrit-Attention: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 20:48:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 12, 2025, 5:44:35 PMAug 12
to Jeremy Kun, re2...@googlegroups.com

Russ Cox voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I7d1a537dd3d464fe0d99e612ae843a14243d24af
Gerrit-Change-Number: 63950
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Jeremy Kun <jk...@google.com>
Gerrit-Reviewer: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 21:44:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 12, 2025, 5:44:40 PMAug 12
to Jeremy Kun, re2...@googlegroups.com

Russ Cox submitted the change

Change information

Commit message:
.github/workflows/release: grant release-bazel permissions

Trying to fix:

The workflow is not valid.
.github/workflows/release.yml (Line: 46, Col: 26): Invalid secret, BCR_PUBLISH_TOKEN is not defined in the referenced workflow.
.github/workflows/release.yml (Line: 40, Col: 3): Error calling workflow 'google/re2/.github/workflows/release-bazel.yml@932b308415a622428df2187522db1d273e507164'. The nested job 'release' is requesting 'attestations: write, contents: write, id-token: write', but is only allowed 'attestations: none, contents: read, id-token: none'.

I made the secret repo-wide instead of being scoped to the bcr-push environment.
Not 100% sure that will fix that error.

The changes in this CL should fix the second error.
Change-Id: I7d1a537dd3d464fe0d99e612ae843a14243d24af
Reviewed-by: Jeremy Kun <jk...@google.com>
Reviewed-by: Russ Cox <r...@swtch.com>
Files:
  • M .github/workflows/release.yml
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Russ Cox, +1 by Jeremy Kun
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I7d1a537dd3d464fe0d99e612ae843a14243d24af
Gerrit-Change-Number: 63950
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages