[S] Change in code/re2[main]: .github/workflows: define release-bazel and call from release

0 views
Skip to first unread message

Russ Cox (Gerrit)

unread,
Aug 11, 2025, 12:00:51 PMAug 11
to re2...@googlegroups.com

Russ Cox has uploaded the change for review

Commit message

.github/workflows: define release-bazel and call from release

Thanks very much to Jeremy Kun for figuring this all out.
Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1

Change information

Files:
  • A .github/workflows/release-bazel.yml
  • M .github/workflows/release.yml
Change size: S
Delta: 2 files changed, 36 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is blockingCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
blocking_requirement
unsatisfied_requirement
open
diffy

Yun Peng (Gerrit)

unread,
Aug 11, 2025, 12:10:14 PMAug 11
to Russ Cox, re2...@googlegroups.com
Attention needed from Russ Cox

Yun Peng voted and added 1 comment

Votes added by Yun Peng

Code-Review+1

1 comment

File .github/workflows/release.yml
Line 46, Patchset 1 (Latest): BCR_PUBLISH_TOKEN: ${{ secrets.BCR_PUBLISH_TOKEN }}
Yun Peng . unresolved

Do you have this token setup?

Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Yun Peng <pcl...@google.com>
Gerrit-Attention: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 16:10:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 11, 2025, 7:49:47 PMAug 11
to re2...@googlegroups.com
Attention needed from Yun Peng

Russ Cox uploaded new patchset

Russ Cox uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Yun Peng
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 2
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Yun Peng <pcl...@google.com>
Gerrit-Attention: Yun Peng <pcl...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 11, 2025, 7:49:48 PMAug 11
to Yun Peng, re2...@googlegroups.com
Attention needed from Yun Peng

Russ Cox added 1 comment

File .github/workflows/release.yml
Line 46, Patchset 1: BCR_PUBLISH_TOKEN: ${{ secrets.BCR_PUBLISH_TOKEN }}
Yun Peng . resolved

Do you have this token setup?

Russ Cox

Yes, in the environment bcr-push in the re2 project, although I'd forgotten to add the environment line to this file. Done.

Open in Gerrit

Related details

Attention is currently required from:
  • Yun Peng
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 2
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Yun Peng <pcl...@google.com>
Gerrit-Attention: Yun Peng <pcl...@google.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 23:49:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yun Peng <pcl...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Yun Peng (Gerrit)

unread,
Aug 12, 2025, 3:51:59 AMAug 12
to Russ Cox, re2...@googlegroups.com
Attention needed from Russ Cox

Yun Peng voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 2
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Yun Peng <pcl...@google.com>
Gerrit-Attention: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 07:51:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Jeremy Kun (Gerrit)

unread,
Aug 12, 2025, 12:57:05 PMAug 12
to Russ Cox, Yun Peng, re2...@googlegroups.com
Attention needed from Russ Cox

Jeremy Kun voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 2
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Jeremy Kun <jk...@google.com>
Gerrit-Reviewer: Yun Peng <pcl...@google.com>
Gerrit-Attention: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 16:57:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 12, 2025, 3:04:25 PMAug 12
to re2...@googlegroups.com
Attention needed from Russ Cox

Russ Cox uploaded new patchset

Russ Cox uploaded patch set #3 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 3
unsatisfied_requirement
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 12, 2025, 3:05:42 PMAug 12
to Jeremy Kun, Yun Peng, re2...@googlegroups.com

Russ Cox voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 3
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Jeremy Kun <jk...@google.com>
Gerrit-Reviewer: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Yun Peng <pcl...@google.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 19:05:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Aug 12, 2025, 3:09:30 PMAug 12
to Jeremy Kun, Yun Peng, re2...@googlegroups.com

Russ Cox submitted the change

Change information

Commit message:
.github/workflows: define release-bazel and call from release

Thanks very much to Jeremy Kun for figuring this all out.
Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1
Reviewed-by: Yun Peng <pcl...@google.com>
Reviewed-by: Russ Cox <r...@swtch.com>
Reviewed-by: Jeremy Kun <jk...@google.com>
Files:
  • A .github/workflows/release-bazel.yml
  • M .github/workflows/release.yml
Change size: S
Delta: 2 files changed, 37 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Russ Cox, +1 by Yun Peng, +1 by Jeremy Kun
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I3b6ec01ec6cd71b8f2a53bea71d17a58efe4f9b1
Gerrit-Change-Number: 63892
Gerrit-PatchSet: 4
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages