[S] Change in code/re2[main]: If we are building from the sdist, we are already in package form.

10 views
Skip to first unread message

Paul Wankadia (Gerrit)

unread,
Jun 30, 2024, 5:03:04 PM (2 days ago) Jun 30
to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded the change for review

Commit message

If we are building from the sdist, we are already in package form.

Fixes #500.
Change-Id: Ie13464dcb4bee249acc833d60b7fb15f65eeaf34

Change information

Files:
  • M python/setup.py
Change size: S
Delta: 1 file changed, 21 insertions(+), 17 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Ie13464dcb4bee249acc833d60b7fb15f65eeaf34
Gerrit-Change-Number: 63430
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
Jun 30, 2024, 5:04:32 PM (2 days ago) Jun 30
to Paul Wankadia, re2...@googlegroups.com
Attention needed from Alejandro Sedeño

Paul Wankadia uploaded new patchset

Paul Wankadia uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Alejandro Sedeño
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Ie13464dcb4bee249acc833d60b7fb15f65eeaf34
Gerrit-Change-Number: 63430
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Wankadia <jun...@google.com>
Gerrit-Reviewer: Alejandro Sedeño <ase...@google.com>
Gerrit-CC: Alex Chernyakhovsky <ache...@google.com>
Gerrit-CC: Perry Lorier <per...@google.com>
Gerrit-Attention: Alejandro Sedeño <ase...@google.com>
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
Jun 30, 2024, 5:06:16 PM (2 days ago) Jun 30
to Paul Wankadia, re2...@googlegroups.com
Attention needed from Alejandro Sedeño

Paul Wankadia uploaded new patchset

Paul Wankadia uploaded patch set #3 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Alejandro Sedeño
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Ie13464dcb4bee249acc833d60b7fb15f65eeaf34
Gerrit-Change-Number: 63430
Gerrit-PatchSet: 3
unsatisfied_requirement
open
diffy

Alejandro Sedeño (Gerrit)

unread,
Jun 30, 2024, 8:52:21 PM (2 days ago) Jun 30
to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com
Attention needed from Paul Wankadia

Alejandro Sedeño voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Wankadia
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie13464dcb4bee249acc833d60b7fb15f65eeaf34
    Gerrit-Change-Number: 63430
    Gerrit-PatchSet: 3
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alejandro Sedeño <ase...@google.com>
    Gerrit-CC: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Attention: Paul Wankadia <jun...@google.com>
    Gerrit-Comment-Date: Mon, 01 Jul 2024 00:52:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    Jul 1, 2024, 2:51:04 AM (2 days ago) Jul 1
    to Paul Wankadia, Alejandro Sedeño, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie13464dcb4bee249acc833d60b7fb15f65eeaf34
    Gerrit-Change-Number: 63430
    Gerrit-PatchSet: 3
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alejandro Sedeño <ase...@google.com>
    Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
    Gerrit-CC: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Comment-Date: Mon, 01 Jul 2024 06:51:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    Jul 1, 2024, 2:51:06 AM (2 days ago) Jul 1
    to Paul Wankadia, Alejandro Sedeño, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia submitted the change

    Change information

    Commit message:
    If we are building from the sdist, we are already in package form.

    Fixes #500.
    Change-Id: Ie13464dcb4bee249acc833d60b7fb15f65eeaf34
    Reviewed-by: Alejandro Sedeño <ase...@google.com>
    Reviewed-by: Paul Wankadia <jun...@google.com>
    Files:
    • M python/setup.py
    Change size: S
    Delta: 1 file changed, 21 insertions(+), 17 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Paul Wankadia, +1 by Alejandro Sedeño
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie13464dcb4bee249acc833d60b7fb15f65eeaf34
    Gerrit-Change-Number: 63430
    Gerrit-PatchSet: 4
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages