[L] Change in code/re2[main]: Clean and format `#include` directives.
4 views
Skip to first unread message
Paul Wankadia (Gerrit)
May 28, 2024, 11:43:32 AMMay 28
to Paul Wankadia, re2...@googlegroups.com
Paul Wankadia has uploaded the change for review![]( "Open in Gerrit")
Commit message
Clean and format `#include` directives.
Change-Id: Iba5a0f3a18245a22f68ba1c3d533200cc577a596
Change information
Files:
- M BUILD.bazel
- M CMakeLists.txt
- M Makefile
- M python/_re2.cc
- M re2/bitmap256.cc
- M re2/bitmap256.h
- M re2/bitstate.cc
- M re2/compile.cc
- M re2/dfa.cc
- M re2/filtered_re2.cc
- M re2/fuzzing/re2_fuzzer.cc
- M re2/mimics_pcre.cc
- M re2/nfa.cc
- M re2/onepass.cc
- M re2/parse.cc
- M re2/prefilter.cc
- M re2/prefilter_tree.cc
- M re2/prog.cc
- M re2/prog.h
- M re2/re2.cc
- M re2/re2.h
- M re2/regexp.cc
- M re2/regexp.h
- M re2/set.cc
- M re2/simplify.cc
- M re2/sparse_array.h
- M re2/sparse_set.h
- M re2/testing/backtrack.cc
- M re2/testing/charclass_test.cc
- M re2/testing/compile_test.cc
- M re2/testing/dfa_test.cc
- M re2/testing/dump.cc
- M re2/testing/exhaustive1_test.cc
- M re2/testing/exhaustive2_test.cc
- M re2/testing/exhaustive3_test.cc
- M re2/testing/exhaustive_test.cc
- M re2/testing/exhaustive_tester.cc
- M re2/testing/exhaustive_tester.h
- M re2/testing/filtered_re2_test.cc
- M re2/testing/mimics_pcre_test.cc
- M re2/testing/null_walker.cc
- M re2/testing/parse_test.cc
- M re2/testing/possible_match_test.cc
- M re2/testing/random_test.cc
- M re2/testing/re2_arg_test.cc
- M re2/testing/re2_test.cc
- M re2/testing/regexp_benchmark.cc
- M re2/testing/regexp_generator.cc
- M re2/testing/regexp_generator.h
- M re2/testing/regexp_test.cc
- M re2/testing/required_prefix_test.cc
- M re2/testing/search_test.cc
- M re2/testing/set_test.cc
- M re2/testing/simplify_test.cc
- M re2/testing/string_generator.cc
- M re2/testing/string_generator.h
- M re2/testing/string_generator_test.cc
- M re2/testing/tester.cc
- M re2/testing/tester.h
- M re2/tostring.cc
Change size: L
Delta: 60 files changed, 214 insertions(+), 130 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Chernyakhovsky (Gerrit)
May 28, 2024, 12:22:25 PMMay 28
to Paul Wankadia, Perry Lorier, re2...@googlegroups.com
Attention needed from Paul Wankadia
Alex Chernyakhovsky voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Chernyakhovsky
| Code-Review | +1 |
1 comment
File re2/bitmap256.cc
Line 11, Patchset 1 (Parent):
#include "absl/log/absl_log.h"Alex Chernyakhovsky . unresolved
We probably will need to carefully TGP this, since it's a removal
Related details
Attention is currently required from:
- Paul Wankadia
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Wankadia (Gerrit)
May 28, 2024, 12:23:27 PMMay 28
to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com
Attention needed from Alex Chernyakhovsky
Paul Wankadia voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Wankadia
| Code-Review | +2 |
1 comment
File re2/bitmap256.cc
Line 11, Patchset 1 (Parent):
#include "absl/log/absl_log.h"Alex Chernyakhovsky . resolved
We probably will need to carefully TGP this, since it's a removal
Attention is currently required from:
- Alex Chernyakhovsky
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Wankadia (Gerrit)
May 28, 2024, 12:23:29 PMMay 28
to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com
Paul Wankadia submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Clean and format `#include` directives.
Change-Id: Iba5a0f3a18245a22f68ba1c3d533200cc577a596
Reviewed-on: https://code-review.googlesource.com/c/re2/+/63130
Reviewed-by: Alex Chernyakhovsky <ache...@google.com>
Reviewed-by: Paul Wankadia <jun...@google.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Chernyakhovsky, +2 by Paul Wankadia
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages