[M] Change in code/re2[main]: CMakeLists: updates for clang-cl, skipping benchmarks, and C++17
1 view
Skip to first unread message
Russ Cox (Gerrit)
Jul 30, 2025, 11:28:18 AMJul 30
to Alan Donovan, re2...@googlegroups.com
Attention needed from Alan Donovan
Russ Cox has uploaded the change for review![]( "Open in Gerrit")
Russ Cox would like Alan Donovan to review this change.
Commit message
CMakeLists: updates for clang-cl, skipping benchmarks, and C++17
1. Test MSVC instead of CMAKE_CXX_COMPILER_ID MATCHES "MSVC"
When using the 'clang-cl' simulation of MSVC's 'cl' compiler,
we want to execute these adjustments, and MSVC will be true,
but CMAKE_CXX_COMPILER_ID MATCHES "MSVC" will not.
Thanks to Alexander Neumann for flagging and for the explanation.
Fixes #532.
2. Separate out building tests from building benchmarks, because
they have different dependencies, and some people might want to
build tests and skip the benchmarks.
3. Update to C++17 and factor that out to make future updates easier.
We require C++17 now per
https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
Change-Id: I5691847d5ff17636143981086f370e95e34900bd
Change information
Files:
- M CMakeLists.txt
Change size: M
Delta: 1 file changed, 66 insertions(+), 57 deletions(-)
Related details
Attention is currently required from:
- Alan Donovan
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
Jul 30, 2025, 11:44:48 AMJul 30
to Russ Cox, re2...@googlegroups.com
Attention needed from Russ Cox
Alan Donovan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alan Donovan
| Code-Review | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alan Donovan . resolved
The change looks plausible enough, but I don't really know anything about this file or CMake, so my approval is largely based on your reputation.
Related details
Attention is currently required from:
- Russ Cox
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
Jul 30, 2025, 12:28:42 PMJul 30
to Alan Donovan, re2...@googlegroups.com
Russ Cox submitted the change![]( "Open in Gerrit")
Change information
Commit message:
CMakeLists: updates for clang-cl, skipping benchmarks, and C++17
1. Test MSVC instead of CMAKE_CXX_COMPILER_ID MATCHES "MSVC"
When using the 'clang-cl' simulation of MSVC's 'cl' compiler,
we want to execute these adjustments, and MSVC will be true,
but CMAKE_CXX_COMPILER_ID MATCHES "MSVC" will not.
Thanks to Alexander Neumann for flagging and for the explanation.
Fixes #532.
2. Separate out building tests from building benchmarks, because
they have different dependencies, and some people might want to
build tests and skip the benchmarks.
3. Update to C++17 and factor that out to make future updates easier.
We require C++17 now per
https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
Change-Id: I5691847d5ff17636143981086f370e95e34900bd
Reviewed-on: https://code-review.googlesource.com/c/re2/+/63774
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
- M CMakeLists.txt
Change size: M
Delta: 1 file changed, 66 insertions(+), 57 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Alan Donovan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
Jul 30, 2025, 12:29:41 PMJul 30
to Alan Donovan, re2...@googlegroups.com
Russ Cox added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Alan Donovan . resolved
The change looks plausible enough, but I don't really know anything about this file or CMake, so my approval is largely based on your reputation.
Russ Cox
Plausible and tested is all I'm going for - I know little more than you do.
And I did test it.
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages