[M] Change in code/re2[main]: More setting up to run mypy as per #496.

3 views
Skip to first unread message

Paul Wankadia (Gerrit)

unread,
Jun 9, 2024, 11:39:16 AMJun 9
to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded the change for review

Commit message

More setting up to run mypy as per #496.

We need `re2` to be a package, not a module, because it appears that
modules can't have `.pyi` files, so munge the module into a package.
Change-Id: I1a268875743390c32c0fb9cd58f6d83a670ce928

Change information

Files:
  • M python/setup.py
Change size: M
Delta: 1 file changed, 36 insertions(+), 22 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I1a268875743390c32c0fb9cd58f6d83a670ce928
Gerrit-Change-Number: 63270
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
Jun 9, 2024, 1:00:58 PMJun 9
to Paul Wankadia, re2...@googlegroups.com
Attention needed from Alex Chernyakhovsky

Paul Wankadia uploaded new patchset

Paul Wankadia uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Chernyakhovsky
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I1a268875743390c32c0fb9cd58f6d83a670ce928
Gerrit-Change-Number: 63270
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Wankadia <jun...@google.com>
Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
Gerrit-CC: Perry Lorier <per...@google.com>
Gerrit-Attention: Alex Chernyakhovsky <ache...@google.com>
unsatisfied_requirement
open
diffy

Alex Chernyakhovsky (Gerrit)

unread,
Jun 10, 2024, 7:50:57 AMJun 10
to Paul Wankadia, Perry Lorier, re2...@googlegroups.com
Attention needed from Paul Wankadia

Alex Chernyakhovsky voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Wankadia
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: I1a268875743390c32c0fb9cd58f6d83a670ce928
    Gerrit-Change-Number: 63270
    Gerrit-PatchSet: 2
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Attention: Paul Wankadia <jun...@google.com>
    Gerrit-Comment-Date: Mon, 10 Jun 2024 11:50:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    Jun 10, 2024, 11:37:57 AMJun 10
    to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: I1a268875743390c32c0fb9cd58f6d83a670ce928
    Gerrit-Change-Number: 63270
    Gerrit-PatchSet: 2
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Comment-Date: Mon, 10 Jun 2024 15:37:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    Jun 10, 2024, 11:38:01 AMJun 10
    to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia submitted the change

    Change information

    Commit message:
    More setting up to run mypy as per #496.

    We need `re2` to be a package, not a module, because it appears that
    modules can't have `.pyi` files, so munge the module into a package.
    Change-Id: I1a268875743390c32c0fb9cd58f6d83a670ce928
    Reviewed-by: Paul Wankadia <jun...@google.com>
    Reviewed-by: Alex Chernyakhovsky <ache...@google.com>
    Files:
    • M python/setup.py
    Change size: S
    Delta: 1 file changed, 15 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Paul Wankadia, +1 by Alex Chernyakhovsky
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: I1a268875743390c32c0fb9cd58f6d83a670ce928
    Gerrit-Change-Number: 63270
    Gerrit-PatchSet: 3
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages