[S] Change in code/re2[main]: Add Clang 15 to the build matrix.

1 view
Skip to first unread message

Paul Wankadia (Gerrit)

unread,
Aug 26, 2022, 12:04:41 PM8/26/22
to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded this change for review.

View Change

Add Clang 15 to the build matrix.

Change-Id: I34d611dd8f506d478813b431c411b311308d7bfc
---
M .github/workflows/ci.yml
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7ce3a93..8131c9f 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -27,7 +27,7 @@
strategy:
fail-fast: false
matrix:
- ver: [9, 10, 11, 12, 13, 14]
+ ver: [9, 10, 11, 12, 13, 14, 15]
env:
CC: clang-${{ matrix.ver }}
CXX: clang++-${{ matrix.ver }}

To view, visit change 60452. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I34d611dd8f506d478813b431c411b311308d7bfc
Gerrit-Change-Number: 60452
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
Gerrit-MessageType: newchange

Andy Miller (Gerrit)

unread,
Aug 26, 2022, 12:40:48 PM8/26/22
to Paul Wankadia, Perry Lorier, Randall Bosetti, re2...@googlegroups.com

Attention is currently required from: Paul Wankadia, Perry Lorier.

Patch set 1:Code-Review +1

View Change

    To view, visit change 60452. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: I34d611dd8f506d478813b431c411b311308d7bfc
    Gerrit-Change-Number: 60452
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Andy Miller <ar...@google.com>
    Gerrit-Reviewer: Perry Lorier <per...@google.com>
    Gerrit-CC: Randall Bosetti <r...@google.com>
    Gerrit-Attention: Perry Lorier <per...@google.com>
    Gerrit-Attention: Paul Wankadia <jun...@google.com>
    Gerrit-Comment-Date: Fri, 26 Aug 2022 16:40:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Paul Wankadia (Gerrit)

    unread,
    Aug 26, 2022, 12:42:03 PM8/26/22
    to Paul Wankadia, Andy Miller, Perry Lorier, Randall Bosetti, re2...@googlegroups.com

    Attention is currently required from: Perry Lorier.

    Patch set 1:Code-Review +2

    View Change

      To view, visit change 60452. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: re2
      Gerrit-Branch: main
      Gerrit-Change-Id: I34d611dd8f506d478813b431c411b311308d7bfc
      Gerrit-Change-Number: 60452
      Gerrit-PatchSet: 1
      Gerrit-Owner: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Andy Miller <ar...@google.com>
      Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Perry Lorier <per...@google.com>
      Gerrit-CC: Randall Bosetti <r...@google.com>
      Gerrit-Attention: Perry Lorier <per...@google.com>
      Gerrit-Comment-Date: Fri, 26 Aug 2022 16:41:58 +0000

      Paul Wankadia (Gerrit)

      unread,
      Aug 26, 2022, 12:42:05 PM8/26/22
      to Paul Wankadia, Andy Miller, Perry Lorier, Randall Bosetti, re2...@googlegroups.com

      Paul Wankadia submitted this change.

      View Change


      Approvals: Andy Miller: Looks good to me, but someone else must approve Paul Wankadia: Looks good to me, approved
      Add Clang 15 to the build matrix.

      Change-Id: I34d611dd8f506d478813b431c411b311308d7bfc
      Reviewed-on: https://code-review.googlesource.com/c/re2/+/60452
      Reviewed-by: Andy Miller <ar...@google.com>
      Reviewed-by: Paul Wankadia <jun...@google.com>
      ---
      M .github/workflows/ci.yml
      1 file changed, 13 insertions(+), 1 deletion(-)

      diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
      index 7ce3a93..8131c9f 100644
      --- a/.github/workflows/ci.yml
      +++ b/.github/workflows/ci.yml
      @@ -27,7 +27,7 @@
      strategy:
      fail-fast: false
      matrix:
      - ver: [9, 10, 11, 12, 13, 14]
      + ver: [9, 10, 11, 12, 13, 14, 15]
      env:
      CC: clang-${{ matrix.ver }}
      CXX: clang++-${{ matrix.ver }}

      To view, visit change 60452. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: re2
      Gerrit-Branch: main
      Gerrit-Change-Id: I34d611dd8f506d478813b431c411b311308d7bfc
      Gerrit-Change-Number: 60452
      Gerrit-PatchSet: 2
      Gerrit-Owner: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Andy Miller <ar...@google.com>
      Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Perry Lorier <per...@google.com>
      Gerrit-CC: Randall Bosetti <r...@google.com>
      Gerrit-MessageType: merged

      Paul Wankadia (Gerrit)

      unread,
      Aug 26, 2022, 12:42:18 PM8/26/22
      to Paul Wankadia, Andy Miller, Perry Lorier, Randall Bosetti, re2...@googlegroups.com

      View Change

      1 comment:

      • Patchset:

        • Patch Set #2:

          No cherry-pick to abseil branch: GNU make isn't supported there.

      To view, visit change 60452. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: re2
      Gerrit-Branch: main
      Gerrit-Change-Id: I34d611dd8f506d478813b431c411b311308d7bfc
      Gerrit-Change-Number: 60452
      Gerrit-PatchSet: 2
      Gerrit-Owner: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Andy Miller <ar...@google.com>
      Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Perry Lorier <per...@google.com>
      Gerrit-CC: Randall Bosetti <r...@google.com>
      Gerrit-Comment-Date: Fri, 26 Aug 2022 16:42:13 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Gerrit-MessageType: comment
      Reply all
      Reply to author
      Forward
      0 new messages