[S] Change in code/re2[abseil]: GitHub Pages is sufficient for hosting.

7 views
Skip to first unread message

Paul Wankadia (Gerrit)

unread,
Aug 26, 2022, 3:26:24 PM8/26/22
to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded this change for review.

View Change

GitHub Pages is sufficient for hosting.

Change-Id: If4cbf59c530cdb90d13054aad5107a6a0727a84a
---
D app/app.yaml
1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/app/app.yaml b/app/app.yaml
deleted file mode 100644
index 62150fb..0000000
--- a/app/app.yaml
+++ /dev/null
@@ -1,10 +0,0 @@
-runtime: python310
-handlers:
-- url: /
- secure: always
- static_files: deploy/index.html
- upload: deploy/index.html
-- url: /(.*)
- secure: always
- static_files: deploy/\1
- upload: deploy/(.*)

To view, visit change 60453. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: re2
Gerrit-Branch: abseil
Gerrit-Change-Id: If4cbf59c530cdb90d13054aad5107a6a0727a84a
Gerrit-Change-Number: 60453
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
Gerrit-MessageType: newchange

Alex Chernyakhovsky (Gerrit)

unread,
Aug 26, 2022, 3:27:18 PM8/26/22
to Paul Wankadia, re2...@googlegroups.com

Attention is currently required from: Paul Wankadia.

Patch set 1:Code-Review +1

View Change

    To view, visit change 60453. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: re2
    Gerrit-Branch: abseil
    Gerrit-Change-Id: If4cbf59c530cdb90d13054aad5107a6a0727a84a
    Gerrit-Change-Number: 60453
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-Attention: Paul Wankadia <jun...@google.com>
    Gerrit-Comment-Date: Fri, 26 Aug 2022 19:27:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Paul Wankadia (Gerrit)

    unread,
    Aug 26, 2022, 3:27:36 PM8/26/22
    to Paul Wankadia, Alex Chernyakhovsky, re2...@googlegroups.com

    Patch set 1:Code-Review +2

    View Change

      To view, visit change 60453. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: re2
      Gerrit-Branch: abseil
      Gerrit-Change-Id: If4cbf59c530cdb90d13054aad5107a6a0727a84a
      Gerrit-Change-Number: 60453
      Gerrit-PatchSet: 1
      Gerrit-Owner: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
      Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
      Gerrit-Comment-Date: Fri, 26 Aug 2022 19:27:31 +0000

      Paul Wankadia (Gerrit)

      unread,
      Aug 26, 2022, 3:27:40 PM8/26/22
      to Paul Wankadia, Alex Chernyakhovsky, re2...@googlegroups.com

      Paul Wankadia submitted this change.

      View Change


      Approvals: Paul Wankadia: Looks good to me, approved Alex Chernyakhovsky: Looks good to me, but someone else must approve
      GitHub Pages is sufficient for hosting.

      Change-Id: If4cbf59c530cdb90d13054aad5107a6a0727a84a
      Reviewed-on: https://code-review.googlesource.com/c/re2/+/60453
      Reviewed-by: Alex Chernyakhovsky <ache...@google.com>
      Reviewed-by: Paul Wankadia <jun...@google.com>
      ---
      D app/app.yaml
      1 file changed, 12 insertions(+), 10 deletions(-)

      diff --git a/app/app.yaml b/app/app.yaml
      deleted file mode 100644
      index 62150fb..0000000
      --- a/app/app.yaml
      +++ /dev/null
      @@ -1,10 +0,0 @@
      -runtime: python310
      -handlers:
      -- url: /
      - secure: always
      - static_files: deploy/index.html
      - upload: deploy/index.html
      -- url: /(.*)
      - secure: always
      - static_files: deploy/\1
      - upload: deploy/(.*)

      To view, visit change 60453. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: re2
      Gerrit-Branch: abseil
      Gerrit-Change-Id: If4cbf59c530cdb90d13054aad5107a6a0727a84a
      Gerrit-Change-Number: 60453
      Gerrit-PatchSet: 2
      Gerrit-Owner: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
      Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages