[XL] Change in code/re2[main]: Use the `ABSL_`-prefixed Abseil logging macros.

1 view
Skip to first unread message

Paul Wankadia (Gerrit)

unread,
May 18, 2024, 7:13:24 AMMay 18
to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded the change for review

Commit message

Use the `ABSL_`-prefixed Abseil logging macros.

This is done primarily for the sake of Chromium,
which bans the unprefixed Abseil logging macros.

I mostly baked the following slices of Perl pie:

```
's,//absl/log:check",//absl/log:absl_check",'
's,//absl/log",//absl/log:absl_log",'
's,"absl/log/check.h","absl/log/absl_check.h",'
's,"absl/log/log.h","absl/log/absl_log.h",'
's,D?CHECK(_(EQ|NE|LE|LT|GE|GT))?\(,ABSL_$&,'
's,V?LOG\(,ABSL_$&,'
```
Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a

Change information

Files:
  • M BUILD.bazel
  • M CMakeLists.txt
  • M Makefile
  • M re2/bitmap256.cc
  • M re2/bitmap256.h
  • M re2/bitstate.cc
  • M re2/compile.cc
  • M re2/dfa.cc
  • M re2/filtered_re2.cc
  • M re2/mimics_pcre.cc
  • M re2/nfa.cc
  • M re2/onepass.cc
  • M re2/parse.cc
  • M re2/prefilter.cc
  • M re2/prefilter.h
  • M re2/prefilter_tree.cc
  • M re2/prefilter_tree.h
  • M re2/prog.cc
  • M re2/prog.h
  • M re2/re2.cc
  • M re2/re2.h
  • M re2/regexp.cc
  • M re2/regexp.h
  • M re2/set.cc
  • M re2/simplify.cc
  • M re2/testing/backtrack.cc
  • M re2/testing/compile_test.cc
  • M re2/testing/dfa_test.cc
  • M re2/testing/dump.cc
  • M re2/testing/exhaustive_tester.cc
  • M re2/testing/filtered_re2_test.cc
  • M re2/testing/mimics_pcre_test.cc
  • M re2/testing/null_walker.cc
  • M re2/testing/parse_test.cc
  • M re2/testing/possible_match_test.cc
  • M re2/testing/re2_arg_test.cc
  • M re2/testing/re2_test.cc
  • M re2/testing/regexp_benchmark.cc
  • M re2/testing/regexp_generator.cc
  • M re2/testing/regexp_test.cc
  • M re2/testing/required_prefix_test.cc
  • M re2/testing/set_test.cc
  • M re2/testing/simplify_test.cc
  • M re2/testing/string_generator.cc
  • M re2/testing/tester.cc
  • M re2/tostring.cc
  • M re2/walker-inl.h
  • M util/pcre.cc
  • M util/pcre.h
Change size: XL
Delta: 49 files changed, 546 insertions(+), 546 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
Gerrit-Change-Number: 63092
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
unsatisfied_requirement
open
diffy

Alex Chernyakhovsky (Gerrit)

unread,
May 20, 2024, 8:04:38 AMMay 20
to Paul Wankadia, Perry Lorier, re2...@googlegroups.com
Attention needed from Paul Wankadia

Alex Chernyakhovsky added 60 comments

File re2/bitstate.cc
Line 111, Patchset 1 (Latest): ABSL_LOG(DFATAL) << "GrowStack() failed: "
<< "njob_ = " << njob_ << ", "
<< "job_.size() = " << job_.size();
Alex Chernyakhovsky . unresolved

indentation

File re2/filtered_re2.cc
Line 56, Patchset 1 (Latest): ABSL_LOG(ERROR) << "Couldn't compile regular expression, skipping: "
<< pattern << " due to error " << re->error();
Alex Chernyakhovsky . unresolved

indentation

File re2/nfa.cc
Line 542, Patchset 1 (Latest): ABSL_LOG(DFATAL) << "Unexpected opcode in short circuit: " << ip->opcode();
Alex Chernyakhovsky . unresolved

over 80 chars

Line 672, Patchset 1 (Latest): ABSL_LOG(DFATAL) << "unhandled " << ip->opcode() << " in Prog::Fanout()";
Alex Chernyakhovsky . unresolved

over 80 chars

File re2/parse.cc
Line 1217, Patchset 1 (Latest): ABSL_LOG(DFATAL) << "RE2: unexpected op: " << re->op() << " "
<< re->ToString();
}
Alex Chernyakhovsky . unresolved

indentation

File re2/prefilter.cc
Line 638, Patchset 1 (Latest): ABSL_LOG(ERROR) << "BuildInfo " << re->ToString()
<< ": " << (info ? info->ToString() : "");
Alex Chernyakhovsky . unresolved

indentation

File re2/prefilter_tree.cc
Line 346, Patchset 1 (Latest): << " N: " << parents.size() << " R: " << regexps.size();
Alex Chernyakhovsky . unresolved

indentation

File re2/prog.h
Line 86, Patchset 1 (Latest): int out1() { ABSL_DCHECK(opcode() == kInstAlt || opcode() == kInstAltMatch); return out1_; }
int cap() { ABSL_DCHECK_EQ(opcode(), kInstCapture); return cap_; }
int lo() { ABSL_DCHECK_EQ(opcode(), kInstByteRange); return lo_; }
int hi() { ABSL_DCHECK_EQ(opcode(), kInstByteRange); return hi_; }
int foldcase() { ABSL_DCHECK_EQ(opcode(), kInstByteRange); return hint_foldcase_&1; }
int hint() { ABSL_DCHECK_EQ(opcode(), kInstByteRange); return hint_foldcase_>>1; }
int match_id() { ABSL_DCHECK_EQ(opcode(), kInstMatch); return match_id_; }
EmptyOp empty() { ABSL_DCHECK_EQ(opcode(), kInstEmptyWidth); return empty_; }
Alex Chernyakhovsky . unresolved

A bunch of these are over 80 chars. Admittedly some on the left-hand side already were.

File re2/re2.h
Line 66, Patchset 1 (Latest):// ABSL_CHECK(RE2::FullMatch(latin1_string, RE2(latin1_pattern, RE2::Latin1)));
Alex Chernyakhovsky . unresolved

Over 80 chars

File re2/re2.cc
Line 233, Patchset 1 (Latest): ABSL_LOG(ERROR) << "Error parsing '" << trunc(*pattern_) << "': "
<< status.Text();
}
Alex Chernyakhovsky . unresolved

indentation

Line 285, Patchset 1 (Latest): << "'";
Alex Chernyakhovsky . unresolved

indentation

Line 663, Patchset 1 (Latest): ABSL_LOG(ERROR) << "RE2: invalid startpos, endpos pair. ["
<< "startpos: " << startpos << ", "
<< "endpos: " << endpos << ", "
<< "text size: " << text.size() << "]";
Alex Chernyakhovsky . unresolved

indentation

Line 754, Patchset 1 (Latest): ABSL_LOG(ERROR) << "DFA out of memory: "
<< "pattern length " << pattern_->size() << ", "
<< "program size " << prog->size() << ", "
<< "list count " << prog->list_count() << ", "
<< "bytemap range " << prog->bytemap_range();
Alex Chernyakhovsky . unresolved

indentation

Line 774, Patchset 1 (Latest): ABSL_LOG(ERROR) << "DFA out of memory: "
<< "pattern length " << pattern_->size() << ", "
<< "program size " << prog_->size() << ", "
<< "list count " << prog_->list_count() << ", "
<< "bytemap range " << prog_->bytemap_range();
Alex Chernyakhovsky . unresolved

indentation

Line 800, Patchset 1 (Latest): ABSL_LOG(ERROR) << "DFA out of memory: "
<< "pattern length " << pattern_->size() << ", "
<< "program size " << prog->size() << ", "
<< "list count " << prog->list_count() << ", "
<< "bytemap range " << prog->bytemap_range();
Alex Chernyakhovsky . unresolved

indentation

Line 843, Patchset 1 (Latest): ABSL_LOG(ERROR) << "DFA out of memory: "
<< "pattern length " << pattern_->size() << ", "
<< "program size " << prog_->size() << ", "
<< "list count " << prog_->list_count() << ", "
<< "bytemap range " << prog_->bytemap_range();
Alex Chernyakhovsky . unresolved

indentation

Line 1038, Patchset 1 (Latest): << " from " << veclen << " groups";
Alex Chernyakhovsky . unresolved

indentation

File re2/regexp.h
Line 341, Patchset 1 (Latest): const std::string* name() { ABSL_DCHECK_EQ(op_, kRegexpCapture); return name_; }
Alex Chernyakhovsky . unresolved

over 80 chars

File re2/set.cc
Line 148, Patchset 1 (Latest): ABSL_LOG(ERROR) << "DFA out of memory: "
<< "program size " << prog_->size() << ", "
<< "list count " << prog_->list_count() << ", "
<< "bytemap range " << prog_->bytemap_range();
if (error_info != NULL)
Alex Chernyakhovsky . unresolved

indentation

Line 165, Patchset 1 (Latest): ABSL_LOG(DFATAL) << "RE2::Set::Match() matched, but no matches returned?!";
Alex Chernyakhovsky . unresolved

over 80 chars

File re2/simplify.cc
Line 665, Patchset 1 (Latest): ABSL_LOG(DFATAL) << "Malformed repeat " << re->ToString() << " " << min << " " << max;
Alex Chernyakhovsky . unresolved

over 80 chars

File re2/testing/backtrack.cc
Line 192, Patchset 1 (Latest): ABSL_LOG(FATAL) << "Unexpected opcode: " << (int)ip->opcode();
Alex Chernyakhovsky . unresolved

optional nit: upgrade to C++-style cast?

File re2/testing/dfa_test.cc
Line 115, Patchset 1 (Latest): //ABSL_LOG(INFO) << "limit " << limit << ", "
// << "prog usage " << progusage << ", "
// << "DFA budget " << dfamem << ", "
// << "total " << usage;
Alex Chernyakhovsky . unresolved

indentation? and or delete?

Line 193, Patchset 1 (Latest): //ABSL_LOG(INFO) << "usage " << usage << ", "
// << "peak usage " << peak_usage;
Alex Chernyakhovsky . unresolved

same here

Line 365, Patchset 1 (Latest): ABSL_LOG(ERROR) << t.regexp << " dump:\ngot " << dump << "\nwant " << t.dump;
Alex Chernyakhovsky . unresolved

over 80 chars

File re2/testing/exhaustive_tester.cc
Line 86, Patchset 1 (Latest): ABSL_CHECK(fmt != nullptr);
regexp = absl::StrFormat(*fmt, regexp);
Alex Chernyakhovsky . unresolved

optional: `regexp = absl:StrFormat(*ABSL_DIE_IF_NULL(fmt), regexp);`

File re2/testing/possible_match_test.cc
Line 218, Patchset 1 (Latest): ABSL_LOG(QFATAL) << "PossibleMatchRange failed on: " << absl::CEscape(regexp);
Alex Chernyakhovsky . unresolved

over 80 chars

Line 245, Patchset 1 (Latest): ABSL_LOG(INFO) << t.regexps() << " regexps, "
<< t.tests() << " tests";
Alex Chernyakhovsky . unresolved

indentation

File re2/testing/re2_test.cc
Line 777, Patchset 1 (Latest): ABSL_LOG(INFO) << "Memory at " << (void*)v;
Alex Chernyakhovsky . unresolved

optional: c++-style cast?

Line 1568, Patchset 1 (Latest): const char b[] = {
(char)0x28, (char)0x05, (char)0x05, (char)0x41, (char)0x41, (char)0x28,
(char)0x24, (char)0x5b, (char)0x5e, (char)0xf5, (char)0x87, (char)0x87,
(char)0x90, (char)0x29, (char)0x5d, (char)0x29, (char)0x29, (char)0x00,
};
Alex Chernyakhovsky . unresolved

pre-existing, but is there any particular reason this wasn't written as

```
const char b[] = "\x28\x05\x05...";
```

File re2/testing/regexp_benchmark.cc
Line 45, Patchset 1 (Latest): ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . unresolved

over 90 chars

Line 62, Patchset 1 (Latest): // Can't pass mc.HeapGrowth() and mc.PeakHeapGrowth() to ABSL_LOG(INFO) directly,
Alex Chernyakhovsky . unresolved

over 80 chars

Line 77, Patchset 1 (Latest): ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 870, Patchset 1 (Latest): ABSL_CHECK_EQ(prog->SearchDFA(text, absl::string_view(), anchor,
Prog::kFirstMatch, NULL, &failed, NULL),
expect_match);
Alex Chernyakhovsky . unresolved

indentation?

Line 887, Patchset 1 (Latest): ABSL_CHECK_EQ(prog->SearchNFA(text, absl::string_view(), anchor,
Prog::kFirstMatch, NULL, 0),
expect_match);
Alex Chernyakhovsky . unresolved

indentation?

Line 904, Patchset 1 (Latest): ABSL_CHECK_EQ(prog->SearchOnePass(text, text, anchor, Prog::kFirstMatch, NULL, 0),
Alex Chernyakhovsky . unresolved

over 80 chars

Line 920, Patchset 1 (Latest): ABSL_CHECK_EQ(prog->SearchBitState(text, text, anchor, Prog::kFirstMatch, NULL, 0),
Alex Chernyakhovsky . unresolved

over 80 chars

Line 922, Patchset 1 (Latest): delete prog;
Alex Chernyakhovsky . unresolved

optional: absl::WrapUnique on the output of CompileToProg (throughout)

Line 946, Patchset 1 (Latest): if (anchor == Prog::kAnchored)
ABSL_CHECK_EQ(RE2::FullMatch(text, re), expect_match);
else
ABSL_CHECK_EQ(RE2::PartialMatch(text, re), expect_match);
}
Alex Chernyakhovsky . unresolved

optional: add the curly braces

Line 1031, Patchset 1 (Latest): ABSL_CHECK_EQ(prog->SearchOnePass(text, text, anchor, Prog::kFirstMatch, NULL, 0),
expect_match);
}
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1042, Patchset 1 (Latest): ABSL_CHECK_EQ(prog->SearchBitState(text, text, anchor, Prog::kFirstMatch, NULL, 0),
expect_match);
}
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1098, Patchset 1 (Latest): ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1113, Patchset 1 (Latest): ABSL_CHECK(prog->SearchBitState(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1127, Patchset 1 (Latest): ABSL_CHECK(prog->UnsafeSearchBacktrack(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1169, Patchset 1 (Latest): ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1179, Patchset 1 (Latest): ABSL_CHECK(prog->SearchBitState(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1188, Patchset 1 (Latest): ABSL_CHECK(prog->UnsafeSearchBacktrack(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1221, Patchset 1 (Latest): ABSL_CHECK(prog->SearchNFA(text, absl::string_view(), Prog::kAnchored,
Prog::kFullMatch, sp, 2));
delete prog;
Alex Chernyakhovsky . unresolved

indentation?

Line 1237, Patchset 1 (Latest): ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 2));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1252, Patchset 1 (Latest): ABSL_CHECK(prog->SearchBitState(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 2));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1294, Patchset 1 (Latest): ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 2));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1304, Patchset 1 (Latest): ABSL_CHECK(prog->SearchBitState(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 2));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1313, Patchset 1 (Latest): ABSL_CHECK(prog->UnsafeSearchBacktrack(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 2));
Alex Chernyakhovsky . unresolved

over 80 chars

Line 1521, Patchset 1 (Latest):void FullMatch_DotStarDollar_CachedPCRE(benchmark::State& state) { FullMatchPCRE(state, "(?s).*$"); }
void FullMatch_DotStarDollar_CachedRE2(benchmark::State& state) { FullMatchRE2(state, "(?s).*$"); }
Alex Chernyakhovsky . unresolved

pre-existing over 80 chars

File re2/testing/tester.cc
Line 208, Patchset 1 (Latest): << " mode: " << FormatMode(flags);
Alex Chernyakhovsky . unresolved

indentation

Line 220, Patchset 1 (Latest): ABSL_LOG(INFO) << "Prog for "
<< " regexp "
<< absl::CEscape(regexp_str_)
<< " (" << FormatKind(kind_)
<< ", " << FormatMode(flags_)
<< ")\n"
<< prog_->Dump();
}
Alex Chernyakhovsky . unresolved

indentation

Line 233, Patchset 1 (Latest): ABSL_LOG(INFO) << "Cannot reverse compile: " << absl::CEscape(regexp_str_);
Alex Chernyakhovsky . unresolved

over 80 chars

Line 370, Patchset 1 (Latest): ABSL_LOG(ERROR) << "Reverse DFA inconsistency: "
<< absl::CEscape(regexp_str_)
<< " on " << absl::CEscape(text);
Alex Chernyakhovsky . unresolved

indnetation

Line 524, Patchset 1 (Latest): ABSL_LOG(ERROR) << "Skipped backtracking! " << absl::CEscape(regexp_str_)
<< " " << FormatMode(flags_);
return false;
Alex Chernyakhovsky . unresolved

indentation

Line 528, Patchset 1 (Latest): ABSL_VLOG(1) << "Try: regexp " << absl::CEscape(regexp_str_)
<< " text " << absl::CEscape(text)
<< " (" << FormatKind(kind_)
<< ", " << FormatAnchor(anchor)
<< ", " << FormatMode(flags_)
<< ")";
Alex Chernyakhovsky . unresolved

indentation

Open in Gerrit

Related details

Attention is currently required from:
  • Paul Wankadia
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
Gerrit-Change-Number: 63092
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
Gerrit-CC: Perry Lorier <per...@google.com>
Gerrit-Attention: Paul Wankadia <jun...@google.com>
Gerrit-Comment-Date: Mon, 20 May 2024 12:04:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
May 20, 2024, 8:38:42 AMMay 20
to Paul Wankadia, re2...@googlegroups.com
Attention needed from Paul Wankadia

Paul Wankadia uploaded new patchset

Paul Wankadia uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Wankadia
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
Gerrit-Change-Number: 63092
Gerrit-PatchSet: 2
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
May 20, 2024, 8:40:09 AMMay 20
to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com
Attention needed from Alex Chernyakhovsky

Paul Wankadia added 32 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Paul Wankadia . resolved

This is just the first round, which were trivial. I need to think about the second round very slightly more.

File re2/bitstate.cc
Line 111, Patchset 1: ABSL_LOG(DFATAL) << "GrowStack() failed: "

<< "njob_ = " << njob_ << ", "
<< "job_.size() = " << job_.size();
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

File re2/filtered_re2.cc
Line 56, Patchset 1: ABSL_LOG(ERROR) << "Couldn't compile regular expression, skipping: "

<< pattern << " due to error " << re->error();
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

File re2/nfa.cc
Line 542, Patchset 1: ABSL_LOG(DFATAL) << "Unexpected opcode in short circuit: " << ip->opcode();
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 672, Patchset 1: ABSL_LOG(DFATAL) << "unhandled " << ip->opcode() << " in Prog::Fanout()";
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

File re2/parse.cc
Line 1217, Patchset 1: ABSL_LOG(DFATAL) << "RE2: unexpected op: " << re->op() << " "
<< re->ToString();
}
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

File re2/prefilter.cc
Line 638, Patchset 1: ABSL_LOG(ERROR) << "BuildInfo " << re->ToString()

<< ": " << (info ? info->ToString() : "");
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

File re2/prefilter_tree.cc
Line 346, Patchset 1: << " N: " << parents.size() << " R: " << regexps.size();
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

File re2/re2.h
Line 66, Patchset 1:// ABSL_CHECK(RE2::FullMatch(latin1_string, RE2(latin1_pattern, RE2::Latin1)));
Alex Chernyakhovsky . resolved

Over 80 chars

Paul Wankadia

Done

File re2/re2.cc
Line 233, Patchset 1: ABSL_LOG(ERROR) << "Error parsing '" << trunc(*pattern_) << "': "
<< status.Text();
}
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 285, Patchset 1: << "'";
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 663, Patchset 1: ABSL_LOG(ERROR) << "RE2: invalid startpos, endpos pair. ["

<< "startpos: " << startpos << ", "
<< "endpos: " << endpos << ", "
<< "text size: " << text.size() << "]";
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 754, Patchset 1: ABSL_LOG(ERROR) << "DFA out of memory: "

<< "pattern length " << pattern_->size() << ", "
<< "program size " << prog->size() << ", "
<< "list count " << prog->list_count() << ", "
<< "bytemap range " << prog->bytemap_range();
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 774, Patchset 1: ABSL_LOG(ERROR) << "DFA out of memory: "

<< "pattern length " << pattern_->size() << ", "
<< "program size " << prog_->size() << ", "
<< "list count " << prog_->list_count() << ", "
<< "bytemap range " << prog_->bytemap_range();
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 800, Patchset 1: ABSL_LOG(ERROR) << "DFA out of memory: "

<< "pattern length " << pattern_->size() << ", "
<< "program size " << prog->size() << ", "
<< "list count " << prog->list_count() << ", "
<< "bytemap range " << prog->bytemap_range();
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 843, Patchset 1: ABSL_LOG(ERROR) << "DFA out of memory: "

<< "pattern length " << pattern_->size() << ", "
<< "program size " << prog_->size() << ", "
<< "list count " << prog_->list_count() << ", "
<< "bytemap range " << prog_->bytemap_range();
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 1038, Patchset 1: << " from " << veclen << " groups";
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

File re2/set.cc
Line 148, Patchset 1: ABSL_LOG(ERROR) << "DFA out of memory: "

<< "program size " << prog_->size() << ", "
<< "list count " << prog_->list_count() << ", "
<< "bytemap range " << prog_->bytemap_range();
if (error_info != NULL)
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 165, Patchset 1: ABSL_LOG(DFATAL) << "RE2::Set::Match() matched, but no matches returned?!";
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

File re2/simplify.cc
Line 665, Patchset 1: ABSL_LOG(DFATAL) << "Malformed repeat " << re->ToString() << " " << min << " " << max;
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

File re2/testing/backtrack.cc
Line 192, Patchset 1: ABSL_LOG(FATAL) << "Unexpected opcode: " << (int)ip->opcode();
Alex Chernyakhovsky . resolved

optional nit: upgrade to C++-style cast?

Paul Wankadia

Done. (No cast was necessary.)

File re2/testing/exhaustive_tester.cc
Line 86, Patchset 1: ABSL_CHECK(fmt != nullptr);

regexp = absl::StrFormat(*fmt, regexp);
Alex Chernyakhovsky . resolved

optional: `regexp = absl:StrFormat(*ABSL_DIE_IF_NULL(fmt), regexp);`

Paul Wankadia

Good point. There are a couple of similar cases in `regexp_generator.cc`, but I'm leaning towards "meh" on adding a dependency for so few cases in testing helpers.

File re2/testing/possible_match_test.cc
Line 218, Patchset 1: ABSL_LOG(QFATAL) << "PossibleMatchRange failed on: " << absl::CEscape(regexp);
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 245, Patchset 1: ABSL_LOG(INFO) << t.regexps() << " regexps, "
<< t.tests() << " tests";
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

File re2/testing/re2_test.cc
Line 777, Patchset 1: ABSL_LOG(INFO) << "Memory at " << (void*)v;
Alex Chernyakhovsky . resolved

optional: c++-style cast?

Paul Wankadia

Done

Line 1568, Patchset 1: const char b[] = {

(char)0x28, (char)0x05, (char)0x05, (char)0x41, (char)0x41, (char)0x28,
(char)0x24, (char)0x5b, (char)0x5e, (char)0xf5, (char)0x87, (char)0x87,
(char)0x90, (char)0x29, (char)0x5d, (char)0x29, (char)0x29, (char)0x00,
};
Alex Chernyakhovsky . resolved

pre-existing, but is there any particular reason this wasn't written as

```
const char b[] = "\x28\x05\x05...";
```

Paul Wankadia

This predated my tenure, but I ***believe*** it (or something very similar) was what we received for reproducing a fuzzer crash. Why that was written like this will probably never be known...

File re2/testing/tester.cc
Line 208, Patchset 1: << " mode: " << FormatMode(flags);
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 220, Patchset 1: ABSL_LOG(INFO) << "Prog for "

<< " regexp "
<< absl::CEscape(regexp_str_)
<< " (" << FormatKind(kind_)
<< ", " << FormatMode(flags_)
<< ")\n"
<< prog_->Dump();
}
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 233, Patchset 1: ABSL_LOG(INFO) << "Cannot reverse compile: " << absl::CEscape(regexp_str_);
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 370, Patchset 1: ABSL_LOG(ERROR) << "Reverse DFA inconsistency: "

<< absl::CEscape(regexp_str_)
<< " on " << absl::CEscape(text);
Alex Chernyakhovsky . resolved

indnetation

Paul Wankadia

Done

Line 524, Patchset 1: ABSL_LOG(ERROR) << "Skipped backtracking! " << absl::CEscape(regexp_str_)
<< " " << FormatMode(flags_);
return false;
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Line 528, Patchset 1: ABSL_VLOG(1) << "Try: regexp " << absl::CEscape(regexp_str_)

<< " text " << absl::CEscape(text)
<< " (" << FormatKind(kind_)
<< ", " << FormatAnchor(anchor)
<< ", " << FormatMode(flags_)
<< ")";
Alex Chernyakhovsky . resolved

indentation

Paul Wankadia

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Chernyakhovsky
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
Gerrit-Change-Number: 63092
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Wankadia <jun...@google.com>
Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
Gerrit-CC: Perry Lorier <per...@google.com>
Gerrit-Attention: Alex Chernyakhovsky <ache...@google.com>
Gerrit-Comment-Date: Mon, 20 May 2024 12:40:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alex Chernyakhovsky <ache...@google.com>
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
May 20, 2024, 9:01:11 AMMay 20
to Paul Wankadia, re2...@googlegroups.com
Attention needed from Paul Wankadia

Paul Wankadia uploaded new patchset

Paul Wankadia uploaded patch set #3 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Wankadia
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
Gerrit-Change-Number: 63092
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Wankadia <jun...@google.com>
Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
Gerrit-CC: Perry Lorier <per...@google.com>
Gerrit-Attention: Paul Wankadia <jun...@google.com>
unsatisfied_requirement
open
diffy

Paul Wankadia (Gerrit)

unread,
May 20, 2024, 9:01:49 AMMay 20
to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com
Attention needed from Alex Chernyakhovsky

Paul Wankadia added 30 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Paul Wankadia . resolved

Thanks! PTAL.

File re2/prog.h
Line 86, Patchset 1: int out1() { ABSL_DCHECK(opcode() == kInstAlt || opcode() == kInstAltMatch); return out1_; }

int cap() { ABSL_DCHECK_EQ(opcode(), kInstCapture); return cap_; }
int lo() { ABSL_DCHECK_EQ(opcode(), kInstByteRange); return lo_; }
int hi() { ABSL_DCHECK_EQ(opcode(), kInstByteRange); return hi_; }
int foldcase() { ABSL_DCHECK_EQ(opcode(), kInstByteRange); return hint_foldcase_&1; }
int hint() { ABSL_DCHECK_EQ(opcode(), kInstByteRange); return hint_foldcase_>>1; }
int match_id() { ABSL_DCHECK_EQ(opcode(), kInstMatch); return match_id_; }
EmptyOp empty() { ABSL_DCHECK_EQ(opcode(), kInstEmptyWidth); return empty_; }
Alex Chernyakhovsky . resolved

A bunch of these are over 80 chars. Admittedly some on the left-hand side already were.

Paul Wankadia

Done

File re2/regexp.h
Line 341, Patchset 1: const std::string* name() { ABSL_DCHECK_EQ(op_, kRegexpCapture); return name_; }
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

File re2/testing/dfa_test.cc
Line 115, Patchset 1: //ABSL_LOG(INFO) << "limit " << limit << ", "

// << "prog usage " << progusage << ", "
// << "DFA budget " << dfamem << ", "
// << "total " << usage;
Alex Chernyakhovsky . resolved

indentation? and or delete?

Paul Wankadia

Done

Line 193, Patchset 1: //ABSL_LOG(INFO) << "usage " << usage << ", "
// << "peak usage " << peak_usage;
Alex Chernyakhovsky . resolved

same here

Paul Wankadia

Done

Line 365, Patchset 1: ABSL_LOG(ERROR) << t.regexp << " dump:\ngot " << dump << "\nwant " << t.dump;
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

File re2/testing/regexp_benchmark.cc
Line 45, Patchset 1: ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . resolved

over 90 chars

Paul Wankadia

Done

Line 62, Patchset 1: // Can't pass mc.HeapGrowth() and mc.PeakHeapGrowth() to ABSL_LOG(INFO) directly,
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 77, Patchset 1: ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 870, Patchset 1: ABSL_CHECK_EQ(prog->SearchDFA(text, absl::string_view(), anchor,

Prog::kFirstMatch, NULL, &failed, NULL),
expect_match);
Alex Chernyakhovsky . resolved

indentation?

Paul Wankadia

Done

Line 887, Patchset 1: ABSL_CHECK_EQ(prog->SearchNFA(text, absl::string_view(), anchor,

Prog::kFirstMatch, NULL, 0),
expect_match);
Alex Chernyakhovsky . resolved

indentation?

Paul Wankadia

Done

Line 904, Patchset 1: ABSL_CHECK_EQ(prog->SearchOnePass(text, text, anchor, Prog::kFirstMatch, NULL, 0),
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 920, Patchset 1: ABSL_CHECK_EQ(prog->SearchBitState(text, text, anchor, Prog::kFirstMatch, NULL, 0),
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 922, Patchset 1: delete prog;
Alex Chernyakhovsky . resolved

optional: absl::WrapUnique on the output of CompileToProg (throughout)

Paul Wankadia

Fair call. I do indeed have strong feelpinions about cutting over to smart pointers for that, but given the proximity to `Decref()` calls, not strong enough... yet.

Line 946, Patchset 1: if (anchor == Prog::kAnchored)

ABSL_CHECK_EQ(RE2::FullMatch(text, re), expect_match);
else
ABSL_CHECK_EQ(RE2::PartialMatch(text, re), expect_match);
}
Alex Chernyakhovsky . resolved

optional: add the curly braces

Paul Wankadia

Done

Line 1031, Patchset 1: ABSL_CHECK_EQ(prog->SearchOnePass(text, text, anchor, Prog::kFirstMatch, NULL, 0),
expect_match);
}
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1042, Patchset 1: ABSL_CHECK_EQ(prog->SearchBitState(text, text, anchor, Prog::kFirstMatch, NULL, 0),
expect_match);
}
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1098, Patchset 1: ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1113, Patchset 1: ABSL_CHECK(prog->SearchBitState(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1127, Patchset 1: ABSL_CHECK(prog->UnsafeSearchBacktrack(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1169, Patchset 1: ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1179, Patchset 1: ABSL_CHECK(prog->SearchBitState(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1188, Patchset 1: ABSL_CHECK(prog->UnsafeSearchBacktrack(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 4));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1221, Patchset 1: ABSL_CHECK(prog->SearchNFA(text, absl::string_view(), Prog::kAnchored,

Prog::kFullMatch, sp, 2));
delete prog;
Alex Chernyakhovsky . resolved

indentation?

Paul Wankadia

Done

Line 1237, Patchset 1: ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 2));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1252, Patchset 1: ABSL_CHECK(prog->SearchBitState(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 2));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1294, Patchset 1: ABSL_CHECK(prog->SearchOnePass(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 2));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1304, Patchset 1: ABSL_CHECK(prog->SearchBitState(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 2));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1313, Patchset 1: ABSL_CHECK(prog->UnsafeSearchBacktrack(text, text, Prog::kAnchored, Prog::kFullMatch, sp, 2));
Alex Chernyakhovsky . resolved

over 80 chars

Paul Wankadia

Done

Line 1521, Patchset 1:void FullMatch_DotStarDollar_CachedPCRE(benchmark::State& state) { FullMatchPCRE(state, "(?s).*$"); }
void FullMatch_DotStarDollar_CachedRE2(benchmark::State& state) { FullMatchRE2(state, "(?s).*$"); }
Alex Chernyakhovsky . resolved

pre-existing over 80 chars

Paul Wankadia

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Chernyakhovsky
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
Gerrit-Change-Number: 63092
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Wankadia <jun...@google.com>
Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
Gerrit-CC: Perry Lorier <per...@google.com>
Gerrit-Attention: Alex Chernyakhovsky <ache...@google.com>
Gerrit-Comment-Date: Mon, 20 May 2024 13:01:42 +0000
unsatisfied_requirement
open
diffy

Alex Chernyakhovsky (Gerrit)

unread,
May 20, 2024, 9:05:11 AMMay 20
to Paul Wankadia, Perry Lorier, re2...@googlegroups.com
Attention needed from Paul Wankadia

Alex Chernyakhovsky voted and added 1 comment

Votes added by Alex Chernyakhovsky

Code-Review+1

1 comment

File re2/compile.cc
Line 526, Patchset 3 (Latest): ABSL_DCHECK(inst_[root].opcode() == kInstAlt ||
inst_[root].opcode() == kInstByteRange);
Alex Chernyakhovsky . unresolved

Found another indentation issue

Open in Gerrit

Related details

Attention is currently required from:
  • Paul Wankadia
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
    Gerrit-Change-Number: 63092
    Gerrit-PatchSet: 3
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Attention: Paul Wankadia <jun...@google.com>
    Gerrit-Comment-Date: Mon, 20 May 2024 13:05:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    May 20, 2024, 9:07:58 AMMay 20
    to Paul Wankadia, re2...@googlegroups.com
    Attention needed from Alex Chernyakhovsky and Paul Wankadia

    Paul Wankadia uploaded new patchset

    Paul Wankadia uploaded patch set #4 to this change.
    Following approvals got outdated and were removed:
    • Code-Review: +1 by Alex Chernyakhovsky
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Chernyakhovsky
    • Paul Wankadia
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: re2
      Gerrit-Branch: main
      Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
      Gerrit-Change-Number: 63092
      Gerrit-PatchSet: 4
      Gerrit-Owner: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
      Gerrit-CC: Perry Lorier <per...@google.com>
      Gerrit-Attention: Alex Chernyakhovsky <ache...@google.com>
      Gerrit-Attention: Paul Wankadia <jun...@google.com>
      unsatisfied_requirement
      open
      diffy

      Paul Wankadia (Gerrit)

      unread,
      May 20, 2024, 9:08:16 AMMay 20
      to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com
      Attention needed from Alex Chernyakhovsky

      Paul Wankadia added 1 comment

      File re2/compile.cc
      Line 526, Patchset 3: ABSL_DCHECK(inst_[root].opcode() == kInstAlt ||

      inst_[root].opcode() == kInstByteRange);
      Alex Chernyakhovsky . resolved

      Found another indentation issue

      Paul Wankadia

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alex Chernyakhovsky
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: re2
      Gerrit-Branch: main
      Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
      Gerrit-Change-Number: 63092
      Gerrit-PatchSet: 4
      Gerrit-Owner: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
      Gerrit-CC: Perry Lorier <per...@google.com>
      Gerrit-Attention: Alex Chernyakhovsky <ache...@google.com>
      Gerrit-Comment-Date: Mon, 20 May 2024 13:08:11 +0000
      unsatisfied_requirement
      open
      diffy

      Alex Chernyakhovsky (Gerrit)

      unread,
      May 20, 2024, 9:12:14 AMMay 20
      to Paul Wankadia, Perry Lorier, re2...@googlegroups.com
      Attention needed from Paul Wankadia

      Alex Chernyakhovsky voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Paul Wankadia
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: re2
        Gerrit-Branch: main
        Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
        Gerrit-Change-Number: 63092
        Gerrit-PatchSet: 4
        Gerrit-Owner: Paul Wankadia <jun...@google.com>
        Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
        Gerrit-CC: Perry Lorier <per...@google.com>
        Gerrit-Attention: Paul Wankadia <jun...@google.com>
        Gerrit-Comment-Date: Mon, 20 May 2024 13:12:08 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Paul Wankadia (Gerrit)

        unread,
        May 20, 2024, 9:13:02 AMMay 20
        to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

        Paul Wankadia voted Code-Review+2

        Code-Review+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: re2
        Gerrit-Branch: main
        Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
        Gerrit-Change-Number: 63092
        Gerrit-PatchSet: 4
        Gerrit-Owner: Paul Wankadia <jun...@google.com>
        Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
        Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
        Gerrit-CC: Perry Lorier <per...@google.com>
        Gerrit-Comment-Date: Mon, 20 May 2024 13:12:57 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Paul Wankadia (Gerrit)

        unread,
        May 20, 2024, 9:13:08 AMMay 20
        to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

        Paul Wankadia submitted the change

        Change information

        Commit message:
        Use the `ABSL_`-prefixed Abseil logging macros.

        This is done primarily for the sake of Chromium,
        which bans the unprefixed Abseil logging macros.

        I mostly baked the following slices of Perl pie:

        ```
        's,//absl/log:check",//absl/log:absl_check",'
        's,//absl/log",//absl/log:absl_log",'
        's,"absl/log/check.h","absl/log/absl_check.h",'
        's,"absl/log/log.h","absl/log/absl_log.h",'
        's,D?CHECK(_(EQ|NE|LE|LT|GE|GT))?\(,ABSL_$&,'
        's,V?LOG\(,ABSL_$&,'
        ```
        Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
        Reviewed-by: Paul Wankadia <jun...@google.com>
        Reviewed-by: Alex Chernyakhovsky <ache...@google.com>
        Delta: 49 files changed, 716 insertions(+), 624 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Alex Chernyakhovsky, +2 by Paul Wankadia
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: re2
        Gerrit-Branch: main
        Gerrit-Change-Id: I65493aff42abab6865f8e2b5b769b6a651dbef3a
        Gerrit-Change-Number: 63092
        Gerrit-PatchSet: 5
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages