[M] Change in code/re2[main]: Address some more `-Wsign-compare` warnings.

2 views
Skip to first unread message

Paul Wankadia (Gerrit)

unread,
Jun 20, 2024, 10:11:57 AM (13 days ago) Jun 20
to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded the change for review

Commit message

Address some more `-Wsign-compare` warnings.

Fixes #499.
Change-Id: I5405db7dff30ba84387c89a6064902f948b1ee3c

Change information

Files:
  • M re2/testing/filtered_re2_test.cc
  • M re2/testing/re2_test.cc
  • M re2/testing/regexp_test.cc
  • M re2/testing/set_test.cc
  • M re2/testing/string_generator_test.cc
Change size: M
Delta: 5 files changed, 63 insertions(+), 56 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: I5405db7dff30ba84387c89a6064902f948b1ee3c
Gerrit-Change-Number: 63370
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
unsatisfied_requirement
open
diffy

Alex Chernyakhovsky (Gerrit)

unread,
Jun 20, 2024, 10:29:30 AM (13 days ago) Jun 20
to Paul Wankadia, Perry Lorier, re2...@googlegroups.com
Attention needed from Paul Wankadia

Alex Chernyakhovsky voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Wankadia
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: I5405db7dff30ba84387c89a6064902f948b1ee3c
    Gerrit-Change-Number: 63370
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Attention: Paul Wankadia <jun...@google.com>
    Gerrit-Comment-Date: Thu, 20 Jun 2024 14:29:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    Jun 20, 2024, 10:30:24 AM (13 days ago) Jun 20
    to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: I5405db7dff30ba84387c89a6064902f948b1ee3c
    Gerrit-Change-Number: 63370
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Comment-Date: Thu, 20 Jun 2024 14:30:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    Jun 20, 2024, 10:30:27 AM (13 days ago) Jun 20
    to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia submitted the change

    Change information

    Commit message:
    Address some more `-Wsign-compare` warnings.

    Fixes #499.
    Change-Id: I5405db7dff30ba84387c89a6064902f948b1ee3c
    Reviewed-by: Alex Chernyakhovsky <ache...@google.com>
    Reviewed-by: Paul Wankadia <jun...@google.com>
    Files:
    • M re2/testing/filtered_re2_test.cc
    • M re2/testing/re2_test.cc
    • M re2/testing/regexp_test.cc
    • M re2/testing/set_test.cc
    • M re2/testing/string_generator_test.cc
    Change size: M
    Delta: 5 files changed, 63 insertions(+), 56 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Paul Wankadia, +1 by Alex Chernyakhovsky
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: I5405db7dff30ba84387c89a6064902f948b1ee3c
    Gerrit-Change-Number: 63370
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages