[XS] Change in code/re2[main]: CMakeLists.txt: fix dependencies for shared library build

3 views

Skip to first unread message

Russ Cox (Gerrit)

unread,

Jul 30, 2025, 2:54:28 PMJul 30

to Alan Donovan, re2...@googlegroups.com

Attention needed from Alan Donovan

Russ Cox has uploaded the change for review

Russ Cox would like Alan Donovan to review this change.

Commit message

CMakeLists.txt: fix dependencies for shared library build

There are a small number of references to the GoogleTest
package (for example TempDir) from re2/testing/*.cc, so
the testing library itself must depend on GoogleTest.
I removed this dependency incorrectly. Only the shared-library
build hits this problem.

Change-Id: Id48d106449f8023fd40330bfef179ab1dd1d4f45

Change information

Files:

M CMakeLists.txt

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Open in Gerrit

Related details

Attention is currently required from:

Alan Donovan

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Alan Donovan (Gerrit)

unread,

Jul 30, 2025, 3:29:36 PMJul 30

to Russ Cox, re2...@googlegroups.com

Attention needed from Russ Cox

Alan Donovan voted Code-Review+2

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Russ Cox

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Russ Cox (Gerrit)

unread,

Jul 30, 2025, 8:46:27 PMJul 30

to Alan Donovan, re2...@googlegroups.com

Russ Cox submitted the change

Change information

Commit message:

CMakeLists.txt: fix dependencies for shared library build

There are a small number of references to the GoogleTest
package (for example TempDir) from re2/testing/*.cc, so
the testing library itself must depend on GoogleTest.
I removed this dependency incorrectly. Only the shared-library
build hits this problem.

Change-Id: Id48d106449f8023fd40330bfef179ab1dd1d4f45

Reviewed-on: https://code-review.googlesource.com/c/re2/+/63791

Reviewed-by: Alan Donovan <adon...@google.com>

Files:

M CMakeLists.txt

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Alan Donovan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages