[S] Change in code/re2[abseil]: On macOS, Bazel doesn't use `BAZEL_CXXOPTS` unless told to eschew Xcode.

2 views
Skip to first unread message

Paul Wankadia (Gerrit)

unread,
Jul 15, 2022, 11:22:07 AM7/15/22
to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded this change for review.

View Change

On macOS, Bazel doesn't use `BAZEL_CXXOPTS` unless told to eschew Xcode.

Change-Id: Ia836e70dc7404e04c3cc09bc4a7e95ed5baab5a9
---
M .github/workflows/ci-bazel.yml
1 file changed, 11 insertions(+), 0 deletions(-)

diff --git a/.github/workflows/ci-bazel.yml b/.github/workflows/ci-bazel.yml
index b4a3fe9..81901b0 100644
--- a/.github/workflows/ci-bazel.yml
+++ b/.github/workflows/ci-bazel.yml
@@ -13,6 +13,8 @@
       BAZELISK_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       # Abseil requires C++14 at minimum.
       BAZEL_CXXOPTS: ${{ startsWith(matrix.os, 'windows-') && '/std:c++14' || '-std=c++14' }}
+      # On macOS, Bazel doesn't use `BAZEL_CXXOPTS` unless told to eschew Xcode.
+      BAZEL_USE_CPP_ONLY_TOOLCHAIN: 1
     steps:
       - uses: actions/checkout@v2
       - run: .github/bazel.sh

To view, visit change 60273. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: re2
Gerrit-Branch: abseil
Gerrit-Change-Id: Ia836e70dc7404e04c3cc09bc4a7e95ed5baab5a9
Gerrit-Change-Number: 60273
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
Gerrit-MessageType: newchange

Miguel Young de la Sota (Gerrit)

unread,
Jul 15, 2022, 1:37:32 PM7/15/22
to Paul Wankadia, Perry Lorier, Randall Bosetti, re2...@googlegroups.com

Attention is currently required from: Paul Wankadia, Perry Lorier.

Patch set 1:Code-Review +1

View Change

    To view, visit change 60273. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: re2
    Gerrit-Branch: abseil
    Gerrit-Change-Id: Ia836e70dc7404e04c3cc09bc4a7e95ed5baab5a9
    Gerrit-Change-Number: 60273
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Miguel Young de la Sota <mcy...@google.com>
    Gerrit-Reviewer: Perry Lorier <per...@google.com>
    Gerrit-CC: Randall Bosetti <r...@google.com>
    Gerrit-Attention: Perry Lorier <per...@google.com>
    Gerrit-Attention: Paul Wankadia <jun...@google.com>
    Gerrit-Comment-Date: Fri, 15 Jul 2022 17:37:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Paul Wankadia (Gerrit)

    unread,
    Jul 15, 2022, 1:37:46 PM7/15/22
    to Paul Wankadia, Miguel Young de la Sota, Perry Lorier, Randall Bosetti, re2...@googlegroups.com

    Attention is currently required from: Perry Lorier.

    Patch set 1:Code-Review +2

    View Change

      To view, visit change 60273. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: re2
      Gerrit-Branch: abseil
      Gerrit-Change-Id: Ia836e70dc7404e04c3cc09bc4a7e95ed5baab5a9
      Gerrit-Change-Number: 60273
      Gerrit-PatchSet: 1
      Gerrit-Owner: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Miguel Young de la Sota <mcy...@google.com>
      Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
      Gerrit-Reviewer: Perry Lorier <per...@google.com>
      Gerrit-CC: Randall Bosetti <r...@google.com>
      Gerrit-Attention: Perry Lorier <per...@google.com>
      Gerrit-Comment-Date: Fri, 15 Jul 2022 17:37:41 +0000

      Paul Wankadia (Gerrit)

      unread,
      Jul 15, 2022, 1:37:49 PM7/15/22
      to Paul Wankadia, Miguel Young de la Sota, Perry Lorier, Randall Bosetti, re2...@googlegroups.com

      Paul Wankadia submitted this change.

      View Change


      Approvals: Miguel Young de la Sota: Looks good to me, but someone else must approve Paul Wankadia: Looks good to me, approved 
      On macOS, Bazel doesn't use `BAZEL_CXXOPTS` unless told to eschew Xcode.

      Change-Id: Ia836e70dc7404e04c3cc09bc4a7e95ed5baab5a9
      Reviewed-on: https://code-review.googlesource.com/c/re2/+/60273
      Reviewed-by: Miguel Young de la Sota <mcy...@google.com>
      Reviewed-by: Paul Wankadia <jun...@google.com>
      ---
      M .github/workflows/ci-bazel.yml
      1 file changed, 14 insertions(+), 0 deletions(-)

      

      diff --git a/.github/workflows/ci-bazel.yml b/.github/workflows/ci-bazel.yml
      index b4a3fe9..81901b0 100644
      --- a/.github/workflows/ci-bazel.yml
      +++ b/.github/workflows/ci-bazel.yml
      @@ -13,6 +13,8 @@
             BAZELISK_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
             # Abseil requires C++14 at minimum.
             BAZEL_CXXOPTS: ${{ startsWith(matrix.os, 'windows-') && '/std:c++14' || '-std=c++14' }}
      +      # On macOS, Bazel doesn't use `BAZEL_CXXOPTS` unless told to eschew Xcode.
      +      BAZEL_USE_CPP_ONLY_TOOLCHAIN: 1
           steps:
             - uses: actions/checkout@v2
             - run: .github/bazel.sh

      To view, visit change 60273. To unsubscribe, or for help writing mail filters, visit settings.
      


       Gerrit-Project: re2 
      

       Gerrit-Branch: abseil 
      

       Gerrit-Change-Id: Ia836e70dc7404e04c3cc09bc4a7e95ed5baab5a9 
      

       Gerrit-Change-Number: 60273 
      

       Gerrit-PatchSet: 2 
      

       Gerrit-Owner: Paul Wankadia <jun...@google.com> 
      

       Gerrit-Reviewer: Miguel Young de la Sota <mcy...@google.com> 
      

       Gerrit-Reviewer: Paul Wankadia <jun...@google.com> 
      

       Gerrit-Reviewer: Perry Lorier <per...@google.com> 
      

       Gerrit-CC: Randall Bosetti <r...@google.com> 
      

       Gerrit-MessageType: merged 
      


      Reply all
      Reply to author
      Forward
      0 new messages