[S] Change in code/re2[main]: Switch to vcpkg for dependencies.

2 views
Skip to first unread message

Paul Wankadia (Gerrit)

unread,
May 17, 2024, 1:53:25 PMMay 17
to Paul Wankadia, re2...@googlegroups.com

Paul Wankadia has uploaded the change for review

Commit message

Switch to vcpkg for dependencies.

Ubuntu ships very old versions and it's cramping my style.
(In particular, I want to be able to use Abseil logging.)

While I'm here, add GCC 14 to the build matrix.

... and remove GCC 11 so that we continue to
test with only the three most recent releases.
Change-Id: If7eb226005d8d9e56d3523e6e255d29814646d10

Change information

Files:
  • M .github/workflows/ci-cmake.yml
  • M .github/workflows/ci.yml
Change size: S
Delta: 2 files changed, 14 insertions(+), 17 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: If7eb226005d8d9e56d3523e6e255d29814646d10
Gerrit-Change-Number: 63070
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Wankadia <jun...@google.com>
unsatisfied_requirement
open
diffy

Alex Chernyakhovsky (Gerrit)

unread,
May 17, 2024, 2:02:00 PMMay 17
to Paul Wankadia, Perry Lorier, re2...@googlegroups.com
Attention needed from Paul Wankadia

Alex Chernyakhovsky voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Wankadia
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: If7eb226005d8d9e56d3523e6e255d29814646d10
    Gerrit-Change-Number: 63070
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Attention: Paul Wankadia <jun...@google.com>
    Gerrit-Comment-Date: Fri, 17 May 2024 18:01:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    May 17, 2024, 2:03:48 PMMay 17
    to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: If7eb226005d8d9e56d3523e6e255d29814646d10
    Gerrit-Change-Number: 63070
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Wankadia <jun...@google.com>
    Gerrit-Reviewer: Alex Chernyakhovsky <ache...@google.com>
    Gerrit-Reviewer: Paul Wankadia <jun...@google.com>
    Gerrit-CC: Perry Lorier <per...@google.com>
    Gerrit-Comment-Date: Fri, 17 May 2024 18:03:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Paul Wankadia (Gerrit)

    unread,
    May 17, 2024, 2:03:51 PMMay 17
    to Paul Wankadia, Alex Chernyakhovsky, Perry Lorier, re2...@googlegroups.com

    Paul Wankadia submitted the change

    Change information

    Commit message:
    Switch to vcpkg for dependencies.

    Ubuntu ships very old versions and it's cramping my style.
    (In particular, I want to be able to use Abseil logging.)

    While I'm here, add GCC 14 to the build matrix.

    ... and remove GCC 11 so that we continue to
    test with only the three most recent releases.
    Change-Id: If7eb226005d8d9e56d3523e6e255d29814646d10
    Reviewed-by: Alex Chernyakhovsky <ache...@google.com>
    Reviewed-by: Paul Wankadia <jun...@google.com>
    Files:
    • M .github/workflows/ci-cmake.yml
    • M .github/workflows/ci.yml
    Change size: S
    Delta: 2 files changed, 14 insertions(+), 17 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Alex Chernyakhovsky, +2 by Paul Wankadia
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: re2
    Gerrit-Branch: main
    Gerrit-Change-Id: If7eb226005d8d9e56d3523e6e255d29814646d10
    Gerrit-Change-Number: 63070
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages