[S] Change in code/re2[main]: re2: churn to new Abseil

0 views
Skip to first unread message

Russ Cox (Gerrit)

unread,
Sep 29, 2025, 10:12:55 AM (4 days ago) Sep 29
to Alan Donovan, re2...@googlegroups.com
Attention needed from Alan Donovan

Russ Cox has uploaded the change for review

Russ Cox would like Alan Donovan to review this change.

Commit message

re2: churn to new Abseil

Recent Abseil introduced a MutexLock constructor taking a
reference instead of a pointer and then immediately marked
the pointer one deprecated, causing deprecation errors/warnings
for users. Update to the new Abseil and change to references.
Change-Id: Id9436a79789b5700bbe883f4ee1de99b32e0d3e1

Change information

Files:
  • M CMakeLists.txt
  • M MODULE.bazel
  • M re2/dfa.cc
  • M re2/regexp.cc
  • M re2/testing/regexp_benchmark.cc
Change size: S
Delta: 5 files changed, 13 insertions(+), 13 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
Submit Requirements:
  • requirement is blockingCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Id9436a79789b5700bbe883f4ee1de99b32e0d3e1
Gerrit-Change-Number: 64030
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
blocking_requirement
unsatisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
Sep 29, 2025, 10:14:11 AM (4 days ago) Sep 29
to Russ Cox, re2...@googlegroups.com
Attention needed from Russ Cox

Alan Donovan voted and added 1 comment

Votes added by Alan Donovan

Code-Review+2

1 comment

Commit Message
Line 11, Patchset 1 (Latest):the pointer one deprecated, causing deprecation errors/warnings
Alan Donovan . unresolved

Actual errors? How is such a change acceptable?

Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Id9436a79789b5700bbe883f4ee1de99b32e0d3e1
Gerrit-Change-Number: 64030
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Attention: Russ Cox <r...@swtch.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 14:14:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Sep 29, 2025, 10:15:24 AM (4 days ago) Sep 29
to Alan Donovan, re2...@googlegroups.com

Russ Cox added 1 comment

Commit Message
Line 11, Patchset 1 (Latest):the pointer one deprecated, causing deprecation errors/warnings
Alan Donovan . resolved

Actual errors? How is such a change acceptable?

Russ Cox

I don't think it was stopping builds but it was causing Googlers to send me patches, which is almost as bad. :-)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Id9436a79789b5700bbe883f4ee1de99b32e0d3e1
Gerrit-Change-Number: 64030
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 14:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alan Donovan <adon...@google.com>
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Sep 29, 2025, 10:15:41 AM (4 days ago) Sep 29
to Alan Donovan, re2...@googlegroups.com

Russ Cox added 1 comment

Commit Message
Line 11, Patchset 1 (Latest):the pointer one deprecated, causing deprecation errors/warnings
Alan Donovan . resolved

Actual errors? How is such a change acceptable?

Russ Cox

I don't think it was stopping builds but it was causing Googlers to send me patches, which is almost as bad. :-)

Russ Cox

Actually I take it back, bots were sending me patches, which is worse.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Id9436a79789b5700bbe883f4ee1de99b32e0d3e1
Gerrit-Change-Number: 64030
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 14:15:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Russ Cox <r...@swtch.com>
Comment-In-Reply-To: Alan Donovan <adon...@google.com>
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Sep 29, 2025, 11:58:21 AM (4 days ago) Sep 29
to Alan Donovan, re2...@googlegroups.com

Russ Cox submitted the change

Change information

Commit message:
re2: churn to new Abseil

Recent Abseil introduced a MutexLock constructor taking a
reference instead of a pointer and then immediately marked
the pointer one deprecated, causing deprecation errors/warnings
for users. Update to the new Abseil and change to references.
Change-Id: Id9436a79789b5700bbe883f4ee1de99b32e0d3e1
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
  • M CMakeLists.txt
  • M MODULE.bazel
  • M re2/dfa.cc
  • M re2/regexp.cc
  • M re2/testing/regexp_benchmark.cc
Change size: S
Delta: 5 files changed, 13 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Alan Donovan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: re2
Gerrit-Branch: main
Gerrit-Change-Id: Id9436a79789b5700bbe883f4ee1de99b32e0d3e1
Gerrit-Change-Number: 64030
Gerrit-PatchSet: 2
Gerrit-Owner: Russ Cox <r...@swtch.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Russ Cox <r...@swtch.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages