[S] Change in code/re2[main]: re2: churn to new Abseil
4 views
Skip to first unread message
Russ Cox (Gerrit)
Sep 29, 2025, 10:12:55 AMSep 29
to Alan Donovan, re2...@googlegroups.com
Attention needed from Alan Donovan
Russ Cox has uploaded the change for review![]( "Open in Gerrit")
Russ Cox would like Alan Donovan to review this change.
Commit message
re2: churn to new Abseil
Recent Abseil introduced a MutexLock constructor taking a
reference instead of a pointer and then immediately marked
the pointer one deprecated, causing deprecation errors/warnings
for users. Update to the new Abseil and change to references.
Change-Id: Id9436a79789b5700bbe883f4ee1de99b32e0d3e1
Change information
Files:
- M CMakeLists.txt
- M MODULE.bazel
- M re2/dfa.cc
- M re2/regexp.cc
- M re2/testing/regexp_benchmark.cc
Change size: S
Delta: 5 files changed, 13 insertions(+), 13 deletions(-)
Related details
Attention is currently required from:
- Alan Donovan
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
Sep 29, 2025, 10:14:11 AMSep 29
to Russ Cox, re2...@googlegroups.com
Attention needed from Russ Cox
Alan Donovan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alan Donovan
| Code-Review | +2 |
1 comment
Commit Message
Line 11, Patchset 1 (Latest):
the pointer one deprecated, causing deprecation errors/warningsAlan Donovan . unresolved
Actual errors? How is such a change acceptable?
Related details
Attention is currently required from:
- Russ Cox
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
Sep 29, 2025, 10:15:24 AMSep 29
to Alan Donovan, re2...@googlegroups.com
Russ Cox added 1 comment![]( "Open in Gerrit")
Commit Message
Line 11, Patchset 1 (Latest):
the pointer one deprecated, causing deprecation errors/warningsAlan Donovan . resolved
Actual errors? How is such a change acceptable?
Russ Cox
I don't think it was stopping builds but it was causing Googlers to send me patches, which is almost as bad. :-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
Sep 29, 2025, 10:15:41 AMSep 29
to Alan Donovan, re2...@googlegroups.com
Russ Cox added 1 comment![]( "Open in Gerrit")
Commit Message
Line 11, Patchset 1 (Latest):
the pointer one deprecated, causing deprecation errors/warningsAlan Donovan . resolved
Russ CoxActual errors? How is such a change acceptable?
I don't think it was stopping builds but it was causing Googlers to send me patches, which is almost as bad. :-)
Russ Cox
Actually I take it back, bots were sending me patches, which is worse.
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
Sep 29, 2025, 11:58:21 AMSep 29
to Alan Donovan, re2...@googlegroups.com
Russ Cox submitted the change![]( "Open in Gerrit")
Change information
Commit message:
re2: churn to new Abseil
Recent Abseil introduced a MutexLock constructor taking a
reference instead of a pointer and then immediately marked
the pointer one deprecated, causing deprecation errors/warnings
for users. Update to the new Abseil and change to references.
Change-Id: Id9436a79789b5700bbe883f4ee1de99b32e0d3e1
Reviewed-on: https://code-review.googlesource.com/c/re2/+/64030
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
- M CMakeLists.txt
- M MODULE.bazel
- M re2/dfa.cc
- M re2/regexp.cc
- M re2/testing/regexp_benchmark.cc
Change size: S
Delta: 5 files changed, 13 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Alan Donovan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
basheer abdullah (Gerrit)
Oct 5, 2025, 12:13:10 AMOct 5
to Russ Cox, Alan Donovan, re2...@googlegroups.com
basheer abdullah voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages