Russ Cox would like Alan Donovan to review this change.
re2: churn to new Abseil
Recent Abseil introduced a MutexLock constructor taking a
reference instead of a pointer and then immediately marked
the pointer one deprecated, causing deprecation errors/warnings
for users. Update to the new Abseil and change to references.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +2 |
the pointer one deprecated, causing deprecation errors/warnings
Actual errors? How is such a change acceptable?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
the pointer one deprecated, causing deprecation errors/warnings
Actual errors? How is such a change acceptable?
I don't think it was stopping builds but it was causing Googlers to send me patches, which is almost as bad. :-)
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
the pointer one deprecated, causing deprecation errors/warnings
Russ CoxActual errors? How is such a change acceptable?
I don't think it was stopping builds but it was causing Googlers to send me patches, which is almost as bad. :-)
Actually I take it back, bots were sending me patches, which is worse.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
re2: churn to new Abseil
Recent Abseil introduced a MutexLock constructor taking a
reference instead of a pointer and then immediately marked
the pointer one deprecated, causing deprecation errors/warnings
for users. Update to the new Abseil and change to references.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |