Responder Test GET/SET_DMX_FAIL_MODE

[Jens G]

Hi,

I'm using OLA 0.10.7 with linux and rdm_test_server.py.

My responder test fails after GET DMX_FAIL_MODE in SET DMX_FAIL_MODE with no changes between GET and SET.

I found in a serial logfile that OLA has a bug in this test, in SET it swappes the checked values for loss_delay_time and hold_time.

GET:

Result: Passed

GET: uid: 4c53:53030001, pid: DMX_FAIL_MODE (0x0141), sub device: 0, args: []
Response: RDMResponse(type=ACK, command_class=GET), PID: 0x0141, TN: 183, PDL: 7, data: {'scene_number': 0, 'hold_time': 0.0, 'loss_of_signal_delay': 6553.5, 'level': 255}

GET param bytes : 00 00   FF FF   00 00   FF

SET:

Result: Failed

SET: uid: 4c53:53030001, pid: DMX_FAIL_MODE (0x0141), sub device: 0, args: [0, 0.0, 6553.5, 255]
Response: RDMResponse(type=NACK, reason="Data out of range"), PID: 0x0141, TN: 209
Failed: expected one of:
CC: Set, PID 0x0141, NACK RDMNack(value=4, desc="Write protect")
CC: Set, PID 0x0141, ACK, fields [], values {}
CC: Set, PID 0x0141, NACK RDMNack(value=5, desc="Unsupported command class")

OLA sends SET param bytes : 00 00   00 00   FF FF   FF

So the test must fail.

Bye,

Jens