best way to submit a patch ?

[Gabriel Somlo]

Hi,

I was wondering what the best way might be to propose an rdesktop patch?

I tried a pull request via GitHub (https://github.com/rdesktop/rdesktop/pull/23),
but I know other projects ignore those and prefer to have patches emailed to
their mailing lists instead.

Thanks for any ideas!
Regards,
--Gabriel

[Henrik Andersson]

Hi,

>
> I was wondering what the best way might be to propose an rdesktop
> patch?
>

A pull request through github is preferred.

> I tried a pull request via GitHub
> (https://github.com/rdesktop/rdesktop/pull/23),
> but I know other projects ignore those and prefer to have patches
> emailed to their mailing lists instead.

I looked into this PR when created but had not made up my mind yet how
to go further. However it is now handled.


Best Regards,

Henrik Andersson

[puteshestvuushij]

Hi,

Just want to inform about an unpleasant issue with rdesktop.

When I lost internet connection and rdesktop was in fullscreen mode I wasn't able to close the rdesktop window (CTRL+ALT+ENTER didn't help). Then I tried to switch to other linux windows using ALT+TAB hoping that I can leave rdesktop and close it later. I was able to select the desired window during switching but I was switched back to rdesktop window which as I said was in fullscreen mode. So I saw no other way than to restart the PC.

I use Kubuntu and
Version 1.7.1. Copyright (C) 1999-2011 Matthew Chapman et al. of rdesktop

Regards
Denis

[Henrik Andersson]

Hi,

>
> When I lost internet connection and rdesktop was in fullscreen mode I
> wasn't able to close the rdesktop window (CTRL+ALT+ENTER didn't
> help). Then I tried to switch to other linux windows using ALT+TAB
> hoping that I can leave rdesktop and close it later. I was able to
> select the desired window during switching but I was switched back to
> rdesktop window which as I said was in fullscreen mode. So I saw no
> other way than to restart the PC.
>

That is a known issue with rdesktop due to how it is internall designed.
We have an issue #17 [1] for this bug. You could try compile rdesktop
from source to get commit 2a6298a which implements WM_PING. WM_PING is
used by the WM (Window Manager) to check if an application is alive and
usally present a dialog to give a choice to wait or terminate the hung
application.


[1] https://github.com/rdesktop/rdesktop/issues/17


Kind Regards,

Henrik Andersson