-- @@@@@ VAR in the razorqt-session/config/CMakeLists.txt: razor-session;razor-sessioncfg-- @@@@@ VAR in the razorqt-session/CMakeLists.txt: razor-session
--
You received this message because you are subscribed to the Google
Groups "Razor-qt" group.
For more options, visit this group at
http://groups.google.com/group/razor-qt?hl=en
As you can see in razorqt-session/config/CMakeLists.txt variable have cumulative value. This may create errors, which would be difficult to detect. So let's use ${PROJECT_NAME}_XXX_FILES
So for a dynamic library it can be:
${PROJECT_NAME}_H_FILES
${PROJECT_NAME}_PRIVATE_H_FILES
${PROJECT_NAME}_PUBLIC_H_FILES
I prefer no prefixes. TS_FILES, QM_FILES,.. as you suggest would be fine with me.
On Wed, Jul 18, 2012 at 4:20 AM, Александр Соколов <sokol...@gmail.com> wrote:As you can see in razorqt-session/config/CMakeLists.txt variable have cumulative value. This may create errors, which would be difficult to detect. So let's use ${PROJECT_NAME}_XXX_FILESThis are better, thantOn Tue, Jul 17, 2012 at 9:10 PM, Kuzma Shapran <leaf.o...@gmail.com> wrote:So for a dynamic library it can be:${PROJECT_NAME}_H_FILES${PROJECT_NAME}_PRIVATE_H_FILES${PROJECT_NAME}_PUBLIC_H_FILESI dont think so that's necesary.. and i think "PROJECT_NAME" must be "MODULE_NAME" due i think the main proyect are RAZORQT, or so MAIN_PROJECT and SUBPROJECT could also.. but directly PROJECT_NAME may be confusing
2012/7/18 chri...@surlykke.dk <chri...@surlykke.dk>I prefer no prefixes. TS_FILES, QM_FILES,.. as you suggest would be fine with me.+1 to u, better no prefixes--
Lenz McKAY Gerardo (PICCORO)
http://qgqlochekone.blogspot.com
Cofundador de Venenux; debian based multimedia alike free only zealots users (oh well, i try but..too many free guidelines buahhh)
http://shutendouji.net
creador de massenkoh linux; debian enhanchements for better up to date support on stable brand, including non-free soft.
--
You received this message because you are subscribed to the Google
Groups "Razor-qt" group.
For more options, visit this group at
http://groups.google.com/group/razor-qt?hl=en
prefixes are mandatory. That's what I said - variables are inherited ;)
Also (I think) it's much more readable to have FOO_HEADERS than ${PROJECT}_HEADERS.
That are my 2c...
On Tuesday, July 17, 2012 7:06:15 PM UTC+2, Alexander Sokolov wrote:We have a crazy situation with the cmake files. All files have their own style of naming variables. Here is a variants of the variable names for .h files.
- razor-appswitcher_HDRS
- razor-policykit-agent_H
- ${PROJECT_NAME} _HEADERS
- H_FILES
- HEADERS
- razorqxt_PUBLIC_HDRS and razorqxt_PRIVATE_HDRS
- QTXDG_PUBLIC_HDRS and QTXDG_PRIVATE_HDRS
- HW_HEADERS
I suggest to choose one style and describe it in the wiki.Do we need prefixes? Cmake documentation says: "Each new directory or function creates a new scope." Therefore, the two programs will be have independent variables, but I'm not sure about the nested directory, like:
razorqt-session
CMakeLists.txt
/config
CMakeLists.txt
I like the style of H_FILES (or ${PROJECT_NAME} _H_FILES if prefix is needed)
This allows to have a single style for different files: TS_FILES, QM_FILES, MOC_FILES, QRC_FILES, and so on.
Any Ideas.
--
You received this message because you are subscribed to the Google
Groups "Razor-qt" group.
For more options, visit this group at
http://groups.google.com/group/razor-qt?hl=en
Also (I think) it's much more readable to have FOO_HEADERS than ${PROJECT}_HEADERS.