Json.net update

45 views
Skip to first unread message

asgerhallas

unread,
Oct 26, 2011, 4:42:29 AM10/26/11
to ravendb
Hi

I see there's a commit log saying "Reverting to Json.Net 4.0.2" on
october 5th.

What are the reasons it was not upgraded to 4.0.3?
And what are the time frame before it will be updated?

I'm in desperate need of some of the new features in the new release,
so I'm thinking if it is possible to to do the upgrade myself. But if
it's known to be troublesome or impossible, I'd like to know :)

//Asger

Itamar Syn-Hershko

unread,
Oct 26, 2011, 6:08:44 AM10/26/11
to rav...@googlegroups.com
We had some failing tests, I think they all stem from 1 or 2 issues in Raven.Json, but we preferred putting efforts on other stuff for now.

Nick

unread,
Oct 26, 2011, 3:25:14 PM10/26/11
to ravendb
Not being able to upgrade to 4.0.3 is also an issue here.
For instance, I can't install the TweetSharp nuget package which uses
4.0.3.
Unless there is a way to install nuget packages that demand different
versions of a certain dependency?

On Oct 26, 6:08 am, Itamar Syn-Hershko <ita...@hibernatingrhinos.com>
wrote:

Nick

unread,
Oct 26, 2011, 9:30:07 PM10/26/11
to ravendb

asgerhallas

unread,
Nov 3, 2011, 6:08:17 AM11/3/11
to ravendb
I have submitted a pull request for this: https://github.com/ravendb/ravendb/pull/396

//Asger

On Oct 27, 2:30 am, Nick <cadil...@gmail.com> wrote:
> Reported at165http://stackoverflow.com/questions/7908760/nuget-package-dependencies...
> Could be a bug of nuget...
>
> On Oct 26, 3:25 pm, Nick <cadil166...@gmail.com> wrote:
>
> 167168
>
> 169
>
>
>
> > Not being able to upgrade to 4.0.3 is also an issue here.
> > For instance, I can't install the TweetSharp nuget package which uses
> > 4.0.3.
> > Unless there is a way to install nuget packages that demand different
> > versions of a certain dependency?
>
> > On Oct 26, 6:08 am, Itamar Syn-Hershko <ita170...@hibernatingrhinos.com>
> > wrote:
>
> > > We had some failing tests, I think they all stem from 1 or 2 issues in
> > > Raven.Json, but we preferred putting efforts on other stuff for now.
>

Itamar Syn-Hershko

unread,
Nov 3, 2011, 6:36:04 AM11/3/11
to rav...@googlegroups.com
Looks good, thanks.

I assume the changes to Raven.Json were made using diffs to the Json.Net original files?

asgerhallas

unread,
Nov 3, 2011, 7:24:17 AM11/3/11
to ravendb
Yes exactly. Though I did only copy over what fitted in. E.g. I did
not implement the WriteValue() overloads for Guid? and TimeSpan? as
that did not seem to be done for any of the other nullables.

But I see now that I missed using tabs for indention - and I missed
implementing the changes to JsonWriter.Compare(). That last one I
guess could be severe, though it did not break any tests.

I'll commit an update.

//Asger

On Nov 3, 11:36 am, Itamar Syn-Hershko <ita...@hibernatingrhinos.com>
wrote:
> Looks good, thanks.
>
> I assume the changes to Raven.Json were made using diffs to the Json.Net
> original files?
>
> 224https://github.com/asgerhallas/ravendb/commit/a318c6ab3b044f5ed6d9614...
>
> 225226
>
> 227
>
>
>
> On Thu, Nov 3, 2011 at 12:08 PM, asgerhallas <asgerhal228...@gmail.com> wrote:
> > I have submitted a pull request for this:
> >229https://github.com/ravendb/ravendb/pull/396
>
> > //Asger
>
> > On Oct 27, 2:30 am, Nick <cadil230...@gmail.com> wrote:
> > > Reported at165
> >231http://stackoverflow.com/questions/7908760/nuget-package-dependencies...
> > > Could be a bug of nuget...
>
> > > On Oct 26, 3:25 pm, Nick <cadil166232...@gmail.com> wrote:
>
> > > 167168
>
> > > 169
>
> > > > Not being able to upgrade to 4.0.3 is also an issue here.
> > > > For instance, I can't install the TweetSharp nuget package which uses
> > > > 4.0.3.
> > > > Unless there is a way to install nuget packages that demand different
> > > > versions of a certain dependency?
>
> > > > On Oct 26, 6:08 am, Itamar Syn-Hershko <
> > ita170233...@hibernatingrhinos.com>
Reply all
Reply to author
Forward
0 new messages