Client side Guid (string)

[Luke Eccleston]

Hi

Was reading this https://ravendb.net/docs/article-page/5.0/Csharp/server/kb/document-identifier-generation

but is it ok to generate the Guids client side and then tostring them? like so 

public abstract class Entity
{
     public string Id { get; set; }

     protected Entity()

     {
        Id = Guid.NewGuid().ToString();
     }
}

Cheers

Luke

[Ivan Montilla]

I think this is a anti-pattern. I have in all my entities Id property with private setter, and I never set it directly from constructor or from entity, I let the session to assign the ID.

I check if an instance of entity is stored in DB checking if Id property is null. If you want to store with GUID, you can create an extension method to session called StoreWithGuid that create a new Guid and set it to the entity.

[Luke Eccleston]

Hi

That was just an example. I want the Id to be generated before session store and to be a Guid.ToString().

[Nik]

It's ok to have it in the constructor. During the conversion from document to an entity the value will be overwritten (you need a private setter at least).

Whether you'll set a random GUID in the constructor, pass it as a constructor parameter or let the session handle it, that depends on your app architecture requirements.

[Oren Eini (Ayende Rahien)]

There is no issue here, aside from my dislike of guids in general.

Note that you can get a human readable id without going to the server. 

See also:

https://ravendb.net/learn/inside-ravendb-book/reader/4.0/2-zero-to-ravendb#document-identifiers-in-ravendb

--
You received this message because you are subscribed to the Google Groups "RavenDB - 2nd generation document database" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ravendb+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ravendb/842c834c-93f5-43e5-9e25-8c3ca0d2d54fn%40googlegroups.com.

--

Oren Eini CEO   /   Hibernating Rhinos LTD Mobile:  972-52-548-6969 Sales:  sa...@ravendb.net Skype:  ayenderahien Support:  sup...@ravendb.net