Class inheritance change in 2.5.3-SNAPSHOT

[Phil Gates-Idem]

The _inherit function in raptor.js was copying properties from base class constructor to derived class constructor and it was clobbering some of the properties (such as "static" functions) that were in the derived class.

I made this change:

-            extend(clazz,inherit);

+            for (var key in inherit) {

+                // don't use extend because we should only copy properties

+                // that don't exist on target clazz

+                if (inherit.hasOwnProperty(key) && (clazz[key] === undefined)) {

+                    clazz[key] = inherit[key];

+                }

+            }

This is just an FYI. I don't think it will break anything

[Patrick Steele-Idem]

Hmm... why are we even copying properties from the superclass constructor to the derived constructor? Seems like we should just delete those lines altogether... I'm not sure why I added it to begin with.

--
You received this message because you are subscribed to the Google Groups "RaptorJS" group.
To unsubscribe from this group and stop receiving emails from it, send an email to raptorjs+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Phil Gates-Idem]

I think they should be removed as well.