Highlighting tab when links_to_remote used

[Jiří Popek]

Hi, I found a little bug with highlighting the active tab. Active tab
is not highlighed after user click on it and tab reloads its content.
This is only when links_to_remote is used in tab definition. It works
fine when using links_to.

There is problem with "each".
Quick fix is to change lib/widgets/tabnav_helper.rb:92 to

success = "var actives = document.getElementsByClassName('active', $
('" + @tabnav.html[:id]+ "')); for(var i=0; i<actives.length; i++)
{ actives[i].removeClassName('active'); };"

[Paolo Donà]

Thanks mate,
can you fork the project on github and commit your change?
Paolo

> --
> You received this message because you are subscribed to the Google Groups "Rails Widgets Dev" group.
> To post to this group, send email to rails-wi...@googlegroups.com.
> To unsubscribe from this group, send email to rails-widgets-...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/rails-widgets-dev?hl=en.
>
>

--
Paolo Dona' | http://paolodona.com

[Jiří Popek]

Sure, if I have enough rights to push it in.

J.

[Paolo Donà]

you push it to your repo, then send a pull request to me
Paolo

[Jiří Popek]

Ok, thanks - I am new to git so It will take some time, but I will definitely check that.

J.

[Paolo Donà]

good cheers.
Paolo

[Jiří Popek]

Hmmm - can not find how to send a pull request, could you point me to the doc, please?

Here is at least a patch attached.

J.

[Paolo Donà]

See the attached screenshot
Paolo

[Jiří Popek]

Thanks,

but unfortunately there is no button "Pull request" when I am logged
in

On Aug 2, 5:26 pm, Paolo Donà <paolo.d...@gmail.com> wrote:
> See the attached screenshot
> Paolo
>
>
>
>
>
> On Mon, Aug 2, 2010 at 2:55 PM, Jiří Popek <jiri.po...@gmail.com> wrote:
> > Hmmm - can not find how to send a pull request, could you point me to the
> > doc, please?
> > Here is at least a patch attached.
> > J.
>

> > On Mon, Aug 2, 2010 at 3:36 PM, Paolo Donà <paolo.d...@gmail.com> wrote:
>
> >> good cheers.
> >> Paolo
>

> >> On Mon, Aug 2, 2010 at 2:33 PM, Jiří Popek <jiri.po...@gmail.com> wrote:
> >> > Ok, thanks - I am new to git so It will take some time, but I will
> >> > definitely check that.
> >> > J.
>

> >> > On Mon, Aug 2, 2010 at 3:31 PM, Paolo Donà <paolo.d...@gmail.com> wrote:
>
> >> >> you push it to your repo, then send a pull request to me
> >> >> Paolo
>

> >> >> On Mon, Aug 2, 2010 at 2:30 PM, Jiří Popek <jiri.po...@gmail.com>

> >> >> wrote:
> >> >> > Sure, if I have enough rights to push it in.
> >> >> > J.
>

> >> >> > On Mon, Aug 2, 2010 at 3:26 PM, Paolo Donà <paolo.d...@gmail.com>

> >> >> > wrote:
>
> >> >> >> Thanks mate,
> >> >> >> can you fork the project on github and commit your change?
> >> >> >> Paolo
>

> >> >> >> On Mon, Aug 2, 2010 at 1:09 PM, Jiří Popek <jiri.po...@gmail.com>

>  Screen shot 2010-08-02 at 16.25.07.png
> 68KViewDownload