spec/models nearly green

40 views
Skip to first unread message

Arlen Walker

unread,
Nov 12, 2014, 5:56:09 PM11/12/14
to radiant...@googlegroups.com
Master branch in my fork now is almost green, without any deprecation notices, for spec/models (yes, I'm anal that way; I hate leaving warnings of any type standing). I haven't bunged it in as a serious PR yet because there's a few things yet I'm not sure of:

1) I added pry-byebug to the Gemfile. This is a debugger that only works on ruby > 2.0 so there's no 1.9.x support in that at all. On the flip side, it *does* support the latest rubies (on up into the 2.2 preview, even) where the debugger gem stops at 2.1.2. I think I should "conditionalize" that to include whichever supports the prevailing ruby, but not sure how to go about that at the moment.

2) standard_tags_spec:668 puzzles me. I think the "John Doe" the test is failing with on my system is coming in from Radius, rather than being supplied by the code here, but I couldn't find it. If it fails the same way in someone else's system, I'd feel better about it being in the code instead of popping out of a misconfigured cache or something on my setup. But I can't even locate that string in any of the project files or the test db.

3) There's another test that's red, yet (config_spec:128) because I ran out of functioning synapses before getting to it.

4) And I'm still stymied by the way "bundle exec rake spec" or even "bundle exec rspec" loses contact with the database with a bucketload of FactoryGirl errors, while "bundle exec rspec spec/models" passes the same tests that failed with the other command. So there's something that's gumming up the works when the full suite gets run that doesn't happen without it. I'll feel *so* much better when I know wtf it is.

I also moved two more tests into the "pending" category because they depended upon the Radiant bootstrap task, which we're getting rid of, so whatever I needed to do to make the test past was probably not worth the time. They will return when we've figured out the installation process details

Feel free to hammer on my fork for reality-checks while I work out how best to dress it up for a PR.
Reply all
Reply to author
Forward
0 new messages