running specs on master

[Jim Gay]

Over the last few days I've been working to get the test suite running
on the master branch.

What's the status? It runs.

Everything fails.

This mostly has to do with getting things hooked up properly to have
the right files loaded and our special helpers like "render" actuall
present in RSpec.

I have an existing database for testing, that you may not. Starting up
from scratch doesn't work yet, as you can see at
https://travis-ci.org/radiant/radiant/jobs/4725695

I've tried to keep the commits clean, but I'm doing whatever I can
just to get it running so we are at a meaningful point.

Stay tuned... (and please contribute!)

--
Write intention revealing code #=> http://www.clean-ruby.com

Jim Gay
Saturn Flyer LLC
571-403-0338

[Jim Gay]

Alright, specs are running: https://travis-ci.org/radiant/radiant/jobs/4726850
We rely heavily on the dataset gem to setup our database fixtures.

We either need to get dataset up to speed with rails3/4 or move away from it.

[Benny Degezelle]

Pulled, tested and a first commit pushed.

I wouldn't mind doing the chore of changing datasets/*.rb into fixtures/*.yml, but I highly doubt if it's ideal..

What would you replace dataset with?

Op maandag 11 februari 2013 19:18:02 UTC+1 schreef Jim Gay het volgende:

[Joel Oliveira]

My bias might be showing but I'd always vote for factory girl in this case.  There are pros and cons to all, and while factory girl can be used incorrectly and somewhat abused (like many things), it's a joy to use and I'm a huge fan.

Either fixtures or factory_girl would be great choices if for any other reason than they're ubiquitous enough for newcomers to jump in and feel comfortable quickly.

- Joel

--
--
Radiant CMS Dev Mailing List
Post: radiant...@googlegroups.com
Unsubscribe: radiantcms-de...@googlegroups.com
Group Site: http://groups.google.com/group/radiantcms-dev/
---
You received this message because you are subscribed to the Google Groups "Radiant CMS: Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to radiantcms-de...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Jim Gay]

I just want to chime in here with support for dataset. But I'd rather
not have to maintain it.

Dataset is great because it does database specific dumps and loads of
the data after it's generated. That makes it a really fast fixture
replacement.
Radiant's test suite grew to rely on it in unnecessary ways so that we
ate away that speed.

The downside is that the project is not maintained, and almost nobody
else uses it. It's not up to date with the latest rails/rspec/cucumber
versions. If anyone were to jump on to maintain that project, I think
it would be great. But in the interest of keeping Radiant moving
forward, we should avoid the baggage of an out of date dependency.

[Jon Kinney]

Hey all,

I appreciate the work you continue to do on Radiant! However, I no longer wish to receive these emails as I'm trying to take back control of my inbox. However, when I tried to unsubscribe I received this error:

Delivery to the following recipient failed permanently:

radiantcms-de...@googlegroups.com

Technical details of permanent failure:

Google tried to deliver your message, but it was rejected by the server for the recipient domain googlegroups.com by gmr-smtp-in.l.google.com. [2607:f8b0:4001:c02::e].

The error that the other server returned was:

550-5.1.1 The email account that you tried to reach does not exist.

I'll try going into the google group directly and see if I can do it there. But just wanted to let you know that the unsubscribe via email functionality is broken.

Thanks,

Jon

[Jim Gay]

I've gotten the spec/dummy app running, but the resource_responses
aren't working yet in the pages controller.

I took a break from driving changes from the tests and just went into
spec/dummy to run "rails s" to see what happened.
There are a number of changes on master for this.