State of development

[Karri Niemelä]

Hi guys!

Whats happening with radiant development? 

Is rails 3 migration going forward?

Thanks,

Karri

[Jim Gay]

Yes!

Please contribute for Rails 3 and 4

The master branch is broken right now because it's moving toward Rails 3. If you can jump in, please do.

Currently we have a spec/dummy app where Radiant is being tested as an engine.

Clone the project and run "bundle exec rspec spec"

-Jim

[Sam Whited]

On Thu, Jan 10, 2013 at 10:00 AM, Jim Gay <j...@saturnflyer.com> wrote:
> Please contribute for Rails 3 and 4
>

What does the planned Ruby support look like for Radiant 2?

Perhaps it would be good to go ahead and drop support for 1.8.7 in
preparation for Rails 4 (which only supports Ruby 1.9). While lots of
people are still using 1.8.7 its use should really be discouraged and
I see this being the biggest hurdle when many plan their future
upgrades—

It's always worth planning ahead, and maybe dropping 1.8.7 (officially
at least, I'm sure it would still run for a while) would get people
thinking about migrating earlier rather than later. I noticed that CI
no longer checks 1.8.7, so maybe this has already been planned and I
just missed it.

Best,
Sam

--
Sam Whited
pub 4096R/EC2C9934
https://samwhited.com/contact

[Jim Gay]

On Thu, Jan 10, 2013 at 10:50 AM, Sam Whited <s...@samwhited.com> wrote:
> What does the planned Ruby support look like for Radiant 2?
>
> Perhaps it would be good to go ahead and drop support for 1.8.7 in
> preparation for Rails 4 (which only supports Ruby 1.9). While lots of
> people are still using 1.8.7 its use should really be discouraged and
> I see this being the biggest hurdle when many plan their future
> upgrades—
>
> It's always worth planning ahead, and maybe dropping 1.8.7 (officially
> at least, I'm sure it would still run for a while) would get people
> thinking about migrating earlier rather than later. I noticed that CI
> no longer checks 1.8.7, so maybe this has already been planned and I
> just missed it.
>
> Best,
> Sam

I think we should drop 1.8.7. I dropped it from CI the other day.

I fought hard to keep the upgrade path to Radiant smooth by NOT going
to Rails 3 sooner. After a while I and others got busy with other
non-radiant work. So I see Radiant stagnation essentially being
because I sacrificed progression with Rails over ease of upgrades.

I think that was a mistake.

So I agree, we should encourage everyone to move to Ruby 1.9.3 and above.

-Jim

--
Write intention revealing code #=> http://www.clean-ruby.com

Jim Gay
Saturn Flyer LLC
571-403-0338

[Benny Degezelle]

Whether or not this post has triggered it, awesome to see some fresh commits again!

I took some time to try and get the specs working, but like Sam (I guess) haven't succeeded yet.

How do you guys set up your environment to work on Radiant?

Here's what I tried;

  rails new dummy

  cd dummy

  echo 'gem "radiant", :path => "vendor/radiant"' >> Gemfile'

  git clone g...@github.com:radiant/radiant.git vendor/radiant

  bundle install

I believe that if core wasn't broken, I'd have a working environment now, right?

I tried rake spec, but, like Sam I guess, get errors originating from instance.rake and then others if I edit that.

Is this THE 'not working' that I'm hitting, or am I missing something?

If it is, I think I'm already some steps closer towards a functional Radiant again (though nothing committable yet).

[Jim Gay]

Right now I've just got the project cloned to master and run "bundle
install" and then "bundle exec rake spec"
For the most part, nothing is working with the test suite.

I haven't tried connecting it to a project and loading it there, so
what you are doing is probably what I'd be doing too.

> --
> Radiant CMS Dev Mailing List
> Post: radiant...@googlegroups.com
> Unsubscribe: radiantcms-de...@googlegroups.com
> Group Site: http://groups.google.com/group/radiantcms-dev/

[Benny Degezelle]

Ok.. poking on. ;)

Op donderdag 10 januari 2013 23:38:25 UTC+1 schreef Jim Gay het volgende:

[Benny Degezelle]

Wow, I never went this deep into Radiant.. my head hurts! :)

Seriously, there is quite a lot of réally old (0.6) stuff in there that we don't need anymore.

I'm thinking Annotatable, LocalTime, InheritableClassAttributes, ...

Also, the whole "Radiant instance" idea is gone if we are switching to an Engine. Again a lot of code to 'search and destroy'.

Seeing we also want to rip out LoginSystem, and probably Dataset too, I'm starting to wonder if we wouldn't be better off rewriting from scratch?

I know it sounds daunting, but I think it would be much cleaner and probably even easier that way.

I don't mind very much about breaking backwards compatibility, and now is the time if we're ever going to.

I have mostly just copied the database and any custom extensions to a new Radiant instance when I wanted to update to even a new minor version anyway..

Extensions will need to be updated to work with 2.0 too (i.e. Page > Radiant::Page), but I don't see why their upgrade path would have to be different if we indeed choose to rewrite.

Let me know your thoughts, I'm with you guys either way.

Op donderdag 10 januari 2013 23:52:54 UTC+1 schreef Benny Degezelle het volgende:

[Jim Gay]

There's a lot of old stuff in there.

At this point I think we should focus on just getting the tests
running. Or if you like, manually getting it running in a Rails 3
project.

I went down the road of a rewrite and tried to pull out just the
page.rb and page_spec.rb files but found that our code is so tightly
coupled that I had to pull in several other models just to get the
page spec to run (almost all of the models, if I remember correctly).

Radiant is old and has had many cooks in the kitchen. The most
valuable thing at this point during a transition are the specs, so I'd
love to get those running however we do it.
Pulling out LoginSystem for example would require that we change it so
that another one can be put in. I think it might be premature to try
that before we even have it running. But it depends on what everyone
is doing. If you want to tackle it, please do and we'll all help where
we can. For now, I'm focusing on just changing what needs to be
changed to keep the specs running.

On Thu, Jan 10, 2013 at 8:54 PM, Benny Degezelle

[Sam Whited]

On Fri, Jan 11, 2013 at 11:19 AM, Jim Gay <j...@saturnflyer.com> wrote:
> Pulling out LoginSystem for example would require that we change it so
> that another one can be put in. I think it might be premature to try
> that before we even have it running.

I agree; I'd love to see login and/or users pulled out before 2.0, but
we should definitely focus on getting the specs passing first.

—Sam

[Johannes Fahrenkrug]

Hi guys,

I agree with Jim that the specs are very very valuable and that we should get them up and running. Radiant is old, yes. But that's also one of its strongpoints: It had time to mature and to stabilize. If we started from scratch, threw everything away and completely broke backwards compatibility and existing extensions, we will kill Radiant. If we did that, a lot of users would head over to one of the other Rails CMSs. I think we should - for the sake of our users and extension developers - make the upgrade path as smooth as possible. Get the tests passing first, then throw away unneeded code and then work on an upgrade strategy for 1.0 installations.

Just my 2 cents :)

- Johannes

[qutic development]

I totally agree with Johannes. Using existing extensions is really important, because there are a lot of them out here with a high quality! If it breaks this would be the end of Radiant - in my opinion.

- Stefan

[Benny Degezelle]

Aye, I understand the concerns, but I was not talking about 'fully breaking backwards compatibility'.

I do believe however that if we want Radiant and it's extensions to be ran as engines, every extension wíll have to be updated for 2.0.

The update would be quite simple in most cases thought; probably move the contents from extension_root/foo_extension.rb into extension_root/lib/foo.rb, and update all references to Radiant models and controllers to consider namespacing.

At Sam and anyone else trying to get edge working; I got the specs running again, be it with way more failing than succeeding tests.

Since I was not too sure about my edits and did not want to get into anybody's way, I pushed to my own fork at https://github.com/jomz/radiant/

It's still on dataset even though that fails (i.e. Could not find table 'user')

Please do have a look and cherry-pick what you can use.

Op maandag 14 januari 2013 15:16:55 UTC+1 schreef jerry het volgende:

[Johannes Fahrenkrug]

Changing some boilerplate code to make extensions work in 2.0 is not a problem, I think. That would be acceptable and expected.

[TR NS]

+1 Drop 1.8.7 support.

Do you guys have any kind of time frame for when it might be ready? (No pressure. I just have a client to set up a site for and I need to plan accordingly.)

I'm trying to deploy on OpenShift and running into some trouble. Openshift automates a lot to make things "easy", but I'm starting to think that it's just not geared for anything less then Rails 3. Has anyone else had any success in setting Radiant up on Openshift? (Guess I should ask that in the regular list).

Anyway, big thanks for all the hard work.