Hi all,
I'd like to know what process we have for merging contributions to
split-out packages that are somewhat core-ish, such as those making up
the net collect.
Perhaps the process could be:
1. fork the repo
2. make the change
3. make a pull request
4. get someone (who?) to review it
5. if it passes review, merge
The question "who" is interesting, and I can imagine that perhaps two
reviewers might be preferred or similar. Thoughts?
Here's a concrete example: I recently forked
github.com/racket/net to
add support for SRV. I made a pull request and Asumu kindly took the
time to review it. After incorporating his feedback, I got a "looks good
to me" from him, and now I'd like to know if it's OK to just go ahead
and merge it in (since both he and I happen to have the commit bit
there, I think).
Thanks! And sorry if this is some kind of FAQ. I found [1], but it
focusses more on the core repo and not on split-out packages.
Tony
[1]
http://www.greghendershott.com/2013/04/a-guide-for-infrequent-contributors-to-racket.html