Rack::Server patch

[Yehuda Katz]

Hey guys,

Carl and I spent a couple of day refactoring the code in bin/rackup into Rack::Server. The main motivation for this was to enable Rails to ditch our code in script/server and simply inherit from the requisite Rack code. I think the code improvement speaks for itself. In the process of this work, we also moved a few things out of Rackup into more usable locations, like Rack::Handler.default (to get the handler that Rack will use if none is specified) and Rack::Builder.parse_file (which we currently duplicate in ActionDispatch).

You can check out the changes at github.com/carllerche/rack, and I have also attached a patch. In addition to converting the rackup binary to a class, we also wrote tests for each function of rackup, to be sure we wouldn't break anything in the refactor. As a result, this patch now has tests for rackup!

Yehuda Katz
Developer | Engine Yard
(ph) 718.877.1325

[Yehuda Katz]

Patches attached.

[1] tests_patch.diff -- Adds tests for the functionality of rackup

[2] rack_server_patch.diff -- Moves Rack::Server into a separate object

Yehuda Katz
Developer | Engine Yard
(ph) 718.877.1325

2009/11/20 Yehuda Katz <wyc...@gmail.com>

[Yehuda Katz]

Patches attached.

[1] tests_patch.diff -- Adds tests for the functionality of rackup

[2] rack_server_patch.diff -- Moves Rack::Server into a separate object

Yehuda Katz
Developer | Engine Yard
(ph) 718.877.1325

2009/11/20 Yehuda Katz <wyc...@gmail.com>

[Joshua Peek]

+1 Looks good.

My only suggestion would be to keep the old pid/daemonize behavior. So
don't set a default pid file and only set one if its provided.

--
Joshua Peek

[Christian Neukirchen]

Joshua Peek <jo...@joshpeek.com> writes:

> So
> don't set a default pid file and only set one if its provided.

+1

--
Christian Neukirchen <chneuk...@gmail.com> http://chneukirchen.org

[Christian Neukirchen]

Yehuda Katz <wyc...@gmail.com> writes:

> [1] tests_patch.diff -- Adds tests for the functionality of rackup
> [2] rack_server_patch.diff -- Moves Rack::Server into a separate object

LGTM.