[PATCH] Avoid slurping or parsing request body on PUT requests

[Eric Wong]

Uploading a large file via the HTTP PUT method causes
`@env["rack.input"].read' to be called inside the POST method. This
means the entire file is slurped into memory and was needlessly causing
my Sinatra process to eat up 300M+ for some uploads I've been doing.
---

I actually opened a report for this on Rubyforge, but I realized
that I often forget about that on my projects, as well.

http://rubyforge.org/tracker/index.php?func=detail&aid=22346&group_id=3113&atid=12001

lib/rack/request.rb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/rack/request.rb b/lib/rack/request.rb
index 9d16f49..2cf1944 100644
--- a/lib/rack/request.rb
+++ b/lib/rack/request.rb
@@ -122,7 +122,7 @@ module Rack

# The union of GET and POST data.
def params
- self.GET.update(self.POST)
+ self.put? ? self.GET : self.GET.update(self.POST)
rescue EOFError => e
self.GET
end
--
Eric Wong

[Christian Neukirchen]

Eric Wong <normal...@yhbt.net> writes:

> Uploading a large file via the HTTP PUT method causes
> `@env["rack.input"].read' to be called inside the POST method. This
> means the entire file is slurped into memory and was needlessly causing
> my Sinatra process to eat up 300M+ for some uploads I've been doing.
> ---
>
> I actually opened a report for this on Rubyforge, but I realized
> that I often forget about that on my projects, as well.

Your patch breaks all POST uploads, doesn't it?

If you use a proper multipart (NOT url-encoded!) it should use a tempfile...

--
Christian Neukirchen <chneuk...@gmail.com> http://chneukirchen.org

[Eric Wong]

On Oct 19, 10:29 am, Christian Neukirchen <chneukirc...@gmail.com>
wrote:

> Eric Wong <normalper...@yhbt.net> writes:
> > Uploading a large file via the HTTP PUT method causes
> > `@env["rack.input"].read' to be called inside the POST method.  This
> > means the entire file is slurped into memory and was needlessly causing
> > my Sinatra process to eat up 300M+ for some uploads I've been doing.
> > ---
>
> >  I actually opened a report for this on Rubyforge, but I realized
> >  that I often forget about that on my projects, as well.
>
> Your patch breaks all POST uploads, doesn't it?
>
> If you use a proper multipart (NOT url-encoded!) it should use a tempfile...

test/spec_rack_request.rb with POST uploads seem to pass. I'm not
sure about users of the MethodOverride hack...

I'm real PUT requests generated with curl, not the MethodOverride hack
via browsers; so none of my requests are multipart.

[Christian Neukirchen]

Eric Wong <normal...@gmail.com> writes:

Wouldn't it be easier to just don't call POST then?

[Eric Wong]

On Oct 21, 3:50 pm, Christian Neukirchen <chneukirc...@gmail.com>
wrote:

You mean the POST method in Rack::Request? That's exactly what my
patch
does inside Rack::Request#params. If a PUT request is detected, then
I
avoid calling Rack::Request#POST.

[Ben Bleything]

Is there any update on this patch? This problem is biting me right
now and I'd really like to see it resolved :)

[Christian Neukirchen]

Ben Bleything <b...@bleything.net> writes:

> Is there any update on this patch? This problem is biting me right
> now and I'd really like to see it resolved :)

Applied now, I misunderstood the patch.

[Ben Bleything]

On Nov 28, 6:59 am, Christian Neukirchen <chneukirc...@gmail.com>
wrote:

> Applied now, I misunderstood the patch.

Great! Thanks, Christian!