BasicProperties no longer public in .NET library

[Peter Morlion]

I just want to be sure I'm not missing something. But in version 5.1.2 of the RabbitMQ.Client .NET package, I could construct a new instance of the BasicProperties class (in the RabbitMQ.Client.Framing namespace).

In version 6.0.0, this is no longer possible and I have to call the channel.CreateBasicProperties() method.

However, this (breaking) change isn't specified in the changelog anywhere. I'm not complaining, just want to be sure (because I need to mention it in a LinkedIn Learning course I'm making) and maybe it should be added to the changelog?

Thanks in advance.

[Luke Bakken]

Hi Peter,

There were so many changes in 6.0 that some were bound to be missed. We would welcome a PR to update whatever documentation is not correct.

Please be sure to use the latest version of the library, 6.2.1 - https://www.nuget.org/packages/RabbitMQ.Client/6.2.1

Thanks,

Luke

[Ivan Abragimovich]

Hey Luke,

Is there any particular reason for this change? Can it be reverted?

Let me put a little context here:

I am currently busy with the wrapper library for RabbitMQ.Client, and I am going to migrate it from 5.2.1 to 6.2.1.

Unfortunately is not easy to do for two primary reasons:

1. As was previously mentioned by Peter, BasicProperties class is now marked as internal "https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/projects/RabbitMQ.Client/client/impl/BasicProperties.cs#L36". Therefore for 3rd part developers like me, it is not possible anymore to easily created without the usage of reflection.

2. The first point could be still manageable, in a case when everywhere inside "RabbitMQ.Client" will rely on the interface of this class (IBasicProperties).  Unfortunately, there are two places where IBasicProperties interface explicitly is downcasted to the specific implementation of this interface(class BasicProperties). These places can be found here:

a) https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/projects/RabbitMQ.Client/client/framing/Model.cs#L67

b) https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/projects/RabbitMQ.Client/client/framing/Model.cs#L72

So, if this class has been marked as internal accidentally, I will be glad to provide PR for reverting this change back. Otherwise, and more preferable IMHO, it is better to remove the dependency of a specific class implementation inside of Model class and use methods of an interface only.

Best regards,

Ivan

[Guise]

My 2¢ - I would also vote for the latter. BasicProperties is somewhat unusual in that it is simultaneously a low-level implementation detail at the wire protocol, and also a high level interface in the public API, therefore it makes sense to draw a line between the interface and the implementation.

[Ilya Khaprov]

Hello,

Please feel free do the PR and assign me (deadtrickster) for the review.

Regards