Issue 1544 in quodlibet: "Prefer embedded art" doesn't work

[quod...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Normal

New issue 1544 by elBoulan...@gmail.com: "Prefer embedded art" doesn't work
https://code.google.com/p/quodlibet/issues/detail?id=1544

Please describe the problem thoroughly and accurately. If possible paste
the contents of the ~/.quodlibet Dump or MiniDump file associated with the
problem.

- What did you try to do?
Take an audio file which contains embedded cover art.
Checked the preference "Browsers -> Album Art -> Prefer embedded art" in
Quodlibet.
Paste a random picture in the same directory, with name folder.jpg for
example.

- What did you expect to happen?
See the cover embedded in the audio file

- What did happen instead?
I see the picture from the file "folder.jpg"

- Which version of Quod Libet?
Mercurial

- Which operating system including version (Ubuntu 14.04, Win7, Debian
sid, ...)?

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[quod...@googlecode.com]

Updates:
Status: NeedInfo

Comment #1 on issue 1544 by reiter.c...@gmail.com: "Prefer embedded

art" doesn't work
https://code.google.com/p/quodlibet/issues/detail?id=1544

I can't reproduce. Can you see the embedded image in case you remove all
image files in that folder and subfolders?

[quod...@googlecode.com]

Comment #2 on issue 1544 by elBoulan...@gmail.com: "Prefer embedded art"

doesn't work
https://code.google.com/p/quodlibet/issues/detail?id=1544

After some investigation, it seems that the "Prefer embedded art" was
broken in the changeset 6896, in the file
quodlibet/quodlibet/util/cover/built_in.py.

@staticmethod
def priority():
- if config.getboolean("albumart", "prefer_embedded", False):
- return 0.99
- else:
- return 0.7001
+ return 0.7001

Reverting this part fix the issue.

[quod...@googlecode.com]

Comment #3 on issue 1544 by elBoulan...@gmail.com: "Prefer embedded art"

doesn't work
https://code.google.com/p/quodlibet/issues/detail?id=1544

Yep, I can see the embedded image if I remove all image files

[quod...@googlecode.com]

Comment #4 on issue 1544 by elBoulan...@gmail.com: "Prefer embedded art"

doesn't work
https://code.google.com/p/quodlibet/issues/detail?id=1544

I use Quodlibet on Linux in case it matters.

I re-checked today for this bug, it's a bug for sure. At first my tests
gave unexpected results, since Quodlibet uses every file with the 'folder'
keyword, and I renamed my files in 'folder-backup' or so. It gave a false
impression that everything worked well.

May I suggest this little patch to improve the debug message, attached.


I there anything I can do to provide more info about this issue ?

Regards

Attachments:
cover-manager-debug-message.patch 623 bytes

[quod...@googlecode.com]

Updates:
Status: Open

Comment #5 on issue 1544 by reiter.c...@gmail.com: "Prefer embedded

art" doesn't work
https://code.google.com/p/quodlibet/issues/detail?id=1544

The check in built_in was moved to manager.py. I'll have another look,
thanks.