Issue 1556 in quodlibet: Add close escape accel for tagedit/info window

[quod...@googlecode.com]

Status: Open
Owner: reiter.c...@gmail.com
Labels: Type-Enhancement

New issue 1556 by reiter.c...@gmail.com: Add close escape accel for
tagedit/info window
https://code.google.com/p/quodlibet/issues/detail?id=1556

This has come up multiple times. The initial reason it doesn't have them
was (IIRC) that the HIG only specified it for dialogs and it could close
the window when canceling a cellrenderer in the tag editor while changing
text.

TODO:

1) Add a dialog for when there are unsaved changes ("Close
Window", "Continue Editing")
2) Enable esc accel

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[quod...@googlecode.com]

Comment #1 on issue 1556 by mur...@gmail.com: Add close escape accel for
tagedit/info window
https://code.google.com/p/quodlibet/issues/detail?id=1556

It's also bad for people with muscle memory inspired by vi. Is the problem
that C-w is too undiscoverable?

[quod...@googlecode.com]

Comment #2 on issue 1556 by reiter.c...@gmail.com: Add close escape

accel for tagedit/info window
https://code.google.com/p/quodlibet/issues/detail?id=1556

(I've opened this in reference to
https://groups.google.com/forum/#!topic/quod-libet-development/PEQZq6l02Xc )

My guess is that you can get by using alt+f4 + esc alone in many other
applications. So ctrl+w doesn't come to mind.

In which scenario(s) do you think you will hit esc due to vi muscle memory?
(no vi user..)

[quod...@googlecode.com]

Comment #3 on issue 1556 by mur...@gmail.com: Add close escape accel for
tagedit/info window
https://code.google.com/p/quodlibet/issues/detail?id=1556

In vi you use Escape to switch from typing to moving, so perhaps after
typing in the new value for a tag. (I'm no longer in the habit myself.) The
proposed confirmation dialog may address that case, so long as escape
cancels the close.

If Alt+F4 doesn't work, that sounds like a bug, but it isn't any nicer to
press than Ctrl+F4.