Question about lyrics storage and view

[W. Martin Borgert]

Hi,

I have two questions about the lyrics handling of Quodlibet
(version 2.3.2 on Debian):

1. Storage of lyrics works this way:

~/.lyrics/<artist>/<title>.lyric

IMHO, lyrics are related to the lyricist, not the artist.
While I did not yet encounter a conflict (same artist has
two different songs with the same title), I have to store
the same lyrics multiple times, because different artists
interpret the same song.

Are there any objections against a change? Would you accept
a patch?

(The "artist" tag can still be used as fallback, if the
"lyricist" tag does not exist.)

2. Viewing lyrics is not well supported by Quodlibet. There
exists a nice plugin, but it does work only for Quodlibet
<= 2.2: http://vasiliy.faronov.name/viewlyrics/

Are there any plans to integrate such a funcionality into
Quodlibet? Can somebody more experienced with GTK+ than me
fix the plugin?

Cheers

[Christoph Reiter]

On Feb 4, 12:47 pm, "W. Martin Borgert" <deba...@debian.org> wrote:
> [...]

>     Are there any objections against a change? Would you accept
>     a patch?
>
>     (The "artist" tag can still be used as fallback, if the
>     "lyricist" tag does not exist.)

OK with me.

>  2. Viewing lyrics is not well supported by Quodlibet. There
>     exists a nice plugin, but it does work only for Quodlibet
>     <= 2.2:http://vasiliy.faronov.name/viewlyrics/

s/songpane/child/ in the plugin

>     Are there any plans to integrate such a funcionality into

>     Quodlibet? [...]

There was a plan to add an optional sidebar (or dockable window) where
plugins can show song/selection depended information.

> Cheers

Thanks for your package sponsoring.

[W. Martin Borgert]

On 2012-02-04 05:45, Christoph Reiter wrote:
> On Feb 4, 12:47 pm, "W. Martin Borgert" <deba...@debian.org> wrote:
> > [...]
> >     Are there any objections against a change? Would you accept
> >     a patch?
> >
> >     (The "artist" tag can still be used as fallback, if the
> >     "lyricist" tag does not exist.)
>
> OK with me.

Thanks! How about this one line change?

--- formats/_audio.py.orig 2012-02-04 16:05:28.000000000 +0000
+++ formats/_audio.py 2012-02-04 16:07:03.000000000 +0000
@@ -292,7 +292,7 @@

lyric_filename = property(lambda self: util.fsencode(
os.path.join(util.expanduser("~/.lyrics"),
- self.comma("artist").replace('/', '')[:128],
+ (self.comma("lyricist") or self.comma("artist")).replace('/', '')[:128],
self.comma("title").replace('/', '')[:128] + '.lyric')))

def comma(self, key):

> >  2. Viewing lyrics is not well supported by Quodlibet. There
> >     exists a nice plugin, but it does work only for Quodlibet
> >     <= 2.2:http://vasiliy.faronov.name/viewlyrics/
>
> s/songpane/child/ in the plugin

Thanks, works perfectly. (I forwarded this information to the
author.)

> >     Are there any plans to integrate such a funcionality into
> >     Quodlibet? [...]
>
> There was a plan to add an optional sidebar (or dockable window) where
> plugins can show song/selection depended information.

Sounds very useful. Anyway, how about adding the existing view
lyrics plugin to Quod Libet for short term benefit?

> Thanks for your package sponsoring.

Gern geschehen.

[W. Martin Borgert]

Just a ping. The change I proposed last week works well for me.
Would you adopt it or do you have objections?

On 2012-02-04 16:26, W. Martin Borgert wrote:
> On 2012-02-04 05:45, Christoph Reiter wrote:
> > OK with me.
>
> Thanks! How about this one line change?
>
> --- formats/_audio.py.orig 2012-02-04 16:05:28.000000000 +0000
> +++ formats/_audio.py 2012-02-04 16:07:03.000000000 +0000
> @@ -292,7 +292,7 @@
>
> lyric_filename = property(lambda self: util.fsencode(
> os.path.join(util.expanduser("~/.lyrics"),
> - self.comma("artist").replace('/', '')[:128],
> + (self.comma("lyricist") or self.comma("artist")).replace('/', '')[:128],
> self.comma("title").replace('/', '')[:128] + '.lyric')))
>
> def comma(self, key):

And:

> Anyway, how about adding the existing view
> lyrics plugin to Quod Libet for short term benefit?

The author corrected and enhanced the plugin. You can find it here:
https://github.com/vfaronov/quodlibet-viewlyrics
Adding it to the stock Quod Libet plugins would be useful.

Cheers

[Nick B]

On 11/02/12 12:04, W. Martin Borgert wrote:
> Just a ping. The change I proposed last week works well for me.
> Would you adopt it or do you have objections?

I don't use lyrics features, but it looks fine to me, in theory.

> The author corrected and enhanced the plugin. You can find it here:
> https://github.com/vfaronov/quodlibet-viewlyrics
> Adding it to the stock Quod Libet plugins would be useful.

Personally I have no objections to committing this after a quick test,
though I think the request should come from (or at least approved by)
the author.

[W. Martin Borgert]

On 2012-02-11 12:42, Nick B wrote:
> On 11/02/12 12:04, W. Martin Borgert wrote:
> >Just a ping. The change I proposed last week works well for me.
> >Would you adopt it or do you have objections?
>
> I don't use lyrics features, but it looks fine to me, in theory.

I only use it since recently, because I didn't know about the
viewlyrics plugin. Without easily viewing lyrics, the feature
does not make much sense. And without the patch, lyrics are
organised in a strange way, which makes the lyrics feature less
attractive, in case one has multiple versions of the same song.

> >The author corrected and enhanced the plugin. You can find it here:
> >https://github.com/vfaronov/quodlibet-viewlyrics
> >Adding it to the stock Quod Libet plugins would be useful.
>
> Personally I have no objections to committing this after a quick
> test, though I think the request should come from (or at least
> approved by) the author.

He wrote me, that he would be fine with that, but I will ask him
to write to you or the list.

[Vasiliy Faronov]

Hi,

On Feb 11, 4:42 pm, Nick B <nick.boult...@gmail.com> wrote:
> Personally I have no objections to committing this after a quick test,
> though I think the request should come from (or at least approved by)
> the author.

Of course, adding this plugin to QL is perfectly fine by me.

--
Vasiliy Faronov

[W. Martin Borgert]

On 2012-02-04 16:26, W. Martin Borgert wrote:

> On 2012-02-04 05:45, Christoph Reiter wrote:
> > On Feb 4, 12:47 pm, "W. Martin Borgert" <deba...@debian.org> wrote:
> > > [...]
> > >     Are there any objections against a change? Would you accept
> > >     a patch?
> > >
> > >     (The "artist" tag can still be used as fallback, if the
> > >     "lyricist" tag does not exist.)
> >
> > OK with me.
>
> Thanks! How about this one line change?
>
> --- formats/_audio.py.orig 2012-02-04 16:05:28.000000000 +0000
> +++ formats/_audio.py 2012-02-04 16:07:03.000000000 +0000
> @@ -292,7 +292,7 @@
>
> lyric_filename = property(lambda self: util.fsencode(
> os.path.join(util.expanduser("~/.lyrics"),
> - self.comma("artist").replace('/', '')[:128],
> + (self.comma("lyricist") or self.comma("artist")).replace('/', '')[:128],
> self.comma("title").replace('/', '')[:128] + '.lyric')))
>
> def comma(self, key):

Unfortunately, the change is not in 2.4. Was anything wrong with
the patch or should I have made it a bug report? Any chance to
get it in the next release? TIA!

[W. Martin Borgert]

Unfortunately, the plugin[*] didn't made it in 2.4. Any chance
to get it into the next release? Or is there anything wrong with
it? TIA.

[*] http://vasiliy.faronov.name/viewlyrics/

[Christoph Reiter]

2012/3/19 W. Martin Borgert <deb...@debian.org>:

> Unfortunately, the change is not in 2.4. Was anything wrong with
> the patch or should I have made it a bug report? Any chance to
> get it in the next release? TIA!

I commited both, your patch and the plugin, in trunk yesterday. 2.4
had bugfix changes only since mid January.

[W. Martin Borgert]

OK, thanks! It seems, I was out of track in respect to the
release process...