Reorder pages

21 views
Skip to first unread message

Stefan Langerman

unread,
Jan 22, 2012, 3:58:10 PM1/22/12
to quill...@googlegroups.com
Hi Volker (and hello everyone),
Thanks for pointing me to this group, and for adding in my "Duplicate page" feature.
I noticed you did not include the "Page Swap" feature. Any reason for that?
It is probably not the most elegant way to implement page reordering, but it does the job for now.
I do need page reordering in my daily usage of quill. I use it for sketching presentations.
Probably a better way for doing it was to have a draggable list for reordering the pages... for example using that:

Btw, I do not understand how the ThumbnailActivity works. It allows me to select pages, but I don't know what to do with the selection.

And lastly a newbie question: what is the best way to share my changes with you? Should I just push back my changesets to google code?

Stefan.


Volker Braun

unread,
Jan 22, 2012, 10:15:40 PM1/22/12
to quill...@googlegroups.com
Hi Stefan,

Sorry I wanted to send you a message but I was out hiking today ;-) I think your current patch will lead to problems with undo, basically you must never manipulate the pages list directly everything has to go through the undo manager (or at least explicitly kill the undo stack). But then I didn't have enough time to think about all possible implications.

The thumbnail multiselect doesn't to anything at the moment, thats right. I thought for starters that if two pages are selected, then it should show a "swap" menu item. That would be easy to implement and pretty logical. Drag and drop sounds like it would be the most natural but then it seems like its not as useful for many pages (where you would have to scroll). 


Volker Braun

unread,
Jan 22, 2012, 10:32:08 PM1/22/12
to quill...@googlegroups.com
PS: I think the best workflow is for you to create a clone on google code 

Stefan Langerman

unread,
Jan 23, 2012, 8:59:19 AM1/23/12
to quill...@googlegroups.com
Ah you are right! I overlooked the undo part. 
Hm... it seems the best would be to just add another option to the CommandPage.
Actually, wouldn't it be better to subclass CommandPage with the diverse commands one can do on a page (insert, delete, move, change paper, etc), that way all other actions on paper other than insert/delete could be undoable (paper type, aspect ratio, page clear!!)

The scroll-to-move interface is what is used in apple preview and it works pretty well I think. It is not too common to have to move a page really far.
If we want to be more fancy, we could allow to place pages in several nested levels (like in Apple Keynote) that would be collapsible. That way, the "notebooks" could even be the same level, and thus we would be able to move pages from one notebook to another.
But for now I'm happy even with a simple swap option.

Unrelated question: do you know how to capture the button presses on the digitizer pen? On Xournal (linux), there is the option to make the pen act as an eraser when the button is pressed, I find that really useful so I would like to add that option here.


Volker Braun

unread,
Jan 23, 2012, 12:04:32 PM1/23/12
to quill...@googlegroups.com
On Monday, January 23, 2012 5:59:19 AM UTC-8, Stefan Langerman wrote:
Unrelated question: do you know how to capture the button presses on the digitizer pen? On Xournal (linux), there is the option to make the pen act as an eraser when the button is pressed, I find that really useful so I would like to add that option here.

I have never been able to detect the button press on the stylus. In fact, it seems to only do something in the launcher, which might be modified by Lenovo to allow that.


Reply all
Reply to author
Forward
0 new messages